fix incorrect delegate method (#4630)

* fix incorrect delegate method

* add version test
This commit is contained in:
jason plumb 2021-11-10 22:21:04 -08:00 committed by GitHub
parent 4719e4cc79
commit 5cbd09e4da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 5 deletions

View File

@ -336,7 +336,7 @@ class TracerTest extends AgentInstrumentationSpecification {
// this test uses opentelemetry-api-1.4 instrumentation
def "test tracer builder"() {
when:
def tracer = GlobalOpenTelemetry.get().tracerBuilder("test").build()
def tracer = GlobalOpenTelemetry.get().tracerBuilder("test").setInstrumentationVersion("1.2.3").build()
def testSpan = tracer.spanBuilder("test").setSpanKind(PRODUCER).startSpan()
testSpan.end()
@ -347,6 +347,7 @@ class TracerTest extends AgentInstrumentationSpecification {
name "test"
kind PRODUCER
hasNoParent()
instrumentationLibraryVersion "1.2.3"
attributes {
}
}

View File

@ -18,14 +18,14 @@ class ApplicationTracerBuilder implements TracerBuilder {
}
@Override
public TracerBuilder setSchemaUrl(String s) {
agentTracerBuilder.setSchemaUrl(s);
public TracerBuilder setSchemaUrl(String schemaUrl) {
agentTracerBuilder.setSchemaUrl(schemaUrl);
return this;
}
@Override
public TracerBuilder setInstrumentationVersion(String s) {
agentTracerBuilder.setSchemaUrl(s);
public TracerBuilder setInstrumentationVersion(String version) {
agentTracerBuilder.setInstrumentationVersion(version);
return this;
}

View File

@ -65,6 +65,11 @@ class SpanAssert {
checked.name = true
}
def instrumentationLibraryVersion(String expected) {
assert span.instrumentationLibraryInfo.version == expected
checked.instrumentationLibraryVersion = true
}
def name(Pattern expected) {
assert span.name =~ expected
checked.name = true