open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize HasSuperMethodMatcher logic 

Instead of filtering then iterating, just iterate through everything and apply filter inline.

This will help avoid allocation for filter iterator and improve if early match is found.
This commit is contained in:
Tyler Benson 2020-01-07 17:10:01 -08:00
parent 8500dbc2ba
commit 5e8af8439a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/ByteBuddyElementMatchers.java
View File

@ -328,9 +328,8 @@ public class ByteBuddyElementMatchers {
final Set<TypeDefinition> checkedInterfaces = new HashSet<>(); final Set<TypeDefinition> checkedInterfaces = new HashSet<>();
while (declaringType != null) { while (declaringType != null) {
for (final MethodDescription methodDescription : for (final MethodDescription methodDescription : declaringType.getDeclaredMethods()) {
declaringType.getDeclaredMethods().filter(signatureMatcher)) { if (signatureMatcher.matches(methodDescription) && matcher.matches(methodDescription)) {
if (matcher.matches(methodDescription)) {
return true; return true;
} }
} }