From 61d85d997a285e4d4f37f1297a29ab1f2ac623d0 Mon Sep 17 00:00:00 2001
From: Marco Ferrer <35935108+marcoferrer@users.noreply.github.com>
Date: Fri, 6 Sep 2019 18:42:11 -0400
Subject: [PATCH] add comments for tracing call forwarder

---
 .../grpc/server/TracingServerInterceptor.java             | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/server/TracingServerInterceptor.java b/dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/server/TracingServerInterceptor.java
index 599ee05514..60b6d3898c 100644
--- a/dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/server/TracingServerInterceptor.java
+++ b/dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/server/TracingServerInterceptor.java
@@ -62,8 +62,11 @@ public class TracingServerInterceptor implements ServerInterceptor {
 
     final ServerCall.Listener<ReqT> result;
     try {
-      // call other interceptors
+      // Wrap the server call so that we can decorate the span
+      // with the resulting status
       TracingServerCall<ReqT, RespT> tracingServerCall = new TracingServerCall<>(tracer, span, call);
+
+      // call other interceptors
       result = next.startCall(tracingServerCall, headers);
     } catch (final Throwable e) {
       DECORATE.onError(span, e);
@@ -107,9 +110,6 @@ public class TracingServerInterceptor implements ServerInterceptor {
       } catch (final Throwable e) {
         DECORATE.onError(span, e);
         throw e;
-      } finally {
-        DECORATE.beforeFinish(span);
-        span.finish();
       }
     }