open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing @Unroll to jax-rs 1 tests (#2544) 

To avoid test failures like this one:

```
Execution failed for task ':instrumentation:jaxrs:jaxrs-1.0:javaagent:test'.
> Received a failure event for test with unknown id '23.11'. Registered test ids: '[:instrumentation:jaxrs:jaxrs-1.0:javaagent:test, 23.2, 23.1]'
```
This commit is contained in:
Mateusz Rzeszutek 2021-03-10 21:32:53 +01:00 committed by GitHub
parent 569b7b5818
commit 62c039372d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
instrumentation/jaxrs/jaxrs-1.0/javaagent/src/test/groovy/JaxRsAnnotations1InstrumentationTest.groovy
View File

@ -14,6 +14,7 @@ import javax.ws.rs.OPTIONS
import javax.ws.rs.POST import javax.ws.rs.POST
import javax.ws.rs.PUT import javax.ws.rs.PUT
import javax.ws.rs.Path import javax.ws.rs.Path
import spock.lang.Unroll
class JaxRsAnnotations1InstrumentationTest extends AgentInstrumentationSpecification { class JaxRsAnnotations1InstrumentationTest extends AgentInstrumentationSpecification {
@ -38,6 +39,7 @@ class JaxRsAnnotations1InstrumentationTest extends AgentInstrumentationSpecifica
} }
} }
@Unroll
def "span named '#paramName' from annotations on class when is not root span"() { def "span named '#paramName' from annotations on class when is not root span"() {
setup: setup:
runUnderServerTrace("test") { runUnderServerTrace("test") {

2
instrumentation/jaxrs/jaxrs-1.0/javaagent/src/test/groovy/JerseyTest.groovy
View File

@ -10,6 +10,7 @@ import io.dropwizard.testing.junit.ResourceTestRule
import io.opentelemetry.instrumentation.test.AgentInstrumentationSpecification import io.opentelemetry.instrumentation.test.AgentInstrumentationSpecification
import org.junit.ClassRule import org.junit.ClassRule
import spock.lang.Shared import spock.lang.Shared
import spock.lang.Unroll
class JerseyTest extends AgentInstrumentationSpecification { class JerseyTest extends AgentInstrumentationSpecification {
@ -21,6 +22,7 @@ class JerseyTest extends AgentInstrumentationSpecification {
.addResource(new Resource.Test3()) .addResource(new Resource.Test3())
.build() .build()
@Unroll
def "test #resource"() { def "test #resource"() {
when: when:
// start a trace because the test doesn't go through any servlet or other instrumentation. // start a trace because the test doesn't go through any servlet or other instrumentation.