[PR #1] making fields private

This commit is contained in:
Guillaume Polaert 2017-05-02 17:22:41 +02:00
parent 772e969a17
commit 6aa6ac32db
4 changed files with 14 additions and 14 deletions

View File

@ -9,7 +9,7 @@ import io.opentracing.Span;
*/ */
public class DDSpanSerializer { public class DDSpanSerializer {
protected final ObjectMapper objectMapper = new ObjectMapper(); private final ObjectMapper objectMapper = new ObjectMapper();
/* (non-Javadoc) /* (non-Javadoc)
* @see com.datadoghq.trace.DDSpanSerializer#serialize(io.opentracing.Span) * @see com.datadoghq.trace.DDSpanSerializer#serialize(io.opentracing.Span)

View File

@ -22,18 +22,18 @@ public class DDAgentWriter implements Writer {
/** /**
* Default location of the DD agent * Default location of the DD agent
*/ */
protected static final String DEFAULT_HOSTNAME = "localhost"; private static final String DEFAULT_HOSTNAME = "localhost";
protected static final int DEFAULT_PORT = 8126; private static final int DEFAULT_PORT = 8126;
/** /**
* Maximum number of spans kept in memory * Maximum number of spans kept in memory
*/ */
protected static final int DEFAULT_MAX_SPANS = 1000; private static final int DEFAULT_MAX_SPANS = 1000;
/** /**
* Maximum number of traces sent to the DD agent API at once * Maximum number of traces sent to the DD agent API at once
*/ */
protected static final int DEFAULT_BATCH_SIZE = 10; private static final int DEFAULT_BATCH_SIZE = 10;
/** /**
* Used to ensure that we don't keep too many spans (while the blocking queue collect traces...) * Used to ensure that we don't keep too many spans (while the blocking queue collect traces...)

View File

@ -15,20 +15,20 @@ import java.util.List;
*/ */
public class DDApi { public class DDApi {
protected static final Logger logger = LoggerFactory.getLogger(DDApi.class.getName()); private static final Logger logger = LoggerFactory.getLogger(DDApi.class.getName());
protected static final String TRACES_ENDPOINT = "/v0.3/traces"; private static final String TRACES_ENDPOINT = "/v0.3/traces";
protected static final String SERVICES_ENDPOINT = "/v0.3/services"; private static final String SERVICES_ENDPOINT = "/v0.3/services";
protected final String host; private final String host;
protected final int port; private final int port;
protected final String tracesEndpoint; private final String tracesEndpoint;
protected final String servicesEndpoint; private final String servicesEndpoint;
/** /**
* The spans serializer: can be replaced. By default, it serialize in JSON. * The spans serializer: can be replaced. By default, it serialize in JSON.
*/ */
protected final DDSpanSerializer spanSerializer; private final DDSpanSerializer spanSerializer;
public DDApi(String host, int port) { public DDApi(String host, int port) {
this(host, port, new DDSpanSerializer()); this(host, port, new DDSpanSerializer());

View File

@ -11,7 +11,7 @@ import io.opentracing.Span;
public class LoggingWritter implements Writer{ public class LoggingWritter implements Writer{
protected static final Logger logger = LoggerFactory.getLogger(LoggingWritter.class.getName()); private static final Logger logger = LoggerFactory.getLogger(LoggingWritter.class.getName());
@Override @Override
public void write(List<Span> trace) { public void write(List<Span> trace) {