open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove dynamo db.name attribute (#4208)

This commit is contained in:
Trask Stalnaker 2021-09-27 21:58:26 -07:00 committed by GitHub
parent 8c522a176e
commit 6aaf5ef9e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkRequestType.java
View File

@ -7,7 +7,6 @@ package io.opentelemetry.instrumentation.awssdk.v2_2;
import static io.opentelemetry.instrumentation.awssdk.v2_2.FieldMapping.request;
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
import java.util.Collections;
import java.util.List;
import java.util.Map;
@ -16,9 +15,7 @@ enum AwsSdkRequestType {
S3(request("aws.bucket.name", "Bucket")),
SQS(request("aws.queue.url", "QueueUrl"), request("aws.queue.name", "QueueName")),
Kinesis(request("aws.stream.name", "StreamName")),
DynamoDB(
request("aws.table.name", "TableName"),
request(SemanticAttributes.DB_NAME.getKey(), "TableName"));
DynamoDB(request("aws.table.name", "TableName"));
// Wrapping in unmodifiableMap
@SuppressWarnings("ImmutableEnumChecker")

3
instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/groovy/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientTest.groovy
View File

@ -170,7 +170,6 @@ abstract class AbstractAws2ClientTest extends InstrumentationSpecification {
"aws.requestId" "$requestId"
"aws.table.name" "sometable"
"${SemanticAttributes.DB_SYSTEM.key}" "dynamodb"
"${SemanticAttributes.DB_NAME.key}" "sometable"
"${SemanticAttributes.DB_OPERATION.key}" "CreateTable"
"aws.dynamodb.global_secondary_indexes" "[{\"IndexName\":\"globalIndex\",\"KeySchema\":[{\"AttributeName\":\"attribute\"}],\"ProvisionedThroughput\":{\"ReadCapacityUnits\":10,\"WriteCapacityUnits\":12}},{\"IndexName\":\"globalIndexSecondary\",\"KeySchema\":[{\"AttributeName\":\"attributeSecondary\"}],\"ProvisionedThroughput\":{\"ReadCapacityUnits\":7,\"WriteCapacityUnits\":8}}]"
"aws.dynamodb.provisioned_throughput.read_capacity_units" "1"
@ -206,7 +205,6 @@ abstract class AbstractAws2ClientTest extends InstrumentationSpecification {
"aws.requestId" "$requestId"
"aws.table.name" "sometable"
"${SemanticAttributes.DB_SYSTEM.key}" "dynamodb"
"${SemanticAttributes.DB_NAME.key}" "sometable"
"${SemanticAttributes.DB_OPERATION.key}" "Query"
"aws.dynamodb.limit" "10"
"aws.dynamodb.select" "ALL_ATTRIBUTES"
@ -241,7 +239,6 @@ abstract class AbstractAws2ClientTest extends InstrumentationSpecification {
"aws.requestId" "$requestId"
"aws.table.name" "sometable"
"${SemanticAttributes.DB_SYSTEM.key}" "dynamodb"
"${SemanticAttributes.DB_NAME.key}" "sometable"
"${SemanticAttributes.DB_OPERATION.key}" "${operation}"
}
}