open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Keep operation name the same

This commit is contained in:
Tyler Benson 2018-10-01 14:28:14 -04:00
parent 8b822ff26d
commit 6fdcfc783a
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dd-java-agent/instrumentation/apache-httpclient-4/src/latestDepTest/groovy/ApacheHttpClientTest.groovy
View File

@ -197,7 +197,7 @@ class ApacheHttpClientTest extends AgentTestRunner {
trace.span(index) { trace.span(index) {
childOf parent childOf parent
serviceName "unnamed-java-app" serviceName "unnamed-java-app"
operationName "apache.http.request" operationName "http.request"
resourceName "GET /$route" resourceName "GET /$route"
errored exception != null errored exception != null
tags { tags {

2
dd-java-agent/instrumentation/apache-httpclient-4/src/main/java/datadog/trace/instrumentation/apachehttpclient/ApacheHttpClientInstrumentation.java
View File

@ -91,7 +91,7 @@ public class ApacheHttpClientInstrumentation extends Instrumenter.Default {
final Tracer tracer = GlobalTracer.get(); final Tracer tracer = GlobalTracer.get();
final Scope scope = final Scope scope =
tracer tracer
.buildSpan("apache.http.request") .buildSpan("http.request")
.withTag(Tags.COMPONENT.getKey(), "apache-httpclient") .withTag(Tags.COMPONENT.getKey(), "apache-httpclient")
.withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT) .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT)
.withTag(DDTags.SPAN_TYPE, DDSpanTypes.HTTP_CLIENT) .withTag(DDTags.SPAN_TYPE, DDSpanTypes.HTTP_CLIENT)

2
dd-java-agent/instrumentation/apache-httpclient-4/src/test/groovy/ApacheHttpClientTest.groovy
View File

@ -117,7 +117,7 @@ class ApacheHttpClientTest extends AgentTestRunner {
trace.span(index) { trace.span(index) {
childOf parent childOf parent
serviceName "unnamed-java-app" serviceName "unnamed-java-app"
operationName "apache.http.request" operationName "http.request"
resourceName "GET /$route" resourceName "GET /$route"
errored exception != null errored exception != null
tags { tags {

2
dd-java-agent/instrumentation/aws-java-sdk-1.11.0/src/test/groovy/AWSClientTest.groovy
View File

@ -77,7 +77,7 @@ class AWSClientTest extends AgentTestRunner {
assertTraces(TEST_WRITER, 2) { assertTraces(TEST_WRITER, 2) {
trace(0, 1) { trace(0, 1) {
span(0) { span(0) {
operationName "apache.http.request" operationName "http.request"
resourceName "$method /$url" resourceName "$method /$url"
errored false errored false
parent() // FIXME: This should be a child of the aws.http call. parent() // FIXME: This should be a child of the aws.http call.

2
dd-java-agent/instrumentation/aws-java-sdk-1.11.106/src/test/groovy/AWSClientTest.groovy
View File

@ -106,7 +106,7 @@ class AWSClientTest extends AgentTestRunner {
assertTraces(TEST_WRITER, 2) { assertTraces(TEST_WRITER, 2) {
trace(0, 1) { trace(0, 1) {
span(0) { span(0) {
operationName "apache.http.request" operationName "http.request"
resourceName "$method /$url" resourceName "$method /$url"
errored false errored false
parent() // FIXME: This should be a child of the aws.http call. parent() // FIXME: This should be a child of the aws.http call.