From 70cd8464e2090ceb20d8b18c1399e0480b977457 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 3 Apr 2023 00:24:14 -0700 Subject: [PATCH] Fix possible NPE (#8199) this is a follow-up to #7043 I tried to add a test when that PR was opened: * https://github.com/trask/opentelemetry-java-instrumentation/commit/d2c6399a6ed4cc45e1c9a9a77c9e142d0f5c6575 but it doesn't really verify anything, since the NPE is throw/caught and same behavior occurs --- .../instrumentation/jdbc/internal/JdbcConnectionUrlParser.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java b/instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java index dc97ff47ce..de0aaf9b4a 100644 --- a/instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java +++ b/instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java @@ -53,6 +53,9 @@ public enum JdbcConnectionUrlParser { } String path = uri.getPath(); + if (path == null) { + path = ""; + } if (path.startsWith("/")) { path = path.substring(1); }