open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Properly close() the FileReader for Config (#210) 

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This commit is contained in:
Trask Stalnaker 2020-03-05 16:03:43 -08:00 committed by GitHub
parent 2f1b802aad
commit 7370202340
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
agent-bootstrap/src/main/java/io/opentelemetry/auto/config/Config.java
View File

@ -622,14 +622,23 @@ public class Config {
return properties; return properties;
} }
FileReader fileReader = null;
try { try {
final FileReader fileReader = new FileReader(configurationFile); fileReader = new FileReader(configurationFile);
properties.load(fileReader); properties.load(fileReader);
} catch (final FileNotFoundException fnf) { } catch (final FileNotFoundException fnf) {
log.error("Configuration file '{}' not found.", configurationFilePath); log.error("Configuration file '{}' not found.", configurationFilePath);
} catch (final IOException ioe) { } catch (final IOException ioe) {
log.error( log.error(
"Configuration file '{}' cannot be accessed or correctly parsed.", configurationFilePath); "Configuration file '{}' cannot be accessed or correctly parsed.", configurationFilePath);
} finally {
if (fileReader != null) {
try {
fileReader.close();
} catch (IOException ioe) {
log.error("Configuration file '{}' was not closed correctly.", configurationFilePath);
}
}
} }
return properties; return properties;