open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make ES tests more deterministic by using listener pool with 1 thread 

This should reduce number of false negatives in ES tests
This commit is contained in:
Nikolay Martynov 2018-06-22 12:39:01 -04:00
parent 8445409944
commit 7882e4fe23
7 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dd-java-agent/instrumentation/elasticsearch-transport-2/src/test/groovy/Elasticsearch2NodeClientTest.groovy
View File

@ -34,6 +34,8 @@ class Elasticsearch2NodeClientTest extends AgentTestRunner {
def settings = Settings.builder() def settings = Settings.builder()
.put("path.home", esWorkingDir.path) .put("path.home", esWorkingDir.path)
// Since we use listeners to close spans this should make our span closing deterministic which is good for tests
.put("thread_pool.listener.size", 1)
.put("http.port", HTTP_PORT) .put("http.port", HTTP_PORT)
.put("transport.tcp.port", TCP_PORT) .put("transport.tcp.port", TCP_PORT)
.build() .build()

2
dd-java-agent/instrumentation/elasticsearch-transport-2/src/test/groovy/Elasticsearch2SpringTemplateTest.groovy
View File

@ -45,6 +45,8 @@ class Elasticsearch2SpringTemplateTest extends AgentTestRunner {
def settings = Settings.builder() def settings = Settings.builder()
.put("path.home", esWorkingDir.path) .put("path.home", esWorkingDir.path)
// Since we use listeners to close spans this should make our span closing deterministic which is good for tests
.put("thread_pool.listener.size", 1)
.put("http.port", HTTP_PORT) .put("http.port", HTTP_PORT)
.put("transport.tcp.port", TCP_PORT) .put("transport.tcp.port", TCP_PORT)
.build() .build()

2
dd-java-agent/instrumentation/elasticsearch-transport-2/src/test/groovy/Elasticsearch2TransportClientTest.groovy
View File

@ -46,6 +46,8 @@ class Elasticsearch2TransportClientTest extends AgentTestRunner {
client = TransportClient.builder().settings( client = TransportClient.builder().settings(
Settings.builder() Settings.builder()
// Since we use listeners to close spans this should make our span closing deterministic which is good for tests
.put("thread_pool.listener.size", 1)
.put("cluster.name", "test-cluster") .put("cluster.name", "test-cluster")
.build() .build()
).build() ).build()

2
dd-java-agent/instrumentation/elasticsearch-transport-5/src/test/groovy/Elasticsearch5NodeClientTest.groovy
View File

@ -37,6 +37,8 @@ class Elasticsearch5NodeClientTest extends AgentTestRunner {
def settings = Settings.builder() def settings = Settings.builder()
.put("path.home", esWorkingDir.path) .put("path.home", esWorkingDir.path)
// Since we use listeners to close spans this should make our span closing deterministic which is good for tests
.put("thread_pool.listener.size", 1)
.put("http.port", HTTP_PORT) .put("http.port", HTTP_PORT)
.put("transport.tcp.port", TCP_PORT) .put("transport.tcp.port", TCP_PORT)
.put("transport.type", "netty3") .put("transport.type", "netty3")

2
dd-java-agent/instrumentation/elasticsearch-transport-5/src/test/groovy/Elasticsearch5TransportClientTest.groovy
View File

@ -53,6 +53,8 @@ class Elasticsearch5TransportClientTest extends AgentTestRunner {
client = new PreBuiltTransportClient( client = new PreBuiltTransportClient(
Settings.builder() Settings.builder()
// Since we use listeners to close spans this should make our span closing deterministic which is good for tests
.put("thread_pool.listener.size", 1)
.put(CLUSTER_NAME_SETTING.getKey(), "test-cluster") .put(CLUSTER_NAME_SETTING.getKey(), "test-cluster")
.build() .build()
) )

2
dd-java-agent/instrumentation/elasticsearch-transport-6/src/test/groovy/Elasticsearch6NodeClientTest.groovy
View File

@ -36,6 +36,8 @@ class Elasticsearch6NodeClientTest extends AgentTestRunner {
def settings = Settings.builder() def settings = Settings.builder()
.put("path.home", esWorkingDir.path) .put("path.home", esWorkingDir.path)
// Since we use listeners to close spans this should make our span closing deterministic which is good for tests
.put("thread_pool.listener.size", 1)
.put("http.port", HTTP_PORT) .put("http.port", HTTP_PORT)
.put("transport.tcp.port", TCP_PORT) .put("transport.tcp.port", TCP_PORT)
.put(CLUSTER_NAME_SETTING.getKey(), "test-cluster") .put(CLUSTER_NAME_SETTING.getKey(), "test-cluster")

2
dd-java-agent/instrumentation/elasticsearch-transport-6/src/test/groovy/Elasticsearch6TransportClientTest.groovy
View File

@ -50,6 +50,8 @@ class Elasticsearch6TransportClientTest extends AgentTestRunner {
client = new PreBuiltTransportClient( client = new PreBuiltTransportClient(
Settings.builder() Settings.builder()
// Since we use listeners to close spans this should make our span closing deterministic which is good for tests
.put("thread_pool.listener.size", 1)
.put(CLUSTER_NAME_SETTING.getKey(), "test-cluster") .put(CLUSTER_NAME_SETTING.getKey(), "test-cluster")
.build() .build()
) )