open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable concurrency test for apache http client 2.0 (#4021)

This commit is contained in:
Lauri Tulmin 2021-08-30 19:05:44 +03:00 committed by GitHub
parent c918cdeb76
commit 7fdbd0c55f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
instrumentation/apache-httpclient/apache-httpclient-2.0/javaagent/src/test/groovy/CommonsHttpClientTest.groovy
View File

@ -9,6 +9,7 @@ import io.opentelemetry.instrumentation.test.base.HttpClientTest
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes import io.opentelemetry.semconv.trace.attributes.SemanticAttributes
import org.apache.commons.httpclient.HttpClient import org.apache.commons.httpclient.HttpClient
import org.apache.commons.httpclient.HttpMethod import org.apache.commons.httpclient.HttpMethod
import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager
import org.apache.commons.httpclient.methods.DeleteMethod import org.apache.commons.httpclient.methods.DeleteMethod
import org.apache.commons.httpclient.methods.GetMethod import org.apache.commons.httpclient.methods.GetMethod
import org.apache.commons.httpclient.methods.HeadMethod import org.apache.commons.httpclient.methods.HeadMethod
@ -20,17 +21,12 @@ import spock.lang.Shared
class CommonsHttpClientTest extends HttpClientTest<HttpMethod> implements AgentTestTrait { class CommonsHttpClientTest extends HttpClientTest<HttpMethod> implements AgentTestTrait {
@Shared @Shared
HttpClient client = new HttpClient() HttpClient client = new HttpClient(new MultiThreadedHttpConnectionManager())
def setupSpec() { def setupSpec() {
client.setConnectionTimeout(CONNECT_TIMEOUT_MS) client.setConnectionTimeout(CONNECT_TIMEOUT_MS)
} }
@Override
boolean testCausality() {
return false
}
@Override @Override
HttpMethod buildRequest(String method, URI uri, Map<String, String> headers) { HttpMethod buildRequest(String method, URI uri, Map<String, String> headers) {
def request def request
@ -74,8 +70,7 @@ class CommonsHttpClientTest extends HttpClientTest<HttpMethod> implements AgentT
} }
@Override @Override
boolean testRedirects() { boolean testCircularRedirects() {
// Generates 4 spans
false false
} }