Review changes

This commit is contained in:
Tyler Benson 2019-05-31 09:07:22 -07:00
parent 9cdf049ca7
commit 8016e22bc4
4 changed files with 14 additions and 23 deletions

View File

@ -55,19 +55,20 @@ class HttpServerDecoratorTest extends ServerDecoratorTest {
0 * _
where:
tagQueryString | url | expectedUrl | expectedQuery | expectedFragment
false | null | null | null | null
false | "" | "/" | "" | null
false | "/path?query" | "/path" | "" | null
false | "https://host:0" | "https://host/" | "" | null
false | "https://host/path" | "https://host/path" | "" | null
false | "http://host:99/path?query#fragment" | "http://host:99/path" | "" | null
true | null | null | null | null
true | "" | "/" | null | null
true | "/path?encoded+%28query%29%3F" | "/path" | "encoded+(query)?" | null
true | "https://host:0" | "https://host/" | null | null
true | "https://host/path" | "https://host/path" | null | null
true | "http://host:99/path?query#encoded+%28fragment%29%3F" | "http://host:99/path" | "query" | "encoded+(fragment)?"
tagQueryString | url | expectedUrl | expectedQuery | expectedFragment
false | null | null | null | null
false | "" | "/" | "" | null
false | "/path?query" | "/path" | "" | null
false | "https://host:0" | "https://host/" | "" | null
false | "https://host/path" | "https://host/path" | "" | null
false | "http://host:99/path?query#fragment" | "http://host:99/path" | "" | null
true | null | null | null | null
true | "" | "/" | null | null
true | "/path?encoded+%28query%29%3F?" | "/path" | "encoded+(query)??" | null
true | "https://host:0" | "https://host/" | null | null
true | "https://host/path" | "https://host/path" | null | null
true | "http://host:99/path?query#enc+%28fragment%29%3F" | "http://host:99/path" | "query" | "enc+(fragment)?"
true | "http://host:99/path?query#enc+%28fragment%29%3F?tail" | "http://host:99/path" | "query" | "enc+(fragment)??tail"
req = [url: url == null ? null : new URI(url)]
}

View File

@ -17,10 +17,6 @@ class AkkaHttpClientInstrumentationTest extends HttpClientTest<AkkaHttpClientDec
@Shared
ActorMaterializer materializer = ActorMaterializer.create(system)
// String readMessage(HttpResponse response) {
// response.entity().toStrict(TIMEOUT, materializer).toCompletableFuture().get().getData().utf8String()
// }
@Override
int doRequest(String method, URI uri, Map<String, String> headers, Closure callback) {
def request = HttpRequest.create(uri.toString())

View File

@ -22,11 +22,6 @@ class AkkaHttpClientPoolInstrumentationTest extends HttpClientTest<AkkaHttpClien
def pool = Http.get(system).superPool(materializer)
// String readMessage(HttpResponse response) {
// response.entity().toStrict(TIMEOUT, materializer).toCompletableFuture().get().getData().utf8String()
// }
@Override
int doRequest(String method, URI uri, Map<String, String> headers, Closure callback) {
def request = HttpRequest.create(uri.toString())

View File

@ -20,7 +20,6 @@ class TraceUtils {
}
protected String component() {
// return "runUnderTrace"
return null
}
}