From 85b3644787e3beaed5575a2eaac86a7756645adc Mon Sep 17 00:00:00 2001 From: Aaron Ai Date: Thu, 24 Nov 2022 00:21:28 +0800 Subject: [PATCH] Remove redundant code in AbstractRocketMqClientTest (#7285) --- .../rocketmqclient/v5_0/AbstractRocketMqClientTest.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/instrumentation/rocketmq/rocketmq-client/rocketmq-client-5.0/testing/src/main/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java b/instrumentation/rocketmq/rocketmq-client/rocketmq-client-5.0/testing/src/main/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java index d4ed1e572b..6d7521c660 100644 --- a/instrumentation/rocketmq/rocketmq-client/rocketmq-client-5.0/testing/src/main/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java +++ b/instrumentation/rocketmq/rocketmq-client/rocketmq-client-5.0/testing/src/main/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java @@ -72,9 +72,6 @@ public abstract class AbstractRocketMqClientTest { container.start(); ClientConfiguration clientConfiguration = ClientConfiguration.newBuilder().setEndpoints(container.endpoints).build(); - // Inner topic of the container. - ClientServiceProvider provider = ClientServiceProvider.loadService(); - String consumerGroup = "group-normal-topic-0"; FilterExpression filterExpression = new FilterExpression(tag, FilterExpressionType.TAG); consumer = provider @@ -253,7 +250,7 @@ public abstract class AbstractRocketMqClientTest { equalTo( AttributeKey.stringArrayKey( "messaging.header.test_message_header"), - Arrays.asList(new String[] {"test"}))) + Collections.singletonList("test"))) .hasParent(trace.getSpan(0))); sendSpanData.set(trace.getSpan(1)); }, @@ -273,7 +270,7 @@ public abstract class AbstractRocketMqClientTest { equalTo( AttributeKey.stringArrayKey( "messaging.header.test_message_header"), - Arrays.asList(new String[] {"test"}))) + Collections.singletonList("test"))) // As the child of receive span. .hasParent(trace.getSpan(0)), span ->