open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1016 from DataDog/tyler/parse-optimization 

Minor optimization to avoid using BigInteger if possible
This commit is contained in:
Tyler Benson 2019-09-27 15:24:10 -07:00 committed by GitHub
parent 23e058e803 82d60c27f4
commit 91cbb67f6e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dd-trace-ot/src/main/java/datadog/opentracing/DDSpan.java
View File

@ -417,6 +417,7 @@ public class DDSpan implements Span, MutableSpan {
} }
protected static class UInt64IDStringSerializer extends StdSerializer<String> { protected static class UInt64IDStringSerializer extends StdSerializer<String> {
private static final int LONG_PARSE_LIMIT = String.valueOf(Long.MAX_VALUE).length();
public UInt64IDStringSerializer() { public UInt64IDStringSerializer() {
this(null); this(null);
@ -430,7 +431,15 @@ public class DDSpan implements Span, MutableSpan {
public void serialize( public void serialize(
final String value, final JsonGenerator gen, final SerializerProvider provider) final String value, final JsonGenerator gen, final SerializerProvider provider)
throws IOException { throws IOException {
final int length = value.length();
// BigInteger's are expensive, so lets try to avoid using them if possible.
// This is a rough approximation for optimization.
// There are some values that would pass this test that could be parsed with Long.parseLong.
if (length > LONG_PARSE_LIMIT || (length == LONG_PARSE_LIMIT && value.startsWith("9"))) {
gen.writeNumber(new BigInteger(value)); gen.writeNumber(new BigInteger(value));
} else {
gen.writeNumber(Long.parseLong(value));
}
} }
} }
} }

3
dd-trace-ot/src/test/groovy/datadog/opentracing/DDSpanSerializationTest.groovy
View File

@ -1,6 +1,5 @@
package datadog.opentracing package datadog.opentracing
import com.fasterxml.jackson.databind.ObjectMapper import com.fasterxml.jackson.databind.ObjectMapper
import com.google.common.collect.Maps import com.google.common.collect.Maps
import datadog.trace.agent.test.utils.ConfigUtils import datadog.trace.agent.test.utils.ConfigUtils
@ -128,7 +127,9 @@ class DDSpanSerializationTest extends Specification {
value | _ value | _
BigInteger.ZERO | _ BigInteger.ZERO | _
BigInteger.ONE | _ BigInteger.ONE | _
8223372036854775807G | _
BigInteger.valueOf(Long.MAX_VALUE).subtract(BigInteger.ONE) | _ BigInteger.valueOf(Long.MAX_VALUE).subtract(BigInteger.ONE) | _
BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE) | _ BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE) | _
BigInteger.valueOf(2).pow(64).subtract(BigInteger.ONE) | _
} }
} }