From 96eb67de6fa57eb97e0b333e951b8ea613d0b8d0 Mon Sep 17 00:00:00 2001
From: Vadim Shaigorodskiy <5587834+vadeg@users.noreply.github.com>
Date: Fri, 23 Oct 2020 18:54:33 +0200
Subject: [PATCH] Replace `"messaging.operation"` with the constant (#1457)

---
 .../instrumentation/api/typedspan/MessagingConsumerSpan.java | 5 +++--
 .../api/typedspan/MessagingConsumerSynchronousSpan.java      | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSpan.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSpan.java
index 9d6f5bd8c2..e612690278 100644
--- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSpan.java
+++ b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSpan.java
@@ -8,6 +8,7 @@ package io.opentelemetry.instrumentation.api.typedspan;
 import io.grpc.Context;
 import io.opentelemetry.trace.Span;
 import io.opentelemetry.trace.Tracer;
+import io.opentelemetry.trace.attributes.SemanticAttributes;
 
 public class MessagingConsumerSpan extends DelegatingSpan
     implements MessagingConsumerSemanticConvention {
@@ -273,7 +274,7 @@ public class MessagingConsumerSpan extends DelegatingSpan
    */
   @Override
   public MessagingConsumerSemanticConvention setMessagingOperation(String messagingOperation) {
-    delegate.setAttribute("messaging.operation", messagingOperation);
+    delegate.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
     return this;
   }
 
@@ -515,7 +516,7 @@ public class MessagingConsumerSpan extends DelegatingSpan
      *     this span describes.
      */
     public MessagingConsumerSpanBuilder setMessagingOperation(String messagingOperation) {
-      internalBuilder.setAttribute("messaging.operation", messagingOperation);
+      internalBuilder.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
       return this;
     }
   }
diff --git a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSynchronousSpan.java b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSynchronousSpan.java
index f880b3114d..ef41e130d1 100644
--- a/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSynchronousSpan.java
+++ b/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/typedspan/MessagingConsumerSynchronousSpan.java
@@ -8,6 +8,7 @@ package io.opentelemetry.instrumentation.api.typedspan;
 import io.grpc.Context;
 import io.opentelemetry.trace.Span;
 import io.opentelemetry.trace.Tracer;
+import io.opentelemetry.trace.attributes.SemanticAttributes;
 
 public class MessagingConsumerSynchronousSpan extends DelegatingSpan
     implements MessagingConsumerSynchronousSemanticConvention {
@@ -280,7 +281,7 @@ public class MessagingConsumerSynchronousSpan extends DelegatingSpan
   @Override
   public MessagingConsumerSynchronousSemanticConvention setMessagingOperation(
       String messagingOperation) {
-    delegate.setAttribute("messaging.operation", messagingOperation);
+    delegate.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
     return this;
   }
 
@@ -526,7 +527,7 @@ public class MessagingConsumerSynchronousSpan extends DelegatingSpan
      */
     public MessagingConsumerSynchronousSpanBuilder setMessagingOperation(
         String messagingOperation) {
-      internalBuilder.setAttribute("messaging.operation", messagingOperation);
+      internalBuilder.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
       return this;
     }
   }