diff --git a/dd-java-agent/instrumentation/jsp-2.3/jsp-2.3.gradle b/dd-java-agent/instrumentation/jsp-2.3/jsp-2.3.gradle index 41d7a40e2f..21486fbe7c 100644 --- a/dd-java-agent/instrumentation/jsp-2.3/jsp-2.3.gradle +++ b/dd-java-agent/instrumentation/jsp-2.3/jsp-2.3.gradle @@ -1,17 +1,14 @@ -apply plugin: 'version-scan' - -versionScan { - group = "org.apache.tomcat" - module = "tomcat-jasper" - versions = "[7.0.0,)" - scanDependencies = true - verifyPresent = [ - "org.apache.jasper.servlet.JspServletWrapper": null, - ] -} - apply from: "${rootDir}/gradle/java.gradle" +muzzle { + pass { + group = "org.apache.tomcat" + module = "tomcat-jasper" + // range [7.0.0,7.0.19) and version 8.0.9 missing from maven + versions = "[7.0.19,8.0.9),(8.0.9,)" + } +} + apply plugin: 'org.unbroken-dome.test-sets' testSets { diff --git a/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JSPInstrumentation.java b/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JSPInstrumentation.java index 0d6b710298..767aecbcd0 100644 --- a/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JSPInstrumentation.java +++ b/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JSPInstrumentation.java @@ -33,11 +33,6 @@ public final class JSPInstrumentation extends Instrumenter.Default { super("jsp", "jsp-render"); } - @Override - protected boolean defaultEnabled() { - return false; - } - @Override public ElementMatcher typeMatcher() { return not(isInterface()).and(safeHasSuperType(named("javax.servlet.jsp.HttpJspPage"))); diff --git a/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JasperJSPCompilationContextInstrumentation.java b/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JasperJSPCompilationContextInstrumentation.java index fbda4a5e8c..6ac4b1981d 100644 --- a/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JasperJSPCompilationContextInstrumentation.java +++ b/dd-java-agent/instrumentation/jsp-2.3/src/main/java/datadog/trace/instrumentation/jsp/JasperJSPCompilationContextInstrumentation.java @@ -1,6 +1,5 @@ package datadog.trace.instrumentation.jsp; -import static datadog.trace.agent.tooling.ClassLoaderMatcher.classLoaderHasClasses; import static io.opentracing.log.Fields.ERROR_OBJECT; import static net.bytebuddy.matcher.ElementMatchers.isPublic; import static net.bytebuddy.matcher.ElementMatchers.named; @@ -29,21 +28,11 @@ public final class JasperJSPCompilationContextInstrumentation extends Instrument super("jsp", "jsp-compile"); } - @Override - protected boolean defaultEnabled() { - return false; - } - @Override public ElementMatcher typeMatcher() { return named("org.apache.jasper.JspCompilationContext"); } - @Override - public ElementMatcher classLoaderMatcher() { - return classLoaderHasClasses("org.apache.jasper.servlet.JspServletWrapper"); - } - @Override public Map transformers() { final Map transformers = new HashMap<>(); diff --git a/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy b/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy index e80656c77b..b9581bf445 100644 --- a/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy +++ b/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy @@ -20,7 +20,6 @@ import static datadog.trace.agent.test.asserts.ListWriterAssert.assertTraces class JSPInstrumentationBasicTests extends AgentTestRunner { static { - System.setProperty("dd.integration.jsp.enabled", "true") // skip jar scanning using environment variables: // http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html#JAR_Scanning // having this set allows us to test with old versions of the tomcat api since diff --git a/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationForwardTests.groovy b/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationForwardTests.groovy index 7c53a611e8..85918b4f13 100644 --- a/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationForwardTests.groovy +++ b/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationForwardTests.groovy @@ -18,7 +18,6 @@ import static datadog.trace.agent.test.asserts.ListWriterAssert.assertTraces class JSPInstrumentationForwardTests extends AgentTestRunner { static { - System.setProperty("dd.integration.jsp.enabled", "true") // skip jar scanning using environment variables: // http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html#JAR_Scanning // having this set allows us to test with old versions of the tomcat api since