open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove MoreAttributes (#1417)

This commit is contained in:
Trask Stalnaker 2020-10-18 22:38:26 -07:00 committed by GitHub
parent 57301e3fe7
commit 9e37231662
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/MoreAttributes.java
View File

@ -1,13 +0,0 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/
package io.opentelemetry.instrumentation.api;
public class MoreAttributes {
public static final String HTTP_QUERY = "http.query.string";
public static final String HTTP_FRAGMENT = "http.fragment.string";
public static final String USER_NAME = "user.principal";
}

4
instrumentation-core/servlet-2.2/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java
View File

@ -7,9 +7,9 @@ package io.opentelemetry.instrumentation.servlet;
import io.grpc.Context;
import io.opentelemetry.context.propagation.TextMapPropagator.Getter;
import io.opentelemetry.instrumentation.api.MoreAttributes;
import io.opentelemetry.instrumentation.api.tracer.HttpServerTracer;
import io.opentelemetry.trace.Span;
import io.opentelemetry.trace.attributes.SemanticAttributes;
import java.net.URI;
import java.net.URISyntaxException;
import java.security.Principal;
@ -94,7 +94,7 @@ public abstract class ServletHttpServerTracer<RESPONSE>
public void setPrincipal(Span span, HttpServletRequest request) {
Principal principal = request.getUserPrincipal();
if (principal != null) {
span.setAttribute(MoreAttributes.USER_NAME, principal.getName());
span.setAttribute(SemanticAttributes.ENDUSER_ID, principal.getName());
}
}