Remove apache httpclient version (#1446)

* Remove version from `apache-httpclient` instrumentation

Fixes: #1260

* Remove version from all instrumentation names and add instrumentation name to `spring-web`

Fixes: #1260
This commit is contained in:
Vadim Shaigorodskiy 2020-10-22 07:22:44 +02:00 committed by GitHub
parent 7d77b2dc37
commit 9e8d663ba4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
62 changed files with 61 additions and 62 deletions

View File

@ -64,6 +64,6 @@ public class AkkaHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.akka-http-10.0";
return "io.opentelemetry.auto.akka-http";
}
}

View File

@ -61,7 +61,7 @@ public class AkkaHttpServerTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.akka-http-10.0";
return "io.opentelemetry.auto.akka-http";
}
@Override

View File

@ -84,7 +84,7 @@ public class ApacheHttpAsyncClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.apache-httpasyncclient-4.0";
return "io.opentelemetry.auto.apache-httpasyncclient";
}
@Override

View File

@ -22,7 +22,7 @@ public class CommonsHttpClientTracer extends HttpClientTracer<HttpMethod, HttpMe
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.apache-httpclient-2.0";
return "io.opentelemetry.auto.apache-httpclient";
}
public Depth getCallDepth() {

View File

@ -64,7 +64,7 @@ class ApacheHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.apache-httpclient-4.0";
return "io.opentelemetry.auto.apache-httpclient";
}
/** This method is overridden to allow other classes in this package to call it. */

View File

@ -66,7 +66,7 @@ public class ArmeriaClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.armeria-1.0";
return "io.opentelemetry.armeria";
}
private static class ArmeriaSetter implements Setter<ClientRequestContext> {

View File

@ -33,7 +33,7 @@ public class ArmeriaServerTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.armeria-1.0";
return "io.opentelemetry.armeria";
}
@Override

View File

@ -86,6 +86,6 @@ public class AwsLambdaMessageTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.aws-lambda-1.0";
return "io.opentelemetry.aws-lambda";
}
}

View File

@ -52,6 +52,6 @@ public class AwsLambdaTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.aws-lambda-1.0";
return "io.opentelemetry.aws-lambda";
}
}

View File

@ -127,7 +127,7 @@ public class AwsSdkClientTracer extends HttpClientTracer<Request<?>, Request<?>,
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.aws-sdk-1.11";
return "io.opentelemetry.auto.aws-sdk";
}
static final class NamesCache extends ClassValue<ConcurrentHashMap<String, String>> {

View File

@ -65,7 +65,7 @@ final class AwsSdkHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.aws-sdk-2.2";
return "io.opentelemetry.auto.aws-sdk";
}
/** This method is overridden to allow other classes in this package to call it. */

View File

@ -20,7 +20,7 @@ public class CassandraDatabaseClientTracer extends DatabaseClientTracer<Session,
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.cassandra-3.0";
return "io.opentelemetry.auto.cassandra";
}
@Override

View File

@ -21,7 +21,7 @@ public class CassandraDatabaseClientTracer extends DatabaseClientTracer<CqlSessi
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.cassandra-4.0";
return "io.opentelemetry.auto.cassandra";
}
@Override

View File

@ -12,6 +12,6 @@ public class FinatraTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.finatra-2.9";
return "io.opentelemetry.auto.finatra";
}
}

View File

@ -57,6 +57,6 @@ public class GeodeTracer extends DatabaseClientTracer<Region<?, ?>, String> {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.geode-1.7";
return "io.opentelemetry.auto.geode";
}
}

View File

@ -19,7 +19,7 @@ public class GoogleHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.google-http-client-1.19";
return "io.opentelemetry.auto.google-http-client";
}
@Override

View File

@ -86,7 +86,7 @@ public class GrizzlyHttpServerTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.grizzly-2.0";
return "io.opentelemetry.auto.grizzly";
}
@Override

View File

@ -48,6 +48,6 @@ public class GrizzlyClientTracer extends HttpClientTracer<Request, Request, Resp
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.grizzly-client-1.9";
return "io.opentelemetry.auto.grizzly-client";
}
}

View File

@ -43,6 +43,6 @@ public class GrpcClientTracer extends RpcClientTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.grpc-1.5";
return "io.opentelemetry.auto.grpc";
}
}

View File

@ -48,7 +48,7 @@ public class GrpcServerTracer extends RpcServerTracer<Metadata> {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.grpc-1.5";
return "io.opentelemetry.auto.grpc";
}
@Override

View File

@ -50,6 +50,6 @@ public class JaxRsClientV1Tracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jaxrs-client-1.1";
return "io.opentelemetry.auto.jaxrs-client";
}
}

View File

@ -49,6 +49,6 @@ public class JaxRsClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jaxrs-client-2.0";
return "io.opentelemetry.auto.jaxrs-client";
}
}

View File

@ -181,6 +181,6 @@ public class JaxRsAnnotationsTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jaxrs-1.0";
return "io.opentelemetry.auto.jaxrs";
}
}

View File

@ -187,6 +187,6 @@ public class JaxRsAnnotationsTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jaxrs-2.0";
return "io.opentelemetry.auto.jaxrs";
}
}

View File

@ -36,6 +36,6 @@ public class JedisClientTracer extends DatabaseClientTracer<Connection, Command>
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jedis-1.4";
return "io.opentelemetry.auto.jedis";
}
}

View File

@ -44,6 +44,6 @@ public class JedisClientTracer extends DatabaseClientTracer<Connection, Protocol
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jedis-3.0";
return "io.opentelemetry.auto.jedis";
}
}

View File

@ -12,6 +12,6 @@ public class JettyHttpServerTracer extends Servlet3HttpServerTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jetty-8.0";
return "io.opentelemetry.auto.jetty";
}
}

View File

@ -163,6 +163,6 @@ public class JMSTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jms-1.1";
return "io.opentelemetry.auto.jms";
}
}

View File

@ -72,6 +72,6 @@ public class JSPTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.jsp-2.3";
return "io.opentelemetry.auto.jsp";
}
}

View File

@ -74,6 +74,6 @@ public class KafkaConsumerTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.kafka-clients-0.11";
return "io.opentelemetry.auto.kafka-clients";
}
}

View File

@ -48,6 +48,6 @@ public class KafkaStreamsTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.kafka-streams-0.11";
return "io.opentelemetry.auto.kafka-streams";
}
}

View File

@ -56,6 +56,6 @@ public class KHttpTracer extends HttpClientTracer<RequestWrapper, Map<String, St
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.khttp-0.1";
return "io.opentelemetry.auto.khttp";
}
}

View File

@ -50,7 +50,7 @@ public class KubernetesClientTracer extends HttpClientTracer<Request, Request, R
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.kubernetes-client-7.0";
return "io.opentelemetry.auto.kubernetes-client";
}
/** This method is overridden to allow other classes in this package to call it. */

View File

@ -35,6 +35,6 @@ public abstract class LettuceAbstractDatabaseClientTracer<QUERY>
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.lettuce-4.0";
return "io.opentelemetry.auto.lettuce";
}
}

View File

@ -16,7 +16,7 @@ public abstract class LettuceAbstractDatabaseClientTracer<QUERY>
extends DatabaseClientTracer<RedisURI, QUERY> {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.lettuce-5.0";
return "io.opentelemetry.auto.lettuce";
}
@Override

View File

@ -24,7 +24,6 @@ import org.bson.BsonValue;
public class MongoClientTracer extends DatabaseClientTracer<CommandStartedEvent, BsonDocument> {
public static final MongoClientTracer TRACER = new MongoClientTracer();
// TODO use tracer names *.mongo-3.1, *.mongo-3.7, *.mongo-async-3.3 respectively in each module
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.mongo";

View File

@ -82,6 +82,6 @@ public class NettyHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.netty-3.8";
return "io.opentelemetry.auto.netty";
}
}

View File

@ -77,7 +77,7 @@ public class NettyHttpServerTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.netty-3.8";
return "io.opentelemetry.auto.netty";
}
@Override

View File

@ -82,6 +82,6 @@ public class NettyHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.netty-4.0";
return "io.opentelemetry.auto.netty";
}
}

View File

@ -48,7 +48,7 @@ public class NettyHttpServerTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.netty-4.0";
return "io.opentelemetry.auto.netty";
}
@Override

View File

@ -63,6 +63,6 @@ public class NettyHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.netty-4.1";
return "io.opentelemetry.auto.netty";
}
}

View File

@ -48,7 +48,7 @@ public class NettyHttpServerTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.netty-4.1";
return "io.opentelemetry.auto.netty";
}
@Override

View File

@ -49,6 +49,6 @@ public class OkHttpClientTracer extends HttpClientTracer<Request, Request.Builde
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.okhttp-2.2";
return "io.opentelemetry.auto.okhttp";
}
}

View File

@ -48,6 +48,6 @@ public class OkHttpClientTracer extends HttpClientTracer<Request, Request.Builde
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.okhttp-3.0";
return "io.opentelemetry.auto.okhttp";
}
}

View File

@ -50,6 +50,6 @@ public class PlayWSClientTracer extends HttpClientTracer<Request, HttpHeaders, R
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.play-ws-2.1";
return "io.opentelemetry.auto.play-ws";
}
}

View File

@ -26,7 +26,7 @@ public class PlayTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.play-2.3";
return "io.opentelemetry.auto.play";
}
@Override

View File

@ -27,7 +27,7 @@ public class PlayTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.play-2.4";
return "io.opentelemetry.auto.play";
}
@Override

View File

@ -63,7 +63,7 @@ public class PlayTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.play-2.6";
return "io.opentelemetry.auto.play";
}
@Override

View File

@ -159,6 +159,6 @@ public class RabbitTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.rabbitmq-amqp-2.7";
return "io.opentelemetry.auto.rabbitmq-amqp";
}
}

View File

@ -27,7 +27,7 @@ public class RatpackTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.ratpack-1.4";
return "io.opentelemetry.auto.ratpack";
}
@Override

View File

@ -32,6 +32,6 @@ public class RediscalaClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.rediscala-1.8";
return "io.opentelemetry.auto.rediscala";
}
}

View File

@ -20,7 +20,7 @@ public class RedissonClientTracer extends DatabaseClientTracer<RedisConnection,
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.redisson-3.0";
return "io.opentelemetry.auto.redisson";
}
@Override

View File

@ -11,7 +11,7 @@ public class Servlet2HttpServerTracer extends ServletHttpServerTracer<ResponseWi
public static final Servlet2HttpServerTracer TRACER = new Servlet2HttpServerTracer();
protected String getInstrumentationName() {
return "io.opentelemetry.auto.servlet-2.2";
return "io.opentelemetry.auto.servlet";
}
@Override

View File

@ -20,7 +20,7 @@ public class Servlet3HttpServerTracer extends ServletHttpServerTracer<HttpServle
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.servlet-3.0";
return "io.opentelemetry.auto.servlet";
}
@Override

View File

@ -14,6 +14,6 @@ public final class SpringDataTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.spring-data-1.8";
return "io.opentelemetry.auto.spring-data";
}
}

View File

@ -13,7 +13,7 @@ public class SpringSchedulingTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.spring-scheduling-3.1";
return "io.opentelemetry.auto.spring-scheduling";
}
public String spanNameOnRun(Runnable runnable) {

View File

@ -56,6 +56,6 @@ class RestTemplateTracer extends HttpClientTracer<HttpRequest, HttpHeaders, Clie
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.spring-web-3.1";
return "io.opentelemetry.auto.spring-web";
}
}

View File

@ -12,6 +12,6 @@ public class SpringWebfluxHttpServerTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.spring-webflux-5.0";
return "io.opentelemetry.auto.spring-webflux";
}
}

View File

@ -73,7 +73,7 @@ public class SpringWebfluxHttpClientTracer
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.spring-webflux-5.0";
return "io.opentelemetry.auto.spring-webflux";
}
public Tracer getTracer() {

View File

@ -94,6 +94,6 @@ public class SpringWebMvcTracer extends BaseTracer {
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.spring-webmvc-3.1";
return "io.opentelemetry.auto.spring-webmvc";
}
}

View File

@ -74,6 +74,6 @@ class SpringWebMvcServerTracer
@Override
protected String getInstrumentationName() {
return null;
return "io.opentelemetry.auto.spring-web";
}
}

View File

@ -46,6 +46,6 @@ public class MemcacheClientTracer extends DatabaseClientTracer<MemcachedConnecti
@Override
protected String getInstrumentationName() {
return "io.opentelemetry.auto.spymemcached-2.12";
return "io.opentelemetry.auto.spymemcached";
}
}