Generify the tracer span build methods

This commit is contained in:
Marius Constantin 2020-02-13 10:21:08 +01:00
parent 23d3b75555
commit 9ef59098ff
1 changed files with 6 additions and 6 deletions

View File

@ -411,7 +411,7 @@ public class DDTracer implements io.opentracing.Tracer, Closeable, datadog.trace
} }
@Override @Override
public DDSpanBuilder buildSpan(final String operationName) { public SpanBuilder buildSpan(final String operationName) {
return new DDSpanBuilder(operationName, scopeManager); return new DDSpanBuilder(operationName, scopeManager);
} }
@ -592,13 +592,13 @@ public class DDTracer implements io.opentracing.Tracer, Closeable, datadog.trace
return this; return this;
} }
private DDSpan startSpan() { private Span startSpan() {
return new DDSpan(timestampMicro, buildSpanContext()); return new DDSpan(timestampMicro, buildSpanContext());
} }
@Override @Override
public Scope startActive(final boolean finishSpanOnClose) { public Scope startActive(final boolean finishSpanOnClose) {
final DDSpan span = startSpan(); final Span span = startSpan();
final Scope scope = scopeManager.activate(span, finishSpanOnClose); final Scope scope = scopeManager.activate(span, finishSpanOnClose);
log.debug("Starting a new active span: {}", span); log.debug("Starting a new active span: {}", span);
return scope; return scope;
@ -606,13 +606,13 @@ public class DDTracer implements io.opentracing.Tracer, Closeable, datadog.trace
@Override @Override
@Deprecated @Deprecated
public DDSpan startManual() { public Span startManual() {
return start(); return start();
} }
@Override @Override
public DDSpan start() { public Span start() {
final DDSpan span = startSpan(); final Span span = startSpan();
log.debug("Starting a new span: {}", span); log.debug("Starting a new span: {}", span);
return span; return span;
} }