open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OkHttp instumentation: simplify error case

This commit is contained in:
Nikolay Martynov 2018-06-25 16:49:23 -04:00
parent 1aaa3cafeb
commit a882a5439c
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
dd-java-agent/instrumentation/okhttp-3/src/main/java/datadog/trace/instrumentation/okhttp3/OkHttpClientSpanDecorator.java
View File

@ -4,12 +4,15 @@ import io.opentracing.Span;
import io.opentracing.tag.Tags; import io.opentracing.tag.Tags;
import java.net.Inet4Address; import java.net.Inet4Address;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import okhttp3.Connection; import okhttp3.Connection;
import okhttp3.Request; import okhttp3.Request;
import okhttp3.Response; import okhttp3.Response;
import static io.opentracing.log.Fields.ERROR_OBJECT;
/** /**
* Span decorator to add tags, logs and operation name. * Span decorator to add tags, logs and operation name.
* *
@ -64,7 +67,7 @@ public interface OkHttpClientSpanDecorator {
@Override @Override
public void onError(final Throwable throwable, final Span span) { public void onError(final Throwable throwable, final Span span) {
Tags.ERROR.set(span, Boolean.TRUE); Tags.ERROR.set(span, Boolean.TRUE);
span.log(errorLogs(throwable)); span.log(Collections.singletonMap(ERROR_OBJECT, throwable));
} }
@Override @Override
@ -81,13 +84,5 @@ public interface OkHttpClientSpanDecorator {
Tags.PEER_HOST_IPV6.set(span, connection.socket().getInetAddress().toString()); Tags.PEER_HOST_IPV6.set(span, connection.socket().getInetAddress().toString());
} }
} }
protected Map<String, Object> errorLogs(final Throwable throwable) {
final Map<String, Object> errorLogs = new HashMap<>(2);
errorLogs.put("event", Tags.ERROR.getKey());
errorLogs.put("error.object", throwable);
return errorLogs;
}
}; };
} }