open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GraphQL: verify that span has error status when operation failed (#6011)

This commit is contained in:
Lauri Tulmin 2022-05-12 08:58:50 +03:00 committed by GitHub
parent d6cf07496d
commit aac502cea4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
instrumentation/graphql-java-12.0/testing/src/main/java/io/opentelemetry/instrumentation/graphql/AbstractGraphqlTest.java
View File

@ -23,6 +23,7 @@ import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.trace.SpanKind; import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension; import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.sdk.testing.assertj.AttributeAssertion; import io.opentelemetry.sdk.testing.assertj.AttributeAssertion;
import io.opentelemetry.sdk.trace.data.StatusData;
import java.io.IOException; import java.io.IOException;
import java.io.InputStreamReader; import java.io.InputStreamReader;
import java.io.Reader; import java.io.Reader;
@ -198,6 +199,7 @@ public abstract class AbstractGraphqlTest {
.hasKind(SpanKind.INTERNAL) .hasKind(SpanKind.INTERNAL)
.hasNoParent() .hasNoParent()
.hasAttributesSatisfying(Attributes::isEmpty) .hasAttributesSatisfying(Attributes::isEmpty)
.hasStatus(StatusData.error())
.hasEventsSatisfyingExactly( .hasEventsSatisfyingExactly(
event -> event ->
event event
@ -243,6 +245,7 @@ public abstract class AbstractGraphqlTest {
.hasKind(SpanKind.INTERNAL) .hasKind(SpanKind.INTERNAL)
.hasNoParent() .hasNoParent()
.hasAttributesSatisfying(Attributes::isEmpty) .hasAttributesSatisfying(Attributes::isEmpty)
.hasStatus(StatusData.error())
.hasEventsSatisfyingExactly( .hasEventsSatisfyingExactly(
event -> event ->
event event