diff --git a/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/instrumentation/api/Tags.java b/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/instrumentation/api/Tags.java index 1b0cc5b4fb..0466b801e6 100644 --- a/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/instrumentation/api/Tags.java +++ b/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/instrumentation/api/Tags.java @@ -18,7 +18,6 @@ public class Tags { public static final String PEER_PORT = "peer.port"; public static final String SPAN_KIND = "span.kind"; public static final String COMPONENT = "component"; - public static final String ERROR = "error"; public static final String DB_TYPE = "db.type"; public static final String DB_INSTANCE = "db.instance"; public static final String DB_USER = "db.user"; diff --git a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/OpenTracing32.java b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/OpenTracing32.java index 51fc67c3a0..a049fa75f0 100644 --- a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/OpenTracing32.java +++ b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/OpenTracing32.java @@ -165,7 +165,11 @@ public final class OpenTracing32 implements TracerAPI { @Override public AgentSpan setError(final boolean error) { - Tags.ERROR.set(span, error); + if (span instanceof DDSpan) { + ((DDSpan) span).setError(error); + } else { + Tags.ERROR.set(span, error); + } return this; } diff --git a/dd-java-agent/agent-tooling/src/test/groovy/datadog/trace/agent/decorator/HttpClientDecoratorTest.groovy b/dd-java-agent/agent-tooling/src/test/groovy/datadog/trace/agent/decorator/HttpClientDecoratorTest.groovy index 5af9286d9f..dc2ca4eb3c 100644 --- a/dd-java-agent/agent-tooling/src/test/groovy/datadog/trace/agent/decorator/HttpClientDecoratorTest.groovy +++ b/dd-java-agent/agent-tooling/src/test/groovy/datadog/trace/agent/decorator/HttpClientDecoratorTest.groovy @@ -107,8 +107,8 @@ class HttpClientDecoratorTest extends ClientDecoratorTest { 399 | false | null | [status: 399] 400 | true | null | [status: 400] 499 | true | null | [status: 499] - 500 | false | null | [status: 500] - 500 | true | "500" | [status: 500] + 500 | true | null | [status: 500] + 500 | false | "400-499" | [status: 500] 500 | true | "400-500" | [status: 500] 600 | false | null | [status: 600] null | false | null | [status: null] diff --git a/dd-java-agent/instrumentation/akka-http-10.0/src/lagomTest/groovy/LagomTest.groovy b/dd-java-agent/instrumentation/akka-http-10.0/src/lagomTest/groovy/LagomTest.groovy index 2f046298f7..adb228cb06 100644 --- a/dd-java-agent/instrumentation/akka-http-10.0/src/lagomTest/groovy/LagomTest.groovy +++ b/dd-java-agent/instrumentation/akka-http-10.0/src/lagomTest/groovy/LagomTest.groovy @@ -110,7 +110,6 @@ class LagomTest extends AgentTestRunner { "$Tags.HTTP_URL" "ws://localhost:${server.port()}/error" "$Tags.HTTP_METHOD" "GET" "$Tags.HTTP_STATUS" 500 - "$Tags.ERROR" true defaultTags() } } diff --git a/dd-java-agent/instrumentation/akka-http-10.0/src/main/java/datadog/trace/instrumentation/akkahttp/AkkaHttpServerInstrumentation.java b/dd-java-agent/instrumentation/akka-http-10.0/src/main/java/datadog/trace/instrumentation/akkahttp/AkkaHttpServerInstrumentation.java index 900459e499..9ac8d16866 100644 --- a/dd-java-agent/instrumentation/akka-http-10.0/src/main/java/datadog/trace/instrumentation/akkahttp/AkkaHttpServerInstrumentation.java +++ b/dd-java-agent/instrumentation/akka-http-10.0/src/main/java/datadog/trace/instrumentation/akkahttp/AkkaHttpServerInstrumentation.java @@ -123,6 +123,7 @@ public final class AkkaHttpServerInstrumentation extends Instrumenter.Default { public static void finishSpan(final AgentSpan span, final Throwable t) { DECORATE.onError(span, t); span.setTag(Tags.HTTP_STATUS, 500); + span.setError(true); DECORATE.beforeFinish(span); final TraceScope scope = activeScope(); diff --git a/dd-java-agent/instrumentation/akka-http-10.0/src/test/groovy/AkkaHttpClientInstrumentationTest.groovy b/dd-java-agent/instrumentation/akka-http-10.0/src/test/groovy/AkkaHttpClientInstrumentationTest.groovy index 28aabb4555..c56e099356 100644 --- a/dd-java-agent/instrumentation/akka-http-10.0/src/test/groovy/AkkaHttpClientInstrumentationTest.groovy +++ b/dd-java-agent/instrumentation/akka-http-10.0/src/test/groovy/AkkaHttpClientInstrumentationTest.groovy @@ -73,7 +73,6 @@ class AkkaHttpClientInstrumentationTest extends HttpClientTest { "servlet.path" endpoint.path "span.origin.type" { it.startsWith("TestServlets\$") || it == DefaultServlet.name } if (endpoint.errored) { - "$Tags.ERROR" endpoint.errored "error.msg" { it == null || it == EXCEPTION.body } "error.type" { it == null || it == Exception.name } "error.stack" { it == null || it instanceof String } diff --git a/dd-java-agent/instrumentation/google-http-client/src/test/groovy/AbstractGoogleHttpClientTest.groovy b/dd-java-agent/instrumentation/google-http-client/src/test/groovy/AbstractGoogleHttpClientTest.groovy index 318f71377e..e09a11a00e 100644 --- a/dd-java-agent/instrumentation/google-http-client/src/test/groovy/AbstractGoogleHttpClientTest.groovy +++ b/dd-java-agent/instrumentation/google-http-client/src/test/groovy/AbstractGoogleHttpClientTest.groovy @@ -67,7 +67,6 @@ abstract class AbstractGoogleHttpClientTest extends HttpClientTest { "$Tags.HTTP_STATUS" endpoint.status "span.origin.type" handlerName if (endpoint.errored) { - "$Tags.ERROR" endpoint.errored "error.msg" { it == null || it == EXCEPTION.body } "error.type" { it == null || it == Exception.name } "error.stack" { it == null || it instanceof String } diff --git a/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy b/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy index fea867f6df..42bd3e6ccb 100644 --- a/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy +++ b/dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy @@ -311,7 +311,6 @@ class JSPInstrumentationBasicTests extends AgentTestRunner { "span.origin.type" "org.apache.catalina.core.ApplicationFilterChain" "servlet.context" "/$jspWebappContext" "servlet.path" "/$jspFileName" - "error" true "error.type" { String tagExceptionType -> return tagExceptionType == exceptionClass.getName() || tagExceptionType.contains(exceptionClass.getSimpleName()) } @@ -332,7 +331,6 @@ class JSPInstrumentationBasicTests extends AgentTestRunner { "span.origin.type" jspClassName "servlet.context" "/$jspWebappContext" "jsp.requestURL" reqUrl - "error" true "error.type" { String tagExceptionType -> return tagExceptionType == exceptionClass.getName() || tagExceptionType.contains(exceptionClass.getSimpleName()) } diff --git a/dd-java-agent/instrumentation/netty-4.1/src/main/java/datadog/trace/instrumentation/netty41/server/HttpServerResponseTracingHandler.java b/dd-java-agent/instrumentation/netty-4.1/src/main/java/datadog/trace/instrumentation/netty41/server/HttpServerResponseTracingHandler.java index b3bbcc22ab..1fa88b1654 100644 --- a/dd-java-agent/instrumentation/netty-4.1/src/main/java/datadog/trace/instrumentation/netty41/server/HttpServerResponseTracingHandler.java +++ b/dd-java-agent/instrumentation/netty-4.1/src/main/java/datadog/trace/instrumentation/netty41/server/HttpServerResponseTracingHandler.java @@ -27,6 +27,7 @@ public class HttpServerResponseTracingHandler extends ChannelOutboundHandlerAdap } catch (final Throwable throwable) { DECORATE.onError(span, throwable); span.setTag(Tags.HTTP_STATUS, 500); + span.setError(true); span.finish(); // Finish the span manually since finishSpanOnClose was false throw throwable; } diff --git a/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayAdvice.java b/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayAdvice.java index 38535e060a..ee29cf04e8 100644 --- a/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayAdvice.java +++ b/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayAdvice.java @@ -56,6 +56,7 @@ public class PlayAdvice { } else { DECORATE.onError(playControllerSpan, throwable); playControllerSpan.setTag(Tags.HTTP_STATUS, 500); + playControllerSpan.setError(true); DECORATE.beforeFinish(playControllerSpan); playControllerSpan.finish(); } diff --git a/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayHttpServerDecorator.java b/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayHttpServerDecorator.java index 9a86bab6c4..8b12d3c965 100644 --- a/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayHttpServerDecorator.java +++ b/dd-java-agent/instrumentation/play-2.4/src/main/java8/datadog/trace/instrumentation/play24/PlayHttpServerDecorator.java @@ -75,6 +75,7 @@ public class PlayHttpServerDecorator extends HttpServerDecorator { "$Tags.HTTP_URL" String "$Tags.HTTP_METHOD" String "$Tags.HTTP_STATUS" Integer - if (endpoint == ERROR) { - "$Tags.ERROR" true - } else if (endpoint == EXCEPTION) { + if (endpoint == EXCEPTION) { errorTags(Exception, EXCEPTION.body) } defaultTags() diff --git a/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayAdvice.java b/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayAdvice.java index 1b4abebdb3..e0d0b35938 100644 --- a/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayAdvice.java +++ b/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayAdvice.java @@ -56,6 +56,7 @@ public class PlayAdvice { } else { DECORATE.onError(playControllerSpan, throwable); playControllerSpan.setTag(Tags.HTTP_STATUS, 500); + playControllerSpan.setError(true); DECORATE.beforeFinish(playControllerSpan); playControllerSpan.finish(); } diff --git a/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayHttpServerDecorator.java b/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayHttpServerDecorator.java index fa6345f91c..9d8a5f9412 100644 --- a/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayHttpServerDecorator.java +++ b/dd-java-agent/instrumentation/play-2.6/src/main/java8/datadog/trace/instrumentation/play26/PlayHttpServerDecorator.java @@ -78,6 +78,7 @@ public class PlayHttpServerDecorator extends HttpServerDecorator { "$Tags.HTTP_URL" String "$Tags.HTTP_METHOD" String "$Tags.HTTP_STATUS" Integer - if (endpoint == ERROR) { - "$Tags.ERROR" true - } else if (endpoint == EXCEPTION) { + if (endpoint == EXCEPTION) { errorTags(Exception, EXCEPTION.body) } defaultTags() @@ -122,7 +120,6 @@ class PlayServerTest extends HttpServerTest { "$Tags.HTTP_URL" "${endpoint.resolve(address)}" "$Tags.HTTP_METHOD" method if (endpoint.errored) { - "$Tags.ERROR" endpoint.errored "error.msg" { it == null || it == EXCEPTION.body } "error.type" { it == null || it == Exception.name } "error.stack" { it == null || it instanceof String } diff --git a/dd-java-agent/instrumentation/ratpack-1.4/src/test/groovy/server/RatpackHttpServerTest.groovy b/dd-java-agent/instrumentation/ratpack-1.4/src/test/groovy/server/RatpackHttpServerTest.groovy index 5d6448b39e..8a9a837662 100644 --- a/dd-java-agent/instrumentation/ratpack-1.4/src/test/groovy/server/RatpackHttpServerTest.groovy +++ b/dd-java-agent/instrumentation/ratpack-1.4/src/test/groovy/server/RatpackHttpServerTest.groovy @@ -115,9 +115,7 @@ class RatpackHttpServerTest extends HttpServerTest { "servlet.path" endpoint.path "span.origin.type" TestServlet2.Sync.name if (endpoint.errored) { - "$Tags.ERROR" endpoint.errored "error.msg" { it == null || it == EXCEPTION.body } "error.type" { it == null || it == Exception.name } "error.stack" { it == null || it instanceof String } diff --git a/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet3Advice.java b/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet3Advice.java index dbc1a4419d..4aac3f6d44 100644 --- a/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet3Advice.java +++ b/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/Servlet3Advice.java @@ -82,6 +82,7 @@ public class Servlet3Advice { if (resp.getStatus() == HttpServletResponse.SC_OK) { // exception is thrown in filter chain, but status code is incorrect span.setTag(Tags.HTTP_STATUS, 500); + span.setError(true); } DECORATE.onError(span, throwable); DECORATE.beforeFinish(span); diff --git a/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/TagSettingAsyncListener.java b/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/TagSettingAsyncListener.java index ef53db4dae..f8beb50b6a 100644 --- a/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/TagSettingAsyncListener.java +++ b/dd-java-agent/instrumentation/servlet/request-3/src/main/java/datadog/trace/instrumentation/servlet3/TagSettingAsyncListener.java @@ -46,6 +46,7 @@ public class TagSettingAsyncListener implements AsyncListener { == HttpServletResponse.SC_OK) { // exception is thrown in filter chain, but status code is incorrect span.setTag(Tags.HTTP_STATUS, 500); + span.setError(true); } DECORATE.onError(span, event.getThrowable()); DECORATE.beforeFinish(span); diff --git a/dd-java-agent/instrumentation/servlet/request-3/src/test/groovy/AbstractServlet3Test.groovy b/dd-java-agent/instrumentation/servlet/request-3/src/test/groovy/AbstractServlet3Test.groovy index 8c48cf5de1..06202a143a 100644 --- a/dd-java-agent/instrumentation/servlet/request-3/src/test/groovy/AbstractServlet3Test.groovy +++ b/dd-java-agent/instrumentation/servlet/request-3/src/test/groovy/AbstractServlet3Test.groovy @@ -87,7 +87,6 @@ abstract class AbstractServlet3Test extends HttpServerTest errorType, message) { - tag("error", true) tag("error.type", errorType.name) tag("error.stack", String) diff --git a/dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy b/dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy index a5f635a7e5..f23706f7c2 100644 --- a/dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy +++ b/dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy @@ -443,9 +443,6 @@ abstract class HttpServerTest ext // "$DDTags.HTTP_QUERY" uri.query // "$DDTags.HTTP_FRAGMENT" { it == null || it == uri.fragment } // Optional // } - if (endpoint.errored) { - "$Tags.ERROR" endpoint.errored - } defaultTags(true) } } diff --git a/dd-trace-api/src/main/java/datadog/trace/api/Config.java b/dd-trace-api/src/main/java/datadog/trace/api/Config.java index f2cbc80099..d35fd77763 100644 --- a/dd-trace-api/src/main/java/datadog/trace/api/Config.java +++ b/dd-trace-api/src/main/java/datadog/trace/api/Config.java @@ -69,7 +69,7 @@ public class Config { private static final Set DEFAULT_HTTP_SERVER_ERROR_STATUSES = parseIntegerRangeSet("500-599", "default"); private static final Set DEFAULT_HTTP_CLIENT_ERROR_STATUSES = - parseIntegerRangeSet("400-499", "default"); + parseIntegerRangeSet("400-599", "default"); private static final boolean DEFAULT_HTTP_SERVER_TAG_QUERY_STRING = false; private static final boolean DEFAULT_HTTP_CLIENT_TAG_QUERY_STRING = false; private static final boolean DEFAULT_HTTP_CLIENT_SPLIT_BY_DOMAIN = false; diff --git a/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy b/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy index 10682ecd0c..06c635afaf 100644 --- a/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy +++ b/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy @@ -35,7 +35,7 @@ class ConfigTest extends DDSpecification { config.writerType == "LoggingWriter" config.traceResolverEnabled == true config.httpServerErrorStatuses == (500..599).toSet() - config.httpClientErrorStatuses == (400..499).toSet() + config.httpClientErrorStatuses == (400..599).toSet() config.httpClientSplitByDomain == false config.dbClientSplitByInstance == false config.partialFlushMinSpans == 1000 @@ -149,7 +149,7 @@ class ConfigTest extends DDSpecification { config.writerType == " " config.traceResolverEnabled == true config.httpServerErrorStatuses == (500..599).toSet() - config.httpClientErrorStatuses == (400..499).toSet() + config.httpClientErrorStatuses == (400..599).toSet() config.httpClientSplitByDomain == false config.dbClientSplitByInstance == false } diff --git a/dd-trace-ot/src/main/java/datadog/opentracing/decorators/DDDecoratorsFactory.java b/dd-trace-ot/src/main/java/datadog/opentracing/decorators/DDDecoratorsFactory.java index 2c5055c919..36c0a4c2f4 100644 --- a/dd-trace-ot/src/main/java/datadog/opentracing/decorators/DDDecoratorsFactory.java +++ b/dd-trace-ot/src/main/java/datadog/opentracing/decorators/DDDecoratorsFactory.java @@ -7,7 +7,6 @@ import java.util.List; public class DDDecoratorsFactory { public static List createBuiltinDecorators() { - return Arrays.asList( - new DBTypeDecorator(), new ErrorFlag(), new SpanTypeDecorator(), new Status5XXDecorator()); + return Arrays.asList(new DBTypeDecorator(), new SpanTypeDecorator()); } } diff --git a/dd-trace-ot/src/main/java/datadog/opentracing/decorators/ErrorFlag.java b/dd-trace-ot/src/main/java/datadog/opentracing/decorators/ErrorFlag.java deleted file mode 100644 index 18ea0febbf..0000000000 --- a/dd-trace-ot/src/main/java/datadog/opentracing/decorators/ErrorFlag.java +++ /dev/null @@ -1,23 +0,0 @@ -package datadog.opentracing.decorators; - -import datadog.opentracing.DDSpanContext; -import io.opentracing.tag.Tags; - -public class ErrorFlag extends AbstractDecorator { - public ErrorFlag() { - super(); - this.setMatchingTag(Tags.ERROR.getKey()); - } - - @Override - public boolean shouldSetTag(final DDSpanContext context, final String tag, final Object value) { - // Assign resource name - try { - context.setErrorFlag(Boolean.parseBoolean(String.valueOf(value))); - } catch (final Throwable t) { - // DO NOTHING - } - // TODO: Do we really want an error tag if the error flag is already set? - return true; - } -} diff --git a/dd-trace-ot/src/main/java/datadog/opentracing/decorators/Status5XXDecorator.java b/dd-trace-ot/src/main/java/datadog/opentracing/decorators/Status5XXDecorator.java deleted file mode 100644 index 368d0dbd5b..0000000000 --- a/dd-trace-ot/src/main/java/datadog/opentracing/decorators/Status5XXDecorator.java +++ /dev/null @@ -1,21 +0,0 @@ -package datadog.opentracing.decorators; - -import datadog.opentracing.DDSpanContext; -import io.opentracing.tag.Tags; - -/** Mark all 5xx status codes as an error */ -public class Status5XXDecorator extends AbstractDecorator { - public Status5XXDecorator() { - super(); - this.setMatchingTag(Tags.HTTP_STATUS.getKey()); - } - - @Override - public boolean shouldSetTag(final DDSpanContext context, final String tag, final Object value) { - final int responseCode = Integer.parseInt(value.toString()); - if (500 <= responseCode && responseCode < 600) { - context.setTag(Tags.ERROR.getKey(), true); - } - return true; - } -} diff --git a/dd-trace-ot/src/test/groovy/datadog/opentracing/decorators/SpanDecoratorTest.groovy b/dd-trace-ot/src/test/groovy/datadog/opentracing/decorators/SpanDecoratorTest.groovy index 8234218908..a32e846aed 100644 --- a/dd-trace-ot/src/test/groovy/datadog/opentracing/decorators/SpanDecoratorTest.groovy +++ b/dd-trace-ot/src/test/groovy/datadog/opentracing/decorators/SpanDecoratorTest.groovy @@ -65,37 +65,6 @@ class SpanDecoratorTest extends DDSpecification { type = "foo" } - def "set 5XX status code as an error"() { - when: - Tags.HTTP_STATUS.set(span, status) - - then: - span.isError() == error - - where: - status | error - 400 | false - 404 | false - 499 | false - 500 | true - 550 | true - 599 | true - 600 | false - } - - def "set error flag when error tag reported"() { - when: - Tags.ERROR.set(span, error) - - then: - span.isError() == error - - where: - error | _ - true | _ - false | _ - } - def "#attribute decorators apply to builder too"() { setup: def span = tracer.buildSpan("decorator.test").withTag(name, value).start() @@ -107,18 +76,4 @@ class SpanDecoratorTest extends DDSpecification { attribute | name | value "spanType" | DDTags.SPAN_TYPE | "my-span-type" } - - def "decorators apply to builder too"() { - when: - span = tracer.buildSpan("decorator.test").withTag("error", "true").start() - - then: - span.error - - when: - span = tracer.buildSpan("decorator.test").withTag(Tags.HTTP_STATUS.key, 500).start() - - then: - span.error - } } diff --git a/dd-trace-ot/src/test/groovy/datadog/trace/DDTracerTest.groovy b/dd-trace-ot/src/test/groovy/datadog/trace/DDTracerTest.groovy index 99d40bc17b..5b5c252694 100644 --- a/dd-trace-ot/src/test/groovy/datadog/trace/DDTracerTest.groovy +++ b/dd-trace-ot/src/test/groovy/datadog/trace/DDTracerTest.groovy @@ -35,7 +35,7 @@ class DDTracerTest extends DDSpecification { def tracer = new DDTracer() then: - tracer.spanContextDecorators.size() == 4 + tracer.spanContextDecorators.size() == 2 tracer.injector instanceof DatadogHttpCodec.Injector tracer.extractor instanceof DatadogHttpCodec.Extractor