Support Hibernate 3.3

This commit is contained in:
Will Gittoes 2019-03-21 13:32:26 +11:00
parent c369fafe8c
commit af0f37861b
No known key found for this signature in database
GPG Key ID: 521026A02DB0BB42
14 changed files with 15 additions and 15 deletions

View File

@ -16,7 +16,7 @@ muzzle {
pass { pass {
group = "org.hibernate" group = "org.hibernate"
module = "hibernate-core" module = "hibernate-core"
versions = "[3.3.2.GA,4.0.0.Final)" versions = "[3.3.0.GA,4.0.0.Final)"
assertInverse = true assertInverse = true
} }
} }
@ -32,7 +32,7 @@ testSets {
} }
dependencies { dependencies {
compileOnly group: 'org.hibernate', name: 'hibernate-core', version: '3.3.2.GA' compileOnly group: 'org.hibernate', name: 'hibernate-core', version: '3.3.0.GA'
compile project(':dd-java-agent:agent-tooling') compile project(':dd-java-agent:agent-tooling')
compile project(':dd-java-agent:instrumentation:hibernate') compile project(':dd-java-agent:instrumentation:hibernate')
@ -45,7 +45,7 @@ dependencies {
testCompile project(':dd-java-agent:testing') testCompile project(':dd-java-agent:testing')
testCompile project(':dd-java-agent:instrumentation:jdbc') testCompile project(':dd-java-agent:instrumentation:jdbc')
testCompile group: 'org.hibernate', name: 'hibernate-core', version: '3.3.2.GA' testCompile group: 'org.hibernate', name: 'hibernate-core', version: '3.3.0.GA'
testCompile group: 'org.hibernate', name: 'hibernate-annotations', version: '+' testCompile group: 'org.hibernate', name: 'hibernate-annotations', version: '+'
testCompile group: 'javassist', name: 'javassist', version: '+' testCompile group: 'javassist', name: 'javassist', version: '+'
testCompile group: 'com.h2database', name: 'h2', version: '1.4.197' testCompile group: 'com.h2database', name: 'h2', version: '1.4.197'

View File

@ -1,8 +1,8 @@
package datadog.trace.instrumentation.hibernate.core.v3_5; package datadog.trace.instrumentation.hibernate.core.v3_3;
import datadog.trace.agent.tooling.Instrumenter; import datadog.trace.agent.tooling.Instrumenter;
import org.hibernate.EntityNameResolver;
import org.hibernate.classic.Validatable; import org.hibernate.classic.Validatable;
import org.hibernate.transaction.JBossTransactionManagerLookup;
public abstract class AbstractHibernateInstrumentation extends Instrumenter.Default { public abstract class AbstractHibernateInstrumentation extends Instrumenter.Default {
@ -28,15 +28,15 @@ public abstract class AbstractHibernateInstrumentation extends Instrumenter.Defa
/** /**
* Some cases of instrumentation will match more broadly than others, so this unused method * Some cases of instrumentation will match more broadly than others, so this unused method
* allows all instrumentation to uniformly match versions of Hibernate between 3.5 and 4. * allows all instrumentation to uniformly match versions of Hibernate between 3.3 and 4.
*/ */
public static void muzzleCheck( public static void muzzleCheck(
// Not in 4.0 // Not in 4.0
final Validatable validatable, final Validatable validatable,
// Not before 3.2.0.GA (Can't find anything not before 3.5) // Not before 3.3.0.GA
final EntityNameResolver resolver) { final JBossTransactionManagerLookup lookup) {
validatable.validate(); validatable.validate();
resolver.resolveEntityName(null); lookup.getUserTransactionName();
} }
} }
} }

View File

@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.core.v3_5; package datadog.trace.instrumentation.hibernate.core.v3_3;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType; import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static java.util.Collections.singletonMap; import static java.util.Collections.singletonMap;

View File

@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.core.v3_5; package datadog.trace.instrumentation.hibernate.core.v3_3;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType; import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR; import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;

View File

@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.core.v3_5; package datadog.trace.instrumentation.hibernate.core.v3_3;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType; import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR; import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;

View File

@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.core.v3_5; package datadog.trace.instrumentation.hibernate.core.v3_3;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType; import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR; import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;

View File

@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.core.v3_5; package datadog.trace.instrumentation.hibernate.core.v3_3;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType; import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static java.util.Collections.singletonMap; import static java.util.Collections.singletonMap;

View File

@ -41,7 +41,7 @@ include ':dd-java-agent:instrumentation:elasticsearch:transport-5.3'
include ':dd-java-agent:instrumentation:elasticsearch:transport-6' include ':dd-java-agent:instrumentation:elasticsearch:transport-6'
include ':dd-java-agent:instrumentation:grpc-1.5' include ':dd-java-agent:instrumentation:grpc-1.5'
include ':dd-java-agent:instrumentation:hibernate' include ':dd-java-agent:instrumentation:hibernate'
include ':dd-java-agent:instrumentation:hibernate:core-3.5' include ':dd-java-agent:instrumentation:hibernate:core-3.3'
include ':dd-java-agent:instrumentation:hibernate:core-4.0' include ':dd-java-agent:instrumentation:hibernate:core-4.0'
include ':dd-java-agent:instrumentation:hibernate:core-4.3' include ':dd-java-agent:instrumentation:hibernate:core-4.3'
include ':dd-java-agent:instrumentation:http-url-connection' include ':dd-java-agent:instrumentation:http-url-connection'