Review comments

This commit is contained in:
Will Gittoes 2019-03-01 09:42:07 +11:00
parent 3334affc42
commit afc517f0c3
No known key found for this signature in database
GPG Key ID: 521026A02DB0BB42
10 changed files with 9 additions and 23 deletions

View File

@ -6,7 +6,7 @@ public abstract class AbstractAwsClientInstrumentation extends Instrumenter.Defa
private static final String INSTRUMENTATION_NAME = "aws-sdk";
public AbstractAwsClientInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override

View File

@ -1,7 +1,6 @@
package datadog.trace.instrumentation.hibernate;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@ -24,7 +23,7 @@ import org.hibernate.Criteria;
public class CriteriaInstrumentation extends Instrumenter.Default {
public CriteriaInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override

View File

@ -1,7 +1,5 @@
package datadog.trace.instrumentation.hibernate;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import datadog.trace.agent.decorator.OrmClientDecorator;
import datadog.trace.api.DDSpanTypes;
import java.util.List;
@ -17,7 +15,7 @@ public class HibernateDecorator extends OrmClientDecorator {
@Override
protected String[] instrumentationNames() {
return new String[] {INSTRUMENTATION_NAME};
return new String[] {"hibernate-core"};
}
@Override

View File

@ -1,5 +0,0 @@
package datadog.trace.instrumentation.hibernate;
public class HibernateInstrumentation {
public static final String INSTRUMENTATION_NAME = "hibernate-core";
}

View File

@ -1,7 +1,6 @@
package datadog.trace.instrumentation.hibernate;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@ -24,7 +23,7 @@ import org.hibernate.engine.HibernateIterator;
public class IteratorInstrumentation extends Instrumenter.Default {
public IteratorInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override

View File

@ -1,7 +1,6 @@
package datadog.trace.instrumentation.hibernate;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@ -23,7 +22,7 @@ import org.hibernate.procedure.ProcedureCall;
public class ProcedureCallInstrumentation extends Instrumenter.Default {
public ProcedureCallInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override

View File

@ -2,7 +2,6 @@ package datadog.trace.instrumentation.hibernate;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@ -26,7 +25,7 @@ import org.hibernate.SQLQuery;
public class QueryInstrumentation extends Instrumenter.Default {
public QueryInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override

View File

@ -2,7 +2,6 @@ package datadog.trace.instrumentation.hibernate;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@ -28,7 +27,7 @@ import org.hibernate.SharedSessionContract;
public class SessionFactoryInstrumentation extends Instrumenter.Default {
public SessionFactoryInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override

View File

@ -2,7 +2,6 @@ package datadog.trace.instrumentation.hibernate;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
import static net.bytebuddy.matcher.ElementMatchers.named;
@ -35,7 +34,7 @@ import org.hibernate.procedure.ProcedureCall;
public class SessionInstrumentation extends Instrumenter.Default {
public SessionInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override

View File

@ -1,7 +1,6 @@
package datadog.trace.instrumentation.hibernate;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.HibernateInstrumentation.INSTRUMENTATION_NAME;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@ -24,7 +23,7 @@ import org.hibernate.Transaction;
public class TransactionInstrumentation extends Instrumenter.Default {
public TransactionInstrumentation() {
super(INSTRUMENTATION_NAME);
super("hibernate-core");
}
@Override