Merge pull request #81 from tyler/misc

Various cleanup items

.circleci/config.yml

@@ -53,5 +53,6 @@ jobs:
                 -Psigning.secretKeyRingFile=/home/circleci/dd-trace-java/.circleci/secring.gpg \
                 -PbintrayUser=${BINTRAY_USER} \
                 -PbintrayApiKey=${BINTRAY_API_KEY} \
+                -PbuildInfo.build.number=${CIRCLE_BUILD_NUM} \
                 artifactoryPublish
             fi

.gitignore

@@ -7,7 +7,7 @@ target
 
 # Gradle #
 #########
-!/gradle/wrapper/*
+!**/gradle/wrapper/*
 /.gradle
 **/build/
 dd-trace-examples/**/build/

dd-java-agent/src/main/java/io/opentracing/contrib/mongo/TracingCommandListenerFactory.java

@@ -2,6 +2,10 @@ package io.opentracing.contrib.mongo;
 
 import io.opentracing.Tracer;
 
+/**
+ * This class exists purely to bypass the reduction in constructor visibility of
+ * TracingCommandListener.
+ */
 public class TracingCommandListenerFactory {
 
   public static TracingCommandListener create(final Tracer tracer) {

dd-trace-examples/spring-boot-jdbc/README.md

@@ -1,8 +1,8 @@
-## Spring-boot + JDBC (MySQL) example
+## Spring-boot + JDBC example
 ### Purpose
 
 This project aims at demonstrating how to instrument legacy code based on the SpringBoot framework
-and a MySQL JDBC connection.
+and a JDBC connection.
 
 We are using the [opentracing contributions](https://github.com/opentracing-contrib) in order to trace:
  * All the JDBC queries and calls to the DB
@@ -15,7 +15,7 @@ at this time.
  
 ### Run the demo
 
-The demo consistes into a very simple backend backed by a MySQL db. The Spring Boot application exposes
+The demo consistes into a very simple backend backed by an in-memory db. The Spring Boot application exposes
 2 endpoints that can be reached via an HTTP request.
 
 #### Prerequisites
@@ -30,10 +30,8 @@ connection properties are okay.
 ```properties
 # file: src/resources/application.properties
 
-spring.datasource.driver-class-name= io.opentracing.contrib.jdbc.TracingDriver
+spring.datasource.driver-class-name=io.opentracing.contrib.jdbc.TracingDriver
-spring.datasource.url= jdbc:tracing:mysql://localhost:3306/springdb
+spring.datasource.url=jdbc:tracing:h2:mem:spring-test
-spring.datasource.username=root
-spring.datasource.password=root
 ```
 
 ```yaml

gradle/publish.gradle

@@ -80,7 +80,6 @@ artifactoryPublish { task ->
       }
       defaults {
         publishConfigs('archives')
-        publishIvy = false
       }
     }
   }