open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Hikaricp: Avoid registering duplicate metrics (#6325) 

* Hikaricp: Avoid registering duplicate metrics

* Update instrumentation/hikaricp-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hikaricp/HikariPoolInstrumentation.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* spotless

* Trigger build

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This commit is contained in:
Lauri Tulmin 2022-07-15 09:59:28 +03:00 committed by GitHub
parent 07f787693c
commit b3e543d2df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
instrumentation/hikaricp-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hikaricp/HikariPoolInstrumentation.java
View File

@ -39,8 +39,16 @@ public class HikariPoolInstrumentation implements TypeInstrumentation {
@Advice.OnMethodEnter(suppress = Throwable.class)
public static void onEnter(
@Advice.Argument(value = 0, readOnly = false) MetricsTrackerFactory userMetricsTracker) {
@Advice.Argument(value = 0, readOnly = false) MetricsTrackerFactory userMetricsTracker,
@Advice.FieldValue(value = "metricsTracker") AutoCloseable existingMetricsTracker)
throws Exception {
if (existingMetricsTracker != null) {
// we call close on the existing metrics tracker in case it's our wrapper, so that our
// wrapper will unregister itself and won't keep recording metrics which leads to warnings
// about duplicate metrics
existingMetricsTracker.close();
}
userMetricsTracker = HikariSingletons.createMetricsTrackerFactory(userMetricsTracker);
}
}