Clarify muzzle specific checks

This commit is contained in:
Brian Devins-Suresh 2020-03-20 14:57:08 -04:00
parent 59dffa3d5d
commit b4be2b18e4
3 changed files with 4 additions and 0 deletions

View File

@ -41,6 +41,7 @@ public class ChannelFutureListenerInstrumentation extends Instrumenter.Default {
// Optimization for expensive typeMatcher.
return hasClassesNamed(
"org.jboss.netty.channel.ChannelFutureListener",
// 3.10: NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.setHeader
"org.jboss.netty.channel.StaticChannelPipeline" // Not in 3.10
);
}

View File

@ -34,7 +34,9 @@ public class NettyChannelInstrumentation extends Instrumenter.Default {
// Optimization for expensive typeMatcher.
return hasClassesNamed(
"org.jboss.netty.channel.Channel",
// 3.7: cannot find symbol method headers() for type HttpRequest
"org.jboss.netty.handler.codec.http.DefaultHttpHeaders", // Not in 3.7
// 3.10: NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.setHeader
"org.jboss.netty.channel.StaticChannelPipeline" // Not in 3.10
);
}

View File

@ -50,6 +50,7 @@ public class NettyChannelPipelineInstrumentation extends Instrumenter.Default {
// Optimization for expensive typeMatcher.
return hasClassesNamed(
"org.jboss.netty.channel.ChannelPipeline",
// 3.10: NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.setHeader
"org.jboss.netty.channel.StaticChannelPipeline" // Not in 3.10
);
}