Clarify log messages when tracing is disabled

This commit is contained in:
Nikolay Martynov 2019-05-09 16:12:35 -04:00
parent e4416464cb
commit ba02250cf6
2 changed files with 14 additions and 8 deletions

View File

@ -46,6 +46,8 @@ public class AgentInstaller {
public static void installBytebuddyAgent(final Instrumentation inst) {
if (Config.get().isTraceEnabled()) {
installBytebuddyAgent(inst, new AgentBuilder.Listener[0]);
} else {
log.debug("Tracing is disabled, not installing instrumentations.");
}
}

View File

@ -8,16 +8,20 @@ import lombok.extern.slf4j.Slf4j;
public class TracerInstaller {
/** Register a global tracer if no global tracer is already registered. */
public static synchronized void installGlobalTracer() {
if (Config.get().isTraceEnabled() && !io.opentracing.util.GlobalTracer.isRegistered()) {
final DDTracer tracer = new DDTracer();
try {
io.opentracing.util.GlobalTracer.register(tracer);
datadog.trace.api.GlobalTracer.registerIfAbsent(tracer);
} catch (final RuntimeException re) {
log.warn("Failed to register tracer '" + tracer + "'", re);
if (Config.get().isTraceEnabled()) {
if (!io.opentracing.util.GlobalTracer.isRegistered()) {
final DDTracer tracer = new DDTracer();
try {
io.opentracing.util.GlobalTracer.register(tracer);
datadog.trace.api.GlobalTracer.registerIfAbsent(tracer);
} catch (final RuntimeException re) {
log.warn("Failed to register tracer '" + tracer + "'", re);
}
} else {
log.debug("GlobalTracer already registered.");
}
} else {
log.debug("GlobalTracer already registered.");
log.debug("Tracing is disabled, not installing GlobalTracer.");
}
}