Add comment explaining Kafka versions limitations check

This commit is contained in:
Nikolay Martynov 2019-05-17 11:10:12 -04:00
parent 55d7c2a6f5
commit c02110a2a1
1 changed files with 2 additions and 0 deletions

View File

@ -73,6 +73,8 @@ public final class KafkaProducerInstrumentation extends Instrumenter.Default {
callback = new ProducerCallback(callback, scope);
// Do not inject headers for batch versions below 2
// This is how similar check is being done in Kafka client itself:
// https://github.com/apache/kafka/blob/05fcfde8f69b0349216553f711fdfc3f0259c601/clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java#L411-L412
if (apiVersions.maxUsableProduceMagic() >= RecordBatch.MAGIC_VALUE_V2) {
try {
GlobalTracer.get()