From c166c937b3417dbc6bfcaafd7321483fcf0c0c37 Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Fri, 13 May 2022 20:24:59 +0300 Subject: [PATCH] Disable periodic metric reading in tests (#6025) --- .../javaagent/testing/exporter/AgentTestingCustomizer.java | 4 +++- .../testing/exporter/AgentTestingExporterFactory.java | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingCustomizer.java b/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingCustomizer.java index 91631aab2e..357803f63d 100644 --- a/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingCustomizer.java +++ b/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingCustomizer.java @@ -23,7 +23,9 @@ public class AgentTestingCustomizer implements AutoConfigurationCustomizerProvid static final MetricReader metricReader = PeriodicMetricReader.builder(AgentTestingExporterFactory.metricExporter) - .setInterval(Duration.ofMillis(100)) + // Set really long interval. We'll call forceFlush when we need the metrics + // instead of collecting them periodically. + .setInterval(Duration.ofNanos(Long.MAX_VALUE)) .build(); static void reset() { diff --git a/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingExporterFactory.java b/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingExporterFactory.java index 081e846266..b22cc695ed 100644 --- a/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingExporterFactory.java +++ b/testing/agent-exporter/src/main/java/io/opentelemetry/javaagent/testing/exporter/AgentTestingExporterFactory.java @@ -19,6 +19,7 @@ public class AgentTestingExporterFactory { } public static List getMetricExportRequests() { + AgentTestingCustomizer.metricReader.forceFlush().join(10, TimeUnit.SECONDS); return metricExporter.getCollectedExportRequests(); }