Small changes to servlet3 tests (#12456)

This commit is contained in:
Lauri Tulmin 2024-10-17 16:41:06 +03:00 committed by GitHub
parent 4497fbf968
commit c3d8ed4ee6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
19 changed files with 37 additions and 76 deletions

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0;
import java.io.IOException; import java.io.IOException;
import javax.servlet.RequestDispatcher; import javax.servlet.RequestDispatcher;

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0;
import static io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpServerTest.controller; import static io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpServerTest.controller;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.CAPTURE_HEADERS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.CAPTURE_HEADERS;

View File

@ -5,10 +5,10 @@
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
public class JettyServlet3AsyncTest extends JettyServlet3Test { class JettyServlet3AsyncTest extends JettyServlet3Test {
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {

View File

@ -5,10 +5,10 @@
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
public class JettyServlet3FakeAsyncTest extends JettyServlet3Test { class JettyServlet3FakeAsyncTest extends JettyServlet3Test {
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.FakeAsync.class; return TestServlet3.FakeAsync.class;

View File

@ -5,10 +5,10 @@
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
public class JettyServlet3SyncTest extends JettyServlet3Test { class JettyServlet3SyncTest extends JettyServlet3Test {
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Sync.class; return TestServlet3.Sync.class;

View File

@ -15,7 +15,7 @@ import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumenta
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint; import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.AbstractServlet3Test; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.AbstractServlet3Test;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import io.opentelemetry.sdk.testing.assertj.SpanDataAssert; import io.opentelemetry.sdk.testing.assertj.SpanDataAssert;
import io.opentelemetry.sdk.trace.data.SpanData; import io.opentelemetry.sdk.trace.data.SpanData;
import io.opentelemetry.semconv.HttpAttributes; import io.opentelemetry.semconv.HttpAttributes;
@ -30,7 +30,7 @@ import org.eclipse.jetty.server.handler.ErrorHandler;
import org.eclipse.jetty.servlet.ServletHandler; import org.eclipse.jetty.servlet.ServletHandler;
import org.junit.jupiter.api.extension.RegisterExtension; import org.junit.jupiter.api.extension.RegisterExtension;
public class JettyServletHandlerTest extends AbstractServlet3Test<Server, ServletHandler> { class JettyServletHandlerTest extends AbstractServlet3Test<Server, ServletHandler> {
@RegisterExtension @RegisterExtension
protected static final InstrumentationExtension testing = protected static final InstrumentationExtension testing =

View File

@ -8,7 +8,7 @@ package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty.dispatch;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty.JettyServlet3Test; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.jetty.JettyServlet3Test;
public abstract class JettyDispatchTest extends JettyServlet3Test { abstract class JettyDispatchTest extends JettyServlet3Test {
@Override @Override
protected void configure(HttpServerTestOptions options) { protected void configure(HttpServerTestOptions options) {

View File

@ -15,11 +15,11 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.eclipse.jetty.servlet.ServletContextHandler; import org.eclipse.jetty.servlet.ServletContextHandler;
public class JettyServlet3DispatchAsyncTest extends JettyDispatchTest { class JettyServlet3DispatchAsyncTest extends JettyDispatchTest {
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Async.class; return TestServlet3.Async.class;

View File

@ -15,11 +15,11 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.eclipse.jetty.servlet.ServletContextHandler; import org.eclipse.jetty.servlet.ServletContextHandler;
public class JettyServlet3DispatchImmediateTest extends JettyDispatchTest { class JettyServlet3DispatchImmediateTest extends JettyDispatchTest {
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Async.class; return TestServlet3.Async.class;

View File

@ -15,12 +15,12 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.RequestDispatcherServlet; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.RequestDispatcherServlet;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.eclipse.jetty.servlet.ServletContextHandler; import org.eclipse.jetty.servlet.ServletContextHandler;
public class JettyServlet3ForwardTest extends JettyDispatchTest { class JettyServlet3ForwardTest extends JettyDispatchTest {
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Sync.class; // dispatch to sync servlet return TestServlet3.Sync.class; // dispatch to sync servlet

View File

@ -15,12 +15,12 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.RequestDispatcherServlet; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.RequestDispatcherServlet;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.eclipse.jetty.servlet.ServletContextHandler; import org.eclipse.jetty.servlet.ServletContextHandler;
public class JettyServlet3IncludeTest extends JettyDispatchTest { class JettyServlet3IncludeTest extends JettyDispatchTest {
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Sync.class; // dispatch to sync servlet return TestServlet3.Sync.class; // dispatch to sync servlet

View File

@ -5,17 +5,11 @@
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.junit.jupiter.api.extension.RegisterExtension;
class TomcatServlet3AsyncTest extends TomcatServlet3Test { class TomcatServlet3AsyncTest extends TomcatServlet3Test {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Async.class; return TestServlet3.Async.class;

View File

@ -5,17 +5,11 @@
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.junit.jupiter.api.extension.RegisterExtension;
class TomcatServlet3FakeAsyncTest extends TomcatServlet3Test { class TomcatServlet3FakeAsyncTest extends TomcatServlet3Test {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.FakeAsync.class; return TestServlet3.FakeAsync.class;

View File

@ -5,17 +5,11 @@
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat; package io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.junit.jupiter.api.extension.RegisterExtension;
class TomcatServlet3SyncTest extends TomcatServlet3Test { class TomcatServlet3SyncTest extends TomcatServlet3Test {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Sync.class; return TestServlet3.Sync.class;

View File

@ -12,6 +12,8 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import io.opentelemetry.api.trace.SpanKind; import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint; import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.AbstractServlet3Test; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.AbstractServlet3Test;
@ -38,11 +40,16 @@ import org.apache.catalina.startup.Tomcat;
import org.junit.jupiter.api.Assumptions; import org.junit.jupiter.api.Assumptions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource; import org.junit.jupiter.params.provider.CsvSource;
public abstract class TomcatServlet3Test extends AbstractServlet3Test<Tomcat, Context> { public abstract class TomcatServlet3Test extends AbstractServlet3Test<Tomcat, Context> {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
private static final ServerEndpoint ACCESS_LOG_SUCCESS = private static final ServerEndpoint ACCESS_LOG_SUCCESS =
new ServerEndpoint( new ServerEndpoint(
"ACCESS_LOG_SUCCESS", "ACCESS_LOG_SUCCESS",

View File

@ -15,20 +15,13 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.apache.catalina.Context; import org.apache.catalina.Context;
import org.junit.jupiter.api.extension.RegisterExtension;
class TomcatServlet3DispatchAsyncTest extends TomcatDispatchTest { class TomcatServlet3DispatchAsyncTest extends TomcatDispatchTest {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
@Override @Override
protected void configure(HttpServerTestOptions options) { protected void configure(HttpServerTestOptions options) {
super.configure(options); super.configure(options);

View File

@ -15,20 +15,13 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.apache.catalina.Context; import org.apache.catalina.Context;
import org.junit.jupiter.api.extension.RegisterExtension;
class TomcatServlet3DispatchImmediateTest extends TomcatDispatchTest { class TomcatServlet3DispatchImmediateTest extends TomcatDispatchTest {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Sync.class; return TestServlet3.Sync.class;

View File

@ -15,21 +15,14 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.RequestDispatcherServlet; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.RequestDispatcherServlet;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.apache.catalina.Context; import org.apache.catalina.Context;
import org.junit.jupiter.api.extension.RegisterExtension;
class TomcatServlet3ForwardTest extends TomcatDispatchTest { class TomcatServlet3ForwardTest extends TomcatDispatchTest {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Sync.class; // dispatch to sync servlet return TestServlet3.Sync.class; // dispatch to sync servlet

View File

@ -14,21 +14,14 @@ import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.REDIRECT;
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS; import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions; import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.RequestDispatcherServlet; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.RequestDispatcherServlet;
import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.tomcat.TestServlet3; import io.opentelemetry.javaagent.instrumentation.servlet.v3_0.TestServlet3;
import javax.servlet.Servlet; import javax.servlet.Servlet;
import org.apache.catalina.Context; import org.apache.catalina.Context;
import org.junit.jupiter.api.extension.RegisterExtension;
class TomcatServlet3IncludeTest extends TomcatDispatchTest { class TomcatServlet3IncludeTest extends TomcatDispatchTest {
@RegisterExtension
protected static final InstrumentationExtension testing =
HttpServerInstrumentationExtension.forAgent();
@Override @Override
public Class<? extends Servlet> servlet() { public Class<? extends Servlet> servlet() {
return TestServlet3.Sync.class; // dispatch to sync servlet return TestServlet3.Sync.class; // dispatch to sync servlet