open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add abstract method getRpcSystem() (#2149)

This commit is contained in:
汤煜冬 2021-02-01 19:47:27 +08:00 committed by GitHub
parent 93b3a3b289
commit c523fa2eae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/RpcClientTracer.java
View File

@ -13,4 +13,6 @@ public abstract class RpcClientTracer extends BaseTracer {
protected RpcClientTracer(Tracer tracer) { protected RpcClientTracer(Tracer tracer) {
super(tracer); super(tracer);
} }
protected abstract String getRpcSystem();
} }

7
instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/client/GrpcClientTracer.java
View File

@ -23,9 +23,14 @@ public class GrpcClientTracer extends RpcClientTracer {
super(tracer); super(tracer);
} }
@Override
protected String getRpcSystem() {
return "grpc";
}
public Span startSpan(String name) { public Span startSpan(String name) {
SpanBuilder spanBuilder = tracer.spanBuilder(name).setSpanKind(CLIENT); SpanBuilder spanBuilder = tracer.spanBuilder(name).setSpanKind(CLIENT);
spanBuilder.setAttribute(SemanticAttributes.RPC_SYSTEM, "grpc"); spanBuilder.setAttribute(SemanticAttributes.RPC_SYSTEM, getRpcSystem());
return spanBuilder.startSpan(); return spanBuilder.startSpan();
} }

7
instrumentation/rmi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/client/RmiClientTracer.java
View File

@ -27,7 +27,7 @@ public class RmiClientTracer extends RpcClientTracer {
SpanBuilder spanBuilder = SpanBuilder spanBuilder =
tracer.spanBuilder(serviceName + "/" + methodName).setSpanKind(CLIENT); tracer.spanBuilder(serviceName + "/" + methodName).setSpanKind(CLIENT);
spanBuilder.setAttribute(SemanticAttributes.RPC_SYSTEM, "java_rmi"); spanBuilder.setAttribute(SemanticAttributes.RPC_SYSTEM, getRpcSystem());
spanBuilder.setAttribute(SemanticAttributes.RPC_SERVICE, serviceName); spanBuilder.setAttribute(SemanticAttributes.RPC_SERVICE, serviceName);
spanBuilder.setAttribute(SemanticAttributes.RPC_METHOD, methodName); spanBuilder.setAttribute(SemanticAttributes.RPC_METHOD, methodName);
@ -38,4 +38,9 @@ public class RmiClientTracer extends RpcClientTracer {
protected String getInstrumentationName() { protected String getInstrumentationName() {
return "io.opentelemetry.javaagent.rmi"; return "io.opentelemetry.javaagent.rmi";
} }
@Override
protected String getRpcSystem() {
return "java_rmi";
}
} }