From c62beec606de3cc8da5f78394e40ca5c30b86e11 Mon Sep 17 00:00:00 2001 From: Laplie Anderson Date: Tue, 19 Nov 2019 10:47:14 -0500 Subject: [PATCH] Increase code coverage by removing unused method + tests --- .../main/java/datadog/trace/api/Config.java | 6 ---- .../datadog/trace/api/ConfigTest.groovy | 30 +++++++++++++++++++ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/dd-trace-api/src/main/java/datadog/trace/api/Config.java b/dd-trace-api/src/main/java/datadog/trace/api/Config.java index e70d979c70..856516cf35 100644 --- a/dd-trace-api/src/main/java/datadog/trace/api/Config.java +++ b/dd-trace-api/src/main/java/datadog/trace/api/Config.java @@ -842,12 +842,6 @@ public class Config { return value == null || value.trim().isEmpty() ? defaultValue : Integer.valueOf(value); } - private static Float getPropertyFloatValue( - final Properties properties, final String name, final Float defaultValue) { - final String value = properties.getProperty(name); - return value == null || value.trim().isEmpty() ? defaultValue : Float.valueOf(value); - } - private static Double getPropertyDoubleValue( final Properties properties, final String name, final Double defaultValue) { final String value = properties.getProperty(name); diff --git a/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy b/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy index d64cc7f48b..518d05ce9a 100644 --- a/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy +++ b/dd-trace-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy @@ -860,4 +860,34 @@ class ConfigTest extends DDSpecification { cleanup: System.clearProperty(PREFIX + CONFIGURATION_FILE) } + + def "get analytics sample rate"() { + setup: + environmentVariables.set("DD_FOO_ANALYTICS_SAMPLE_RATE", "0.5") + environmentVariables.set("DD_BAR_ANALYTICS_SAMPLE_RATE", "0.9") + + System.setProperty("dd.baz.analytics.sample-rate", "0.7") + System.setProperty("dd.buzz.analytics.sample-rate", "0.3") + + when: + String[] array = services.toArray(new String[0]) + def value = Config.get().getInstrumentationAnalyticsSampleRate(array) + + then: + value == expected + + where: + services | expected + ["foo"] | 0.5f + ["baz"] | 0.7f + ["doesnotexist"] | 1.0f + ["doesnotexist", "foo"] | 0.5f + ["doesnotexist", "baz"] | 0.7f + ["foo", "bar"] | 0.5f + ["bar", "foo"] | 0.9f + ["baz", "buzz"] | 0.7f + ["buzz", "baz"] | 0.3f + ["foo", "baz"] | 0.5f + ["baz", "foo"] | 0.7f + } }