diff --git a/gradle/enforcement/checkstyle.xml b/gradle/enforcement/checkstyle.xml
index d96293ba34..474c7ccd99 100644
--- a/gradle/enforcement/checkstyle.xml
+++ b/gradle/enforcement/checkstyle.xml
@@ -216,25 +216,23 @@
-
+
- -->
-
+
- -->
ResultT execute(
- @NonNull RequestT request, @NonNull GenericType resultType) {
+ public RESULT execute(
+ @NonNull REQUEST request, @NonNull GenericType resultType) {
return session.execute(request, resultType);
}
diff --git a/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/client/TracingClientInterceptor.java b/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/client/TracingClientInterceptor.java
index 23ba748a35..c943c5afc5 100644
--- a/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/client/TracingClientInterceptor.java
+++ b/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/client/TracingClientInterceptor.java
@@ -51,13 +51,13 @@ public class TracingClientInterceptor implements ClientInterceptor {
}
@Override
- public ClientCall interceptCall(
- MethodDescriptor method, CallOptions callOptions, Channel next) {
+ public ClientCall interceptCall(
+ MethodDescriptor method, CallOptions callOptions, Channel next) {
String methodName = method.getFullMethodName();
Span span = tracer.startSpan(methodName);
GrpcHelper.prepareSpan(span, methodName);
Context context = Context.current().with(span);
- final ClientCall result;
+ final ClientCall result;
try (Scope ignored = context.makeCurrent()) {
try {
// call other interceptors
@@ -77,15 +77,18 @@ public class TracingClientInterceptor implements ClientInterceptor {
return new TracingClientCall<>(result, span, context, tracer);
}
- static final class TracingClientCall
- extends ForwardingClientCall.SimpleForwardingClientCall {
+ static final class TracingClientCall
+ extends ForwardingClientCall.SimpleForwardingClientCall {
private final Span span;
private final Context context;
private final GrpcClientTracer tracer;
TracingClientCall(
- ClientCall delegate, Span span, Context context, GrpcClientTracer tracer) {
+ ClientCall delegate,
+ Span span,
+ Context context,
+ GrpcClientTracer tracer) {
super(delegate);
this.span = span;
this.context = context;
@@ -93,7 +96,7 @@ public class TracingClientInterceptor implements ClientInterceptor {
}
@Override
- public void start(Listener responseListener, Metadata headers) {
+ public void start(Listener responseListener, Metadata headers) {
OpenTelemetry.getGlobalPropagators().getTextMapPropagator().inject(context, headers, SETTER);
try (Scope ignored = span.makeCurrent()) {
super.start(new TracingClientCallListener<>(responseListener, span, tracer), headers);
@@ -104,7 +107,7 @@ public class TracingClientInterceptor implements ClientInterceptor {
}
@Override
- public void sendMessage(ReqT message) {
+ public void sendMessage(REQUEST message) {
try (Scope ignored = span.makeCurrent()) {
super.sendMessage(message);
} catch (Throwable e) {
@@ -114,21 +117,21 @@ public class TracingClientInterceptor implements ClientInterceptor {
}
}
- static final class TracingClientCallListener
- extends ForwardingClientCallListener.SimpleForwardingClientCallListener {
+ static final class TracingClientCallListener
+ extends ForwardingClientCallListener.SimpleForwardingClientCallListener {
private final Span span;
private final GrpcClientTracer tracer;
private final AtomicLong messageId = new AtomicLong();
- TracingClientCallListener(Listener delegate, Span span, GrpcClientTracer tracer) {
+ TracingClientCallListener(Listener delegate, Span span, GrpcClientTracer tracer) {
super(delegate);
this.span = span;
this.tracer = tracer;
}
@Override
- public void onMessage(RespT message) {
+ public void onMessage(RESPONSE message) {
Attributes attributes =
Attributes.of(
GrpcHelper.MESSAGE_TYPE, "SENT", GrpcHelper.MESSAGE_ID, messageId.incrementAndGet());
diff --git a/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/server/TracingServerInterceptor.java b/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/server/TracingServerInterceptor.java
index 4c683655cd..664ffeac3b 100644
--- a/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/server/TracingServerInterceptor.java
+++ b/instrumentation/grpc-1.5/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_5/server/TracingServerInterceptor.java
@@ -46,8 +46,10 @@ public class TracingServerInterceptor implements ServerInterceptor {
}
@Override
- public ServerCall.Listener interceptCall(
- ServerCall call, Metadata headers, ServerCallHandler next) {
+ public ServerCall.Listener interceptCall(
+ ServerCall call,
+ Metadata headers,
+ ServerCallHandler next) {
String methodName = call.getMethodDescriptor().getFullMethodName();
Span span = tracer.startSpan(methodName, headers);
@@ -72,12 +74,12 @@ public class TracingServerInterceptor implements ServerInterceptor {
}
}
- static final class TracingServerCall
- extends ForwardingServerCall.SimpleForwardingServerCall {
+ static final class TracingServerCall
+ extends ForwardingServerCall.SimpleForwardingServerCall {
private final Span span;
private final GrpcServerTracer tracer;
- TracingServerCall(ServerCall delegate, Span span, GrpcServerTracer tracer) {
+ TracingServerCall(ServerCall delegate, Span span, GrpcServerTracer tracer) {
super(delegate);
this.span = span;
this.tracer = tracer;
@@ -95,21 +97,21 @@ public class TracingServerInterceptor implements ServerInterceptor {
}
}
- static final class TracingServerCallListener
- extends ForwardingServerCallListener.SimpleForwardingServerCallListener {
+ static final class TracingServerCallListener
+ extends ForwardingServerCallListener.SimpleForwardingServerCallListener {
private final Span span;
private final GrpcServerTracer tracer;
private final AtomicLong messageId = new AtomicLong();
- TracingServerCallListener(Listener delegate, Span span, GrpcServerTracer tracer) {
+ TracingServerCallListener(Listener delegate, Span span, GrpcServerTracer tracer) {
super(delegate);
this.span = span;
this.tracer = tracer;
}
@Override
- public void onMessage(ReqT message) {
+ public void onMessage(REQUEST message) {
// TODO(anuraaga): Restore
Attributes attributes =
Attributes.of(
diff --git a/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/util/CombinedSimpleChannelHandler.java b/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/util/CombinedSimpleChannelHandler.java
index e59a1f8e59..5fb3fba4fd 100644
--- a/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/util/CombinedSimpleChannelHandler.java
+++ b/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/util/CombinedSimpleChannelHandler.java
@@ -17,14 +17,14 @@ import org.jboss.netty.channel.SimpleChannelUpstreamHandler;
import org.jboss.netty.channel.WriteCompletionEvent;
public class CombinedSimpleChannelHandler<
- Upstream extends SimpleChannelUpstreamHandler,
- Downstream extends SimpleChannelDownstreamHandler>
+ UPSTREAM extends SimpleChannelUpstreamHandler,
+ DOWNSTREAM extends SimpleChannelDownstreamHandler>
extends SimpleChannelHandler {
- private final Upstream upstream;
- private final Downstream downstream;
+ private final UPSTREAM upstream;
+ private final DOWNSTREAM downstream;
- public CombinedSimpleChannelHandler(Upstream upstream, Downstream downstream) {
+ public CombinedSimpleChannelHandler(UPSTREAM upstream, DOWNSTREAM downstream) {
this.upstream = upstream;
this.downstream = downstream;
}