From d47f5d952b21ff8aecf22faaf54a5e992bd1f966 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 14 Mar 2022 02:07:23 -0700 Subject: [PATCH] Suppress markdown link check on release branches (#5560) --- .github/workflows/ci.yml | 5 +++++ .github/workflows/pr.yml | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 41d743cc69..f4b67e49c0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,6 +51,11 @@ jobs: uses: ./.github/workflows/examples.yml markdown-link-check: + # release branches are excluded + # because links to external urls can break at any time which requires unnecessary release branch + # maintenance, especially for patches (and also because the README.md javaagent download link + # has to be updated on release branches before the release download has been published) + if: ${{ !startsWith(github.ref_name, 'v') }} runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 521033a641..402045b1ed 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -44,7 +44,7 @@ jobs: cache-read-only: true muzzle: - # release branches are excluded + # release branch PRs are excluded # because any time a new library version is released to maven central it can fail # which requires unnecessary release branch maintenance, especially for patches if: ${{ !startsWith(github.base_ref, 'v') }}