open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Set span.type = web on jax-rs endpoints

This commit is contained in:
Luca Abbati 2019-08-30 13:57:30 +02:00
parent 359ac9c190
commit d877039fa7
No known key found for this signature in database
GPG Key ID: 74DBB952D9BA17F2
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dd-java-agent/instrumentation/jax-rs-annotations/src/main/java/datadog/trace/instrumentation/jaxrs/JaxRsAnnotationsDecorator.java
View File

@ -3,6 +3,7 @@ package datadog.trace.instrumentation.jaxrs;
import static datadog.trace.bootstrap.WeakMap.Provider.newWeakMap; import static datadog.trace.bootstrap.WeakMap.Provider.newWeakMap;
import datadog.trace.agent.decorator.BaseDecorator; import datadog.trace.agent.decorator.BaseDecorator;
import datadog.trace.api.DDSpanTypes;
import datadog.trace.api.DDTags; import datadog.trace.api.DDTags;
import datadog.trace.bootstrap.WeakMap; import datadog.trace.bootstrap.WeakMap;
import io.opentracing.Scope; import io.opentracing.Scope;
@ -50,8 +51,9 @@ public class JaxRsAnnotationsDecorator extends BaseDecorator {
} }
public void updateCurrentScope(final Scope scope, final Method method) { public void updateCurrentScope(final Scope scope, final Method method) {
String resourceName = getResourceName(method);
final Span span = scope.span(); final Span span = scope.span();
span.setTag(DDTags.SPAN_TYPE, DDSpanTypes.HTTP_SERVER);
String resourceName = getResourceName(method);
if (!resourceName.isEmpty()) { if (!resourceName.isEmpty()) {
span.setTag(DDTags.RESOURCE_NAME, resourceName); span.setTag(DDTags.RESOURCE_NAME, resourceName);
} }

4
dd-java-agent/instrumentation/jax-rs-annotations/src/test/groovy/JaxRsAnnotationsInstrumentationTest.groovy
View File

@ -27,7 +27,8 @@ class JaxRsAnnotationsInstrumentationTest extends AgentTestRunner {
trace(0, 1) { trace(0, 1) {
span(0) { span(0) {
operationName "jax-rs.endpoint" operationName "jax-rs.endpoint"
resourceName 'POST /a' resourceName "POST /a"
spanType "web"
tags { tags {
"$Tags.COMPONENT.key" "jax-rs-controller" "$Tags.COMPONENT.key" "jax-rs-controller"
defaultTags() defaultTags()
@ -59,6 +60,7 @@ class JaxRsAnnotationsInstrumentationTest extends AgentTestRunner {
span(1) { span(1) {
operationName "jax-rs.endpoint" operationName "jax-rs.endpoint"
resourceName name resourceName name
spanType "web"
childOf span(0) childOf span(0)
tags { tags {
"$Tags.COMPONENT.key" "jax-rs-controller" "$Tags.COMPONENT.key" "jax-rs-controller"