move non-api classes to internal packages (#11502)

This commit is contained in:
Gregor Zeitlinger 2024-06-05 17:36:24 +02:00 committed by GitHub
parent b8b1bff708
commit d991af71d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
12 changed files with 62 additions and 31 deletions

View File

@ -9,12 +9,12 @@ import io.opentelemetry.api.OpenTelemetry;
import io.opentelemetry.api.trace.TracerProvider; import io.opentelemetry.api.trace.TracerProvider;
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.MapConverter; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.MapConverter;
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.SdkEnabled; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.SdkEnabled;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtelResourceProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtelResourceProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtlpExporterProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtlpExporterProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.PropagationProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.PropagationProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.SpringConfigProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.SpringConfigProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.resources.DistroVersionResourceProvider; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.resources.DistroVersionResourceProvider;
import io.opentelemetry.instrumentation.spring.autoconfigure.resources.SpringResourceProvider; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.resources.SpringResourceProvider;
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk; import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil; import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
import io.opentelemetry.sdk.autoconfigure.internal.ComponentLoader; import io.opentelemetry.sdk.autoconfigure.internal.ComponentLoader;
@ -60,7 +60,7 @@ public class OpenTelemetryAutoConfiguration {
@Configuration @Configuration
@Conditional(SdkEnabled.class) @Conditional(SdkEnabled.class)
@ConditionalOnMissingBean(OpenTelemetry.class) @ConditionalOnMissingBean(OpenTelemetry.class)
public static class OpenTelemetrySdkConfig { static class OpenTelemetrySdkConfig {
@Bean @Bean
@ConfigurationPropertiesBinding @ConfigurationPropertiesBinding
@ -131,7 +131,7 @@ public class OpenTelemetryAutoConfiguration {
@Configuration @Configuration
@ConditionalOnMissingBean(OpenTelemetry.class) @ConditionalOnMissingBean(OpenTelemetry.class)
@ConditionalOnProperty(name = "otel.sdk.disabled", havingValue = "true") @ConditionalOnProperty(name = "otel.sdk.disabled", havingValue = "true")
public static class DisabledOpenTelemetrySdkConfig { static class DisabledOpenTelemetrySdkConfig {
@Bean @Bean
public OpenTelemetry openTelemetry() { public OpenTelemetry openTelemetry() {
@ -147,7 +147,7 @@ public class OpenTelemetryAutoConfiguration {
@Configuration @Configuration
@ConditionalOnBean(OpenTelemetry.class) @ConditionalOnBean(OpenTelemetry.class)
@ConditionalOnMissingBean({ConfigProperties.class}) @ConditionalOnMissingBean({ConfigProperties.class})
public static class FallbackConfigProperties { static class FallbackConfigProperties {
@Bean @Bean
public ConfigProperties otelProperties() { public ConfigProperties otelProperties() {
return DefaultConfigProperties.create(Collections.emptyMap()); return DefaultConfigProperties.create(Collections.emptyMap());
@ -159,7 +159,7 @@ public class OpenTelemetryAutoConfiguration {
* <a * <a
* href="https://github.com/open-telemetry/opentelemetry-java/blob/4519a7e90243e5b75b3a46a14c872de88b95a9a1/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java#L405-L408">here</a> * href="https://github.com/open-telemetry/opentelemetry-java/blob/4519a7e90243e5b75b3a46a14c872de88b95a9a1/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java#L405-L408">here</a>
*/ */
public static class OpenTelemetrySdkComponentLoader implements ComponentLoader { static class OpenTelemetrySdkComponentLoader implements ComponentLoader {
private final ApplicationContext applicationContext; private final ApplicationContext applicationContext;
private final SpiHelper spiHelper = private final SpiHelper spiHelper =

View File

@ -27,7 +27,7 @@ import org.springframework.context.annotation.Configuration;
public class MongoClientInstrumentationAutoConfiguration { public class MongoClientInstrumentationAutoConfiguration {
@Bean @Bean
public MongoClientSettingsBuilderCustomizer customizer( MongoClientSettingsBuilderCustomizer customizer(
OpenTelemetry openTelemetry, ConfigProperties config) { OpenTelemetry openTelemetry, ConfigProperties config) {
return builder -> return builder ->
builder.addCommandListener( builder.addCommandListener(

View File

@ -3,12 +3,16 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.instrumentation.spring.autoconfigure.properties; package io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties;
import java.util.Collections; import java.util.Collections;
import java.util.Map; import java.util.Map;
import org.springframework.boot.context.properties.ConfigurationProperties; import org.springframework.boot.context.properties.ConfigurationProperties;
/**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
@ConfigurationProperties(prefix = "otel.resource") @ConfigurationProperties(prefix = "otel.resource")
public class OtelResourceProperties { public class OtelResourceProperties {
private Map<String, String> attributes = Collections.emptyMap(); private Map<String, String> attributes = Collections.emptyMap();

View File

@ -3,13 +3,16 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.instrumentation.spring.autoconfigure.properties; package io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import org.springframework.boot.context.properties.ConfigurationProperties; import org.springframework.boot.context.properties.ConfigurationProperties;
/** Configuration for OLTP exporters. */ /**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
@ConfigurationProperties(prefix = "otel.exporter.otlp") @ConfigurationProperties(prefix = "otel.exporter.otlp")
public final class OtlpExporterProperties { public final class OtlpExporterProperties {
@ -35,6 +38,10 @@ public final class OtlpExporterProperties {
return logs; return logs;
} }
/**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
public static class SignalProperties { public static class SignalProperties {
private final Map<String, String> headers = new HashMap<>(); private final Map<String, String> headers = new HashMap<>();

View File

@ -3,13 +3,16 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.instrumentation.spring.autoconfigure.properties; package io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties;
import java.util.Collections; import java.util.Collections;
import java.util.List; import java.util.List;
import org.springframework.boot.context.properties.ConfigurationProperties; import org.springframework.boot.context.properties.ConfigurationProperties;
/** Configuration for propagators. */ /**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
@ConfigurationProperties(prefix = "otel") @ConfigurationProperties(prefix = "otel")
public final class PropagationProperties { public final class PropagationProperties {

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.instrumentation.spring.autoconfigure.properties; package io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties;
import io.opentelemetry.exporter.otlp.internal.OtlpConfigUtil; import io.opentelemetry.exporter.otlp.internal.OtlpConfigUtil;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
@ -18,6 +18,10 @@ import org.springframework.core.env.Environment;
import org.springframework.expression.ExpressionParser; import org.springframework.expression.ExpressionParser;
import org.springframework.expression.spel.standard.SpelExpressionParser; import org.springframework.expression.spel.standard.SpelExpressionParser;
/**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
public class SpringConfigProperties implements ConfigProperties { public class SpringConfigProperties implements ConfigProperties {
private final Environment environment; private final Environment environment;

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.instrumentation.spring.autoconfigure.resources; package io.opentelemetry.instrumentation.spring.autoconfigure.internal.resources;
import io.opentelemetry.api.common.AttributeKey; import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.common.Attributes; import io.opentelemetry.api.common.Attributes;
@ -12,6 +12,10 @@ import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider; import io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider;
import io.opentelemetry.sdk.resources.Resource; import io.opentelemetry.sdk.resources.Resource;
/**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
public class DistroVersionResourceProvider implements ResourceProvider { public class DistroVersionResourceProvider implements ResourceProvider {
public static final String VERSION = public static final String VERSION =

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.instrumentation.spring.autoconfigure.resources; package io.opentelemetry.instrumentation.spring.autoconfigure.internal.resources;
import io.opentelemetry.api.common.Attributes; import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.common.AttributesBuilder; import io.opentelemetry.api.common.AttributesBuilder;
@ -14,6 +14,10 @@ import io.opentelemetry.semconv.ServiceAttributes;
import java.util.Optional; import java.util.Optional;
import org.springframework.boot.info.BuildProperties; import org.springframework.boot.info.BuildProperties;
/**
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
* any time.
*/
public class SpringResourceProvider implements ResourceProvider { public class SpringResourceProvider implements ResourceProvider {
private final Optional<BuildProperties> buildProperties; private final Optional<BuildProperties> buildProperties;

View File

@ -9,6 +9,10 @@ import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.entry; import static org.assertj.core.api.Assertions.entry;
import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration; import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration;
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtelResourceProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtlpExporterProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.PropagationProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.SpringConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
import java.util.Arrays; import java.util.Arrays;

View File

@ -9,10 +9,10 @@ import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.entry; import static org.assertj.core.api.Assertions.entry;
import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration; import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtelResourceProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtelResourceProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtlpExporterProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtlpExporterProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.PropagationProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.PropagationProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.SpringConfigProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.SpringConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;

View File

@ -6,10 +6,11 @@
package io.opentelemetry.instrumentation.spring.autoconfigure.resources; package io.opentelemetry.instrumentation.spring.autoconfigure.resources;
import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration; import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtelResourceProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtelResourceProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtlpExporterProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtlpExporterProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.PropagationProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.PropagationProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.SpringConfigProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.SpringConfigProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.resources.SpringResourceProvider;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
import io.opentelemetry.sdk.testing.assertj.AttributesAssert; import io.opentelemetry.sdk.testing.assertj.AttributesAssert;

View File

@ -10,10 +10,10 @@ import static org.assertj.core.api.Assertions.assertThat;
import io.opentelemetry.api.common.AttributeKey; import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.common.Attributes; import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.trace.SpanKind; import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtelResourceProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtelResourceProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.OtlpExporterProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.OtlpExporterProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.PropagationProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.PropagationProperties;
import io.opentelemetry.instrumentation.spring.autoconfigure.properties.SpringConfigProperties; import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.SpringConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider; import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties; import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;