diff --git a/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/DispatcherServletInstrumentation.java b/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/DispatcherServletInstrumentation.java index 6684d03ddb..de455c912e 100644 --- a/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/DispatcherServletInstrumentation.java +++ b/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/DispatcherServletInstrumentation.java @@ -15,8 +15,8 @@ */ package io.opentelemetry.auto.instrumentation.springwebmvc; -import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebHttpServerDecorator.DECORATE; -import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebHttpServerDecorator.TRACER; +import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebMvcDecorator.DECORATE; +import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebMvcDecorator.TRACER; import static io.opentelemetry.trace.TracingContextUtils.currentContextWith; import static net.bytebuddy.matcher.ElementMatchers.isMethod; import static net.bytebuddy.matcher.ElementMatchers.isProtected; @@ -51,7 +51,7 @@ public final class DispatcherServletInstrumentation extends Instrumenter.Default @Override public String[] helperClassNames() { - return new String[] {packageName + ".SpringWebHttpServerDecorator"}; + return new String[] {packageName + ".SpringWebMvcDecorator"}; } @Override diff --git a/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/HandlerAdapterInstrumentation.java b/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/HandlerAdapterInstrumentation.java index dc3110c19b..7974fcc8e5 100644 --- a/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/HandlerAdapterInstrumentation.java +++ b/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/HandlerAdapterInstrumentation.java @@ -16,8 +16,8 @@ package io.opentelemetry.auto.instrumentation.springwebmvc; import static io.opentelemetry.auto.bootstrap.instrumentation.decorator.HttpServerDecorator.SPAN_ATTRIBUTE; -import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebHttpServerDecorator.DECORATE; -import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebHttpServerDecorator.TRACER; +import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebMvcDecorator.DECORATE; +import static io.opentelemetry.auto.instrumentation.springwebmvc.SpringWebMvcDecorator.TRACER; import static io.opentelemetry.auto.tooling.ClassLoaderMatcher.hasClassesNamed; import static io.opentelemetry.auto.tooling.bytebuddy.matcher.AgentElementMatchers.implementsInterface; import static io.opentelemetry.trace.TracingContextUtils.currentContextWith; @@ -60,7 +60,7 @@ public final class HandlerAdapterInstrumentation extends Instrumenter.Default { @Override public String[] helperClassNames() { - return new String[] {packageName + ".SpringWebHttpServerDecorator"}; + return new String[] {packageName + ".SpringWebMvcDecorator"}; } @Override diff --git a/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/SpringWebHttpServerDecorator.java b/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/SpringWebMvcDecorator.java similarity index 73% rename from instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/SpringWebHttpServerDecorator.java rename to instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/SpringWebMvcDecorator.java index f695a94e58..7a1154170e 100644 --- a/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/SpringWebHttpServerDecorator.java +++ b/instrumentation/spring-webmvc-3.1/src/main/java/io/opentelemetry/auto/instrumentation/springwebmvc/SpringWebMvcDecorator.java @@ -16,15 +16,12 @@ package io.opentelemetry.auto.instrumentation.springwebmvc; import io.opentelemetry.OpenTelemetry; -import io.opentelemetry.auto.bootstrap.instrumentation.decorator.HttpServerDecorator; +import io.opentelemetry.auto.bootstrap.instrumentation.decorator.BaseDecorator; import io.opentelemetry.trace.Span; import io.opentelemetry.trace.Tracer; import java.lang.reflect.Method; -import java.net.URI; -import java.net.URISyntaxException; import javax.servlet.Servlet; import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; import lombok.extern.slf4j.Slf4j; import org.springframework.web.HttpRequestHandler; import org.springframework.web.method.HandlerMethod; @@ -34,46 +31,12 @@ import org.springframework.web.servlet.View; import org.springframework.web.servlet.mvc.Controller; @Slf4j -public class SpringWebHttpServerDecorator - extends HttpServerDecorator { +public class SpringWebMvcDecorator extends BaseDecorator { public static final Tracer TRACER = OpenTelemetry.getTracerProvider().get("io.opentelemetry.auto.spring-webmvc-3.1"); - public static final SpringWebHttpServerDecorator DECORATE = new SpringWebHttpServerDecorator(); + public static final SpringWebMvcDecorator DECORATE = new SpringWebMvcDecorator(); - @Override - protected String method(final HttpServletRequest httpServletRequest) { - return httpServletRequest.getMethod(); - } - - @Override - protected URI url(final HttpServletRequest httpServletRequest) throws URISyntaxException { - return new URI( - httpServletRequest.getScheme(), - null, - httpServletRequest.getServerName(), - httpServletRequest.getServerPort(), - httpServletRequest.getRequestURI(), - httpServletRequest.getQueryString(), - null); - } - - @Override - protected String peerHostIP(final HttpServletRequest httpServletRequest) { - return httpServletRequest.getRemoteAddr(); - } - - @Override - protected Integer peerPort(final HttpServletRequest httpServletRequest) { - return httpServletRequest.getRemotePort(); - } - - @Override - protected Integer status(final HttpServletResponse httpServletResponse) { - return httpServletResponse.getStatus(); - } - - @Override public Span onRequest(final Span span, final HttpServletRequest request) { if (request != null) { final Object bestMatchingPattern =