From dec780b74c5af5a8055baf628a7fa9c260eaee9a Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Tue, 2 May 2017 16:48:12 +0200 Subject: [PATCH] [PR #1] improving logging --- .../java/com/datadoghq/trace/writer/impl/DDAgentWriter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java b/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java index 8e9b13dfcc..e888d4ea57 100644 --- a/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java +++ b/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java @@ -86,7 +86,7 @@ public class DDAgentWriter implements Writer { if(proceed){ traces.add(trace); }else{ - logger.warn("Cannot add a trace of "+trace.size()+" as the async queue is full. Queue max size:"+DEFAULT_MAX_SPANS); + logger.warn("Cannot add a trace of {} as the async queue is full. Queue max size: {}", trace.size(), DEFAULT_MAX_SPANS); } } @@ -120,7 +120,7 @@ public class DDAgentWriter implements Writer { traces.drainTo(payload, DEFAULT_BATCH_SIZE); //SEND the payload to the agent - logger.debug("Async writer about to write "+payload.size()+" traces."); + logger.debug("Async writer about to write {} traces.", payload.size()); api.sendTraces(payload); //Compute the number of spans sent @@ -128,7 +128,7 @@ public class DDAgentWriter implements Writer { for(List trace:payload){ spansCount+=trace.size(); } - logger.debug("Async writer just sent "+spansCount+" spans through "+payload.size()+" traces"); + logger.debug("Async writer just sent {} spans through {} traces", spansCount, payload.size()); //Release the tokens tokens.release(spansCount);