open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #557 from DataDog/mar-kolya/add-lost-jdbc-statement-logging 

Add logging in jdbc instrumentation when we cannot unwrap connection
This commit is contained in:
Nikolay Martynov 2018-10-31 15:55:03 -04:00 committed by GitHub
parent 5f429b17b9 8a066de772
commit e83c379992
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/ExceptionLogger.java
View File

@ -1,8 +1,13 @@
package datadog.trace.bootstrap; package datadog.trace.bootstrap;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** /**
* Class used for exception handler logging. * Class used for exception handler logging.
* *
* <p>See datadog.trace.agent.tooling.ExceptionHandlers * <p>See datadog.trace.agent.tooling.ExceptionHandlers
*/ */
public class ExceptionLogger {} public class ExceptionLogger {
public static final Logger LOGGER = LoggerFactory.getLogger(ExceptionLogger.class);
}

2
dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/PreparedStatementInstrumentation.java
View File

@ -14,6 +14,7 @@ import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.api.DDSpanTypes; import datadog.trace.api.DDSpanTypes;
import datadog.trace.api.DDTags; import datadog.trace.api.DDTags;
import datadog.trace.bootstrap.CallDepthThreadLocalMap; import datadog.trace.bootstrap.CallDepthThreadLocalMap;
import datadog.trace.bootstrap.ExceptionLogger;
import datadog.trace.bootstrap.JDBCMaps; import datadog.trace.bootstrap.JDBCMaps;
import io.opentracing.Scope; import io.opentracing.Scope;
import io.opentracing.Span; import io.opentracing.Span;
@ -76,6 +77,7 @@ public final class PreparedStatementInstrumentation extends Instrumenter.Default
} }
} catch (final Throwable e) { } catch (final Throwable e) {
// Had some problem getting the connection. // Had some problem getting the connection.
ExceptionLogger.LOGGER.debug("Could not get connection for PreparedStatementAdvice", e);
return NoopScope.INSTANCE; return NoopScope.INSTANCE;
} }

2
dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/StatementInstrumentation.java
View File

@ -14,6 +14,7 @@ import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.api.DDSpanTypes; import datadog.trace.api.DDSpanTypes;
import datadog.trace.api.DDTags; import datadog.trace.api.DDTags;
import datadog.trace.bootstrap.CallDepthThreadLocalMap; import datadog.trace.bootstrap.CallDepthThreadLocalMap;
import datadog.trace.bootstrap.ExceptionLogger;
import datadog.trace.bootstrap.JDBCMaps; import datadog.trace.bootstrap.JDBCMaps;
import io.opentracing.Scope; import io.opentracing.Scope;
import io.opentracing.Span; import io.opentracing.Span;
@ -77,6 +78,7 @@ public final class StatementInstrumentation extends Instrumenter.Default {
} }
} catch (final Throwable e) { } catch (final Throwable e) {
// Had some problem getting the connection. // Had some problem getting the connection.
ExceptionLogger.LOGGER.debug("Could not get connection for StatementAdvice", e);
return NoopScope.INSTANCE; return NoopScope.INSTANCE;
} }