open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #983 from DataDog/tyler/cache-soft-refs 

Optimize DDCachingPoolStrategy
This commit is contained in:
Tyler Benson 2019-09-11 09:41:48 -07:00 committed by GitHub
parent 07b58e1cf4 988b03b2f3
commit e895d7c3a7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/DDCachingPoolStrategy.java
View File

@ -1,6 +1,7 @@
package datadog.trace.agent.tooling; package datadog.trace.agent.tooling;
import static datadog.trace.agent.tooling.ClassLoaderMatcher.BOOTSTRAP_CLASSLOADER; import static datadog.trace.agent.tooling.ClassLoaderMatcher.BOOTSTRAP_CLASSLOADER;
import static datadog.trace.agent.tooling.ClassLoaderMatcher.skipClassLoader;
import static net.bytebuddy.agent.builder.AgentBuilder.PoolStrategy; import static net.bytebuddy.agent.builder.AgentBuilder.PoolStrategy;
import com.google.common.cache.Cache; import com.google.common.cache.Cache;
@ -45,7 +46,14 @@ public class DDCachingPoolStrategy implements PoolStrategy {
synchronized (key) { synchronized (key) {
cache = typePoolCache.get(key); cache = typePoolCache.get(key);
if (null == cache) { if (null == cache) {
cache = EvictingCacheProvider.withObjectType(cleaner, 1, TimeUnit.MINUTES); if (skipClassLoader().matches(classLoader)) {
// Don't bother creating a cache for a classloader that won't match.
// (avoiding a lot of DelegatingClassLoader instances)
// This is primarily an optimization.
cache = TypePool.CacheProvider.NoOp.INSTANCE;
} else {
cache = EvictingCacheProvider.withObjectType(cleaner, 1, TimeUnit.MINUTES);
}
typePoolCache.put(key, cache); typePoolCache.put(key, cache);
} }
} }
@ -64,7 +72,7 @@ public class DDCachingPoolStrategy implements PoolStrategy {
final Cleaner cleaner, final long expireDuration, final TimeUnit unit) { final Cleaner cleaner, final long expireDuration, final TimeUnit unit) {
cache = cache =
CacheBuilder.newBuilder() CacheBuilder.newBuilder()
.initialCapacity(1000) .initialCapacity(100) // Per classloader, so we want a small default.
.maximumSize(10000) .maximumSize(10000)
.expireAfterAccess(expireDuration, unit) .expireAfterAccess(expireDuration, unit)
.build(); .build();