From ef94e2fb79a64708f37c0a628e8819ebe9f8643e Mon Sep 17 00:00:00 2001 From: Nikolay Martynov Date: Fri, 24 May 2019 16:37:27 -0400 Subject: [PATCH] Add note about Kafka consumer iterator thread safety --- .../trace/instrumentation/kafka_clients/TracingIterable.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/TracingIterable.java b/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/TracingIterable.java index 01135fea39..3757fd12ac 100644 --- a/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/TracingIterable.java +++ b/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/TracingIterable.java @@ -33,6 +33,10 @@ public class TracingIterable implements Iterable { private final String operationName; private final KafkaDecorator decorator; + /** + * Note: this may potentially create problems if this iterator is used from different threads. + * But at the moment we cannot do much about this. + */ private Scope currentScope; public TracingIterator(