open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

change rpc type in apache dubbo (#5432) 

* change rpc type in apache dubbo

* fix dubbo test

* fix test
This commit is contained in:
YuDong Tang 2022-04-01 16:49:10 +08:00 committed by GitHub
parent 5a25d276f8
commit f269ef75ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboRpcAttributesGetter.java
View File

@ -12,7 +12,7 @@ enum DubboRpcAttributesGetter implements RpcAttributesGetter<DubboRequest> {
@Override
public String system(DubboRequest request) {
return "dubbo";
return "apache_dubbo";
}
@Override

8
instrumentation/apache-dubbo-2.7/testing/src/main/groovy/io/opentelemetry/instrumentation/apachedubbo/v2_7/AbstractDubboTest.groovy
View File

@ -97,7 +97,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind CLIENT
childOf span(0)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "org.apache.dubbo.rpc.service.GenericService"
"$SemanticAttributes.RPC_METHOD" "\$invoke"
"$SemanticAttributes.NET_PEER_NAME" "localhost"
@ -109,7 +109,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind SERVER
childOf span(1)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "io.opentelemetry.instrumentation.apachedubbo.v2_7.api.HelloService"
"$SemanticAttributes.RPC_METHOD" "hello"
"$SemanticAttributes.NET_PEER_IP" String
@ -168,7 +168,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind CLIENT
childOf span(0)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "org.apache.dubbo.rpc.service.GenericService"
"$SemanticAttributes.RPC_METHOD" "\$invokeAsync"
"$SemanticAttributes.NET_PEER_NAME" "localhost"
@ -180,7 +180,7 @@ abstract class AbstractDubboTest extends InstrumentationSpecification {
kind SERVER
childOf span(1)
attributes {
"$SemanticAttributes.RPC_SYSTEM" "dubbo"
"$SemanticAttributes.RPC_SYSTEM" "apache_dubbo"
"$SemanticAttributes.RPC_SERVICE" "io.opentelemetry.instrumentation.apachedubbo.v2_7.api.HelloService"
"$SemanticAttributes.RPC_METHOD" "hello"
"$SemanticAttributes.NET_PEER_IP" String