Fix compilation failure on main (#2926)

* Fix compilation failure on main

* Fix muzzle (probably)

* Fix muzzle (probably)

* Fix muzzle (probably)

* Fix muzzle (probably)

* Remove unnecessary dependency

* Revert "Remove unnecessary dependency"

This reverts commit 3fc1e68c99.

* spotless + random change in javaagent-tooling
This commit is contained in:
Mateusz Rzeszutek 2021-05-07 14:54:07 +02:00 committed by GitHub
parent 60ee981d07
commit f2d7e0ed74
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 12 additions and 3 deletions

View File

@ -51,6 +51,7 @@ class MuzzlePlugin implements Plugin<Project> {
def compileMuzzle = project.task('compileMuzzle') { def compileMuzzle = project.task('compileMuzzle') {
dependsOn(':javaagent-bootstrap:classes') dependsOn(':javaagent-bootstrap:classes')
dependsOn(':javaagent-tooling:classes') dependsOn(':javaagent-tooling:classes')
dependsOn(':javaagent-extension-api:classes')
dependsOn(project.tasks.classes) dependsOn(project.tasks.classes)
} }

View File

@ -46,6 +46,11 @@ afterEvaluate {
exclude group: 'io.opentelemetry', module: 'opentelemetry-sdk' exclude group: 'io.opentelemetry', module: 'opentelemetry-sdk'
exclude group: 'io.opentelemetry', module: 'opentelemetry-sdk-metrics' exclude group: 'io.opentelemetry', module: 'opentelemetry-sdk-metrics'
} }
compileOnly(project(':javaagent-tooling')) {
// OpenTelemetry SDK is not needed for compilation
exclude group: 'io.opentelemetry', module: 'opentelemetry-sdk'
exclude group: 'io.opentelemetry', module: 'opentelemetry-sdk-metrics'
}
compileOnly deps.bytebuddy compileOnly deps.bytebuddy
annotationProcessor deps.autoservice annotationProcessor deps.autoservice
compileOnly deps.autoservice compileOnly deps.autoservice

View File

@ -3,6 +3,7 @@ apply from: "$rootDir/gradle/java.gradle"
dependencies { dependencies {
testImplementation project(':instrumentation-api') testImplementation project(':instrumentation-api')
testImplementation project(':javaagent-extension-api') testImplementation project(':javaagent-extension-api')
testImplementation project(':javaagent-tooling')
testImplementation deps.bytebuddy testImplementation deps.bytebuddy
testImplementation project(':instrumentation:external-annotations:javaagent') testImplementation project(':instrumentation:external-annotations:javaagent')
} }

View File

@ -11,7 +11,7 @@ import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
import io.opentelemetry.context.Context; import io.opentelemetry.context.Context;
import io.opentelemetry.context.Scope; import io.opentelemetry.context.Scope;
import io.opentelemetry.javaagent.tooling.TypeInstrumentation; import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import java.util.Map; import java.util.Map;
import net.bytebuddy.asm.Advice; import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.method.MethodDescription; import net.bytebuddy.description.method.MethodDescription;

View File

@ -9,7 +9,7 @@ import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.named; import static net.bytebuddy.matcher.ElementMatchers.named;
import static net.bytebuddy.matcher.ElementMatchers.takesArgument; import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
import io.opentelemetry.javaagent.tooling.TypeInstrumentation; import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import java.util.Map; import java.util.Map;
import javax.ws.rs.core.Request; import javax.ws.rs.core.Request;
import net.bytebuddy.asm.Advice; import net.bytebuddy.asm.Advice;

View File

@ -27,4 +27,6 @@ dependencies {
implementation project(":javaagent-api") implementation project(":javaagent-api")
// TODO: ideally this module should not depend on bootstrap, bootstrap should be an internal component // TODO: ideally this module should not depend on bootstrap, bootstrap should be an internal component
implementation project(":javaagent-bootstrap") implementation project(":javaagent-bootstrap")
instrumentationMuzzle sourceSets.main.output
} }

View File

@ -82,7 +82,7 @@ public final class MuzzleGradlePluginUtil {
validatedModulesCount++; validatedModulesCount++;
} }
// run helper injector on all instrumenters // run helper injector on all instrumentation modules
if (assertPass) { if (assertPass) {
for (InstrumentationModule instrumentationModule : for (InstrumentationModule instrumentationModule :
ServiceLoader.load(InstrumentationModule.class, agentClassLoader)) { ServiceLoader.load(InstrumentationModule.class, agentClassLoader)) {