Trask Stalnaker
3b77cc4b2d
Semconv 1.21 ( #9408 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-09-13 19:20:23 +00:00
Mateusz Rzeszutek
65451b6529
Deprecate `NetClientAttributesExtractor` ( #9165 )
2023-08-16 11:21:10 +02:00
Mateusz Rzeszutek
9e37e724dc
Fix the main branch history ( #8817 )
2023-06-28 10:55:41 +00:00
Abhinandan Seshadri
f25cd6354c
Convert spring rabbitmq tests from groovy to java ( #8765 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Co-authored-by: SylvainJuge <763082+SylvainJuge@users.noreply.github.com>
Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
2023-06-28 10:51:27 +02:00
Lauri Tulmin
acd1c92173
Fix mongo latest dep tests ( #8785 )
2023-06-22 11:44:30 +02:00
Mateusz Rzeszutek
cde2e70148
Implement new stable server semantic conventions ( #8663 )
2023-06-13 11:07:59 +02:00
Mateusz Rzeszutek
e3944a53a5
Make net.transport an optional attribute ( #8279 )
2023-04-20 08:14:03 -07:00
Lauri Tulmin
5a14788fc1
Use .service instead of .getService() to get testcontainersBuildService ( #8188 )
2023-03-31 08:32:24 +00:00
Mateusz Rzeszutek
a9c065930d
Return interface instead of concrete implementation in instrumentatio… ( #7658 )
...
…n-api-semconv
We're already doing that for `SpanNameExtractor`, `OperationMetrics`,
`ContextCustomizer`, etc., so I figured we should do the same for
`AttributesExtractor` implementation. Also, none of the implementations
have any additional public surface - aside from the builder/factory
method users can just simply use the interface everywhere.
2023-01-31 13:21:28 +01:00
Mateusz Rzeszutek
e1895e548c
Rename all methods in all Getters to use the `get*()` naming scheme ( #7619 )
...
Resolves #6562
This PR only contains renames; the actual content is in the `*Getter`
interfaces, the rest of changes is just IntelliJ doing its job.
2023-01-23 09:28:11 +00:00
Lauri Tulmin
0cb8c75df7
Fix tests for mongodb 4.8 ( #7183 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7170
2022-11-15 13:21:07 -08:00
Trask Stalnaker
4e36285b6c
Temporary fix for testLatestDeps failure ( #7169 )
...
Tracking issues to fix for real: #7170 , #7171
2022-11-14 18:20:46 -08:00
Mateusz Rzeszutek
77035fc88c
Extract `net.peer.{name,port}` on start for CLIENT spans ( #6828 )
...
The [HTTP
spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client )
says these two attributes must be provided at span creation time - I
think it makes sense to extend it over to all `net`-related
instrumentations, cause these are supposed to be the logical peer
name/port, which are supposed to be known before the connection is
started/exchange is made.
2022-10-10 16:00:19 -07:00
Trask Stalnaker
429ecfc713
Update error prone ( #6646 )
...
(note that change from BDDMockito is due to
https://github.com/google/error-prone/issues/3396 )
2022-09-23 11:24:40 -07:00
Trask Stalnaker
5224194740
Move versions to dependencyManagement ( #6648 )
...
Part of #6645
2022-09-19 12:05:06 +03:00
Mateusz Rzeszutek
cfdbe758f2
Net attributes getters changes (in preparation for HTTP spec impl) ( #6503 )
...
* Net attributes getters changes: instrumentation-api-semconv changes
* Net attributes getters changes: getter implementations
* Net attributes getters changes: test fixes
* Remove net.sock.host.name
* code review comments
* default getter methods & getPeerSocketAddress() method name
* set authority in grpc earlier
2022-09-12 09:20:27 -07:00
Trask Stalnaker
13cb1f6498
Add mongo sanitization configuration ( #6541 )
2022-09-08 08:40:49 -07:00
Trask Stalnaker
f1774cabe2
Update net semantic convention changes ( #6268 )
...
* New net conventions: option a
* Feedback + sock.family + sock.peer.name
* peer.service + tests
* server net attributes attempt 1
* server net attributes attempt 2
* Javadoc
* Revisions
* Apply to instrumentations
* Feedback
* One more default method
* Spotless
* Fix javadoc
2022-08-18 09:02:23 -07:00
Lauri Tulmin
b5f49636f2
Mongodb: avoid duplicate tracing ( #6465 )
2022-08-12 08:41:18 -07:00
Trask Stalnaker
68a9f20eb3
Enable PrivateConstructorForUtilityClass errorprone check ( #6427 )
...
* PrivateConstructorForUtilityClass
* Advice
* More advice
* More
* More advice
* More
* Spotless
* Fix
* Fix
* Fix
* A better solution
* Revert
* More
* Fix
* Spotless
* Fix
2022-08-10 11:30:22 +03:00
Mateusz Rzeszutek
82b39b1012
Rename `newInstrumenter()` into `buildInstrumenter()` ( #6363 )
...
* Rename newInstrumenter() into buildInstrumenter()
* spotless
2022-07-25 12:02:46 -07:00
Mateusz Rzeszutek
d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api ( #5936 )
...
* Merge javaagent-instrumentation-api into javaagent-extension-api
* remove some leftover references to javaagent-instrumentation-api
* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
Mateusz Rzeszutek
50f91e6dee
Deprecate AttributesExtractor#set() method ( #5749 )
...
* Deprecate AttributesExtractor#set() method
* code review comments
2022-04-05 20:20:02 -07:00
Anuraag Agrawal
cd528e98fb
Rename library entrypoints to Telemetry ( #5624 )
...
* Rename library entrypoints to Telemetry
* Renames
2022-03-22 14:39:23 +09:00
Lauri Tulmin
e9c1efece2
Update to Groovy 4 ( #5532 )
...
* Update to Groovy 4
* exclude spock from grails tests, update comment
* Update instrumentation/grails-3.0/javaagent/build.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-03-09 15:07:41 -08:00
Mateusz Rzeszutek
47f2732aae
Split out DbClientAttributesGetter and SqlClientAttributesGetter ( #5354 )
...
* Split out DbClientAttributesGetter and SqlClientAttributesGetter
* code review comments
2022-03-04 09:58:04 -08:00
Mateusz Rzeszutek
551418c283
Refactor AttributesExtractor so that it extracts route from Context ( #5288 )
...
* Refactor AttributesExtractor so that it extracts route from Context
* typo
* fix tests
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpRouteHolder.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* fix all AttributesExtractors
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-02-08 10:38:41 +01:00
Trask Stalnaker
23b33adb0a
Auto-format groovy files in Intellij ( #5260 )
...
* Auto-format groovy files in Intellij
* A bit of clean up
2022-01-28 09:29:46 -08:00
jason plumb
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
Trask Stalnaker
ce4cef76f9
Clean up groovy assertions ( #4805 )
2021-12-05 23:23:58 -08:00
Lauri Tulmin
73a28dadb4
Fail tests on muzzle failre ( #4545 )
2021-11-02 16:06:34 +02:00
Martin
d314d76fce
rename `newBuilder()` to `builder()` ( #4475 )
...
* rename `newBuilder()` to `builder()`
* rename `newBuilder()` to `builder()`
2021-10-22 20:50:43 -07:00
Lauri Tulmin
9b8ab5eeec
Migrate to spock 2 ( #4458 )
...
* Migrate to spock 2
* Fix smoke test suites
* address review comments
* review comment
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-22 08:40:58 -07:00
Trask Stalnaker
1b37df7afd
Move common testing modules to match convention a bit better(?) ( #4451 )
...
* Rename jsf modules to match convention
* Couchbase too
* Mongo too
* Play WS too
* Log4j too
* Elasticsearch too
* JAX-RS too
* JAX-WS sort of
* Spotless
* empty commit
2021-10-21 12:41:28 -07:00
Martin
62c90512cd
switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable` ( #4418 )
2021-10-19 10:59:18 +03:00
Nikita Salnikov-Tarnovski
c119fa1bf6
Remove more usages of checker's Nullable ( #4410 )
2021-10-18 17:32:25 +03:00
Nikita Salnikov-Tarnovski
ae7d48cb07
Convert Mongo to Instrumenter ( #4387 )
...
* Convert Mongo to Instrumenter
* Apply suggestions from code review
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/TracingCommandListener.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Simplify
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-10-18 10:22:00 +03:00
Martin
ac91dc090a
Type annotation placement ( #4406 )
...
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`
* code format
2021-10-17 17:38:43 -07:00
Lauri Tulmin
25491d7d61
Mongo4 strict context check ( #4364 )
...
* Mongo4 strict context check
* Update instrumentation/mongo/mongo-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/mongo/v4_0/AsyncWorkManagerInstrumentation.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-13 13:03:59 -07:00
Lauri Tulmin
344c74a02d
Disable strict context check for mongo4 tests ( #4336 )
...
* Disable strict context check for mongo4 tests
* spotless
2021-10-09 09:54:24 -07:00
Lauri Tulmin
478f936d54
Retry strict context check failures ( #4282 )
2021-10-08 10:47:52 -07:00
Trask Stalnaker
dafc97f96e
Simplify gradle files ( #4292 )
2021-10-04 21:53:35 -07:00
Matthew Ho
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
Trask Stalnaker
20c72f3e98
Format kotlin gradle files ( #3942 )
...
* Add ktlint for kotlinGradle
* ktlint fails on wildcard imports
* Auto-format kotlin gradle files
2021-08-25 13:43:57 +09:00
Trask Stalnaker
c9619c0626
Disable strict context check for elasticsearch 6 tests ( #3917 )
...
* Disable strict context check for elasticsearch 6 tests
* Mongo too
2021-08-23 22:46:04 -07:00
Lauri Tulmin
ff5472a822
Limit number of concurrently running docker tests ( #3664 )
...
* Limit number of concurrently running docker tests
* rename heavy to testcontainers
* use shorter expression
2021-07-27 15:41:39 -07:00
Anuraag Agrawal
e0cb216610
Remove remaining usages of basic span asserts ( #3616 )
2021-07-19 10:09:44 -07:00
Anuraag Agrawal
f5ce4c03f8
Inline basic usages of basicSpan ( #3583 )
...
* Inline basic usages of basicSpan
* spock
2021-07-18 21:15:51 +03:00
Anuraag Agrawal
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
Anuraag Agrawal
3cfa086ffd
Migrate nullaway config to plugin ( #3462 )
2021-07-01 18:13:16 +09:00