jason plumb
55368a52d7
Rename messaging operation "send" to "publish" per spec ( #8929 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-07-12 08:59:38 -07:00
OpenTelemetry Bot
bbb05276be
Update the OpenTelemetry SDK version to 1.27.0 ( #8688 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-06-13 12:02:11 +03:00
Mateusz Rzeszutek
cdb08c9dca
Instrument reactor-kafka ( #8439 )
2023-05-17 17:13:33 -07:00
Lauri Tulmin
f1411d1cb3
Share timer class used by messaging instrumentations ( #8009 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/4514
There is also a slightly different timer class in netty instrumentation
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/netty/netty-common/library/src/main/java/io/opentelemetry/instrumentation/netty/common/internal/Timer.java
that I didn't touch.
2023-03-10 10:40:41 +02:00
Mateusz Rzeszutek
1649a90e29
Add protocol name&version to net attribute getters ( #7994 )
...
In preparation for
https://github.com/open-telemetry/opentelemetry-specification/pull/3272
2023-03-09 11:37:52 +00:00
Mateusz Rzeszutek
998e781009
Remove deprecated messaging.url attribute from messaging getter ( #8008 )
2023-03-09 11:41:51 +01:00
Lauri Tulmin
85c541ef92
Implement kafka client id and consumer id attributes ( #7860 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7771
Adds `messaging.consumer_id` and `messaging.kafka.client_id` attributes
to kafka spans.
2023-02-21 07:31:28 -08:00
Mateusz Rzeszutek
12ea869855
Implement `messaging.kafka.*` attributes spec (part 1) ( #7824 )
...
Part 1 of #7771
It's a lot more than I initially expected it to be; I'll introduce the
clientId attribute in part 2
2023-02-16 13:22:17 -08:00
OpenTelemetry Bot
f074b93110
Update the OpenTelemetry SDK version to 1.23.0 ( #7800 )
...
Update the OpenTelemetry SDK version to `1.23.0`.
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-13 20:22:09 +00:00
Lauri Tulmin
39e7ed4d6a
Second attempt at fixing serializing kafka configuration ( #7789 )
...
Hopefully resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7597
Without reproducing the issue it is hard to tell whether this will help.
Another issue that could arise is that we add our metrics class in
`metric.reporters` property which will probably break if this
configuration is used to build consumer or producer after deserializing
as our classes don't seem to be available there. If this fails we'll
need to ask the issue reporter for instructions how to reproduce and
find a different strategy for fixing this.
2023-02-13 10:47:18 +01:00
Lauri Tulmin
5d182557a1
Ensure kafka configuration remains serializable ( #7754 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7597
I wasn't able to reproduce this. Figuring out how to run beam, flink and
kafka together feels like too much effort. Without reproducing it is too
hard to tell why the configuration is serialized, but my hunch is that
it is enough to ensure that the configuration can be serialized.
2023-02-09 08:45:39 +02:00
Mateusz Rzeszutek
a9c065930d
Return interface instead of concrete implementation in instrumentatio… ( #7658 )
...
…n-api-semconv
We're already doing that for `SpanNameExtractor`, `OperationMetrics`,
`ContextCustomizer`, etc., so I figured we should do the same for
`AttributesExtractor` implementation. Also, none of the implementations
have any additional public surface - aside from the builder/factory
method users can just simply use the interface everywhere.
2023-01-31 13:21:28 +01:00
Mateusz Rzeszutek
e1895e548c
Rename all methods in all Getters to use the `get*()` naming scheme ( #7619 )
...
Resolves #6562
This PR only contains renames; the actual content is in the `*Getter`
interfaces, the rest of changes is just IntelliJ doing its job.
2023-01-23 09:28:11 +00:00
Mateusz Rzeszutek
ebb0141032
Populate `messaging.kafka.message.offset` in all kafka instrumentations ( #7374 )
2022-12-09 17:13:31 -08:00
Johnny Lim
944ee84a3d
Fix typos ( #7044 )
...
This PR fixes typos.
2022-11-04 18:21:32 -07:00
Aaron Ai
3911cacfdc
Fix typos ( #6961 )
2022-10-24 09:06:01 -07:00
Trask Stalnaker
93175522d4
Rename kafka propagation setting and clarify behavior ( #6957 )
2022-10-24 08:49:48 -07:00
Trask Stalnaker
429ecfc713
Update error prone ( #6646 )
...
(note that change from BDDMockito is due to
https://github.com/google/error-prone/issues/3396 )
2022-09-23 11:24:40 -07:00
Mateusz Rzeszutek
c96a49e253
Add kafka client metrics to the javaagent instrumentation ( #6533 )
...
* Add kafka client metrics to the javaagent instrumentation
* Don't override user-set metrics reporter
* Add kafka metric reporter config property
2022-09-12 20:36:14 -07:00
Trask Stalnaker
ae209d9289
Rename ErrorCauseExtractor.jdk() to getDefault() ( #6580 )
...
* Rename ErrorCauseExtractor.jdk() to ErrorCauseExtractor.getDefault()
* jApiCmp
2022-09-12 17:36:34 +03:00
Trask Stalnaker
54c41f7558
Move extractFromRequest() to internal ( #6585 )
...
* Move extractFromRequest() to internal
* Javadoc
2022-09-12 17:36:07 +03:00
Lauri Tulmin
07d7cfd551
Capture messaging header value as span attribute ( #6454 )
...
* Capture messaging header value as span attribute
* add comment
2022-08-11 17:28:04 -07:00
Lauri Tulmin
60c4618a15
Correct pseudocode in comment ( #6464 )
2022-08-11 08:59:36 -07:00
Mateusz Rzeszutek
82b39b1012
Rename `newInstrumenter()` into `buildInstrumenter()` ( #6363 )
...
* Rename newInstrumenter() into buildInstrumenter()
* spotless
2022-07-25 12:02:46 -07:00
Mateusz Rzeszutek
7bbe918008
InstrumentationConfig part 2 ( #6292 )
2022-07-11 09:47:19 +02:00
Mateusz Rzeszutek
e7887ac929
Idea: deprecate `Config`, add agent-only `InstrumentationConfig` ( #6264 )
...
* Idea: deprecate Config, add agent-only InstrumentationConfig
* fix
* fix camel test
* fix external-annotation tests
2022-07-08 16:20:49 +02:00
Lauri Tulmin
646a724a38
Fix kafka metrics latest dep test failure ( #6282 )
2022-07-07 07:46:12 -07:00
jack-berg
3e08f36cfa
Add kafka client metrics ( #6138 )
...
* Add kafka client metrics
* Spotless
* Refactor to general purpose bridge between kafka client metrics and opentelemetry metrics
* Include kafka prefix, fix typo
* Spotless, update readme with latest metric names
* PR feedback
* Map rate measureables to gauges instead of up down counters
* Spotless, quote attributes, log placeholder
* Move metric table printing to test, only retain most granular attribute set
* PR feedback
* Remove synchornization from metricChange
* remove kafka dependency
* PR feedback
* Fix reset
* Adjust configuration pattern to not rely on GlobalOpenTelemetry
* Merge into KafkaTelemetry
* Relocate readme and fix typo
2022-07-06 09:34:14 -07:00
Mateusz Rzeszutek
512a040025
Remove TimeExtractor and use internal API for setting start/end timestamps ( #6051 )
...
* Remove TimeExtractor and use internal API for setting start/end timestamps
* code review comments
2022-05-19 09:03:11 -07:00
Mateusz Rzeszutek
87b412fb40
Instrumentation API changes: OperationMetrics, OperationListener ( #6016 )
...
* Instrumentation API changes: OperationMetrics, OperationListener
* errorprone
2022-05-12 11:16:46 -07:00
Mateusz Rzeszutek
2fad192fc1
Implement vertx-kafka-client instrumentation; batch processing ( #5982 )
...
* Implement vertx-kafka-client instrumentation; batch processing
* try-finally just in case
* Add to supported libraries list
* Update instrumentation/vertx/vertx-kafka-client-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-05-10 12:00:54 +02:00
Mateusz Rzeszutek
7d5555432c
Refactor KafkaInstrumenterFactory a bit ( #5911 )
2022-04-22 08:34:26 -07:00
Mateusz Rzeszutek
28825724db
Spring-kafka single record instrumentation ( #5904 )
2022-04-21 14:42:49 -07:00
Mateusz Rzeszutek
50f91e6dee
Deprecate AttributesExtractor#set() method ( #5749 )
...
* Deprecate AttributesExtractor#set() method
* code review comments
2022-04-05 20:20:02 -07:00
Mateusz Rzeszutek
39e1fcb48e
Rename view and controller suppression config properties ( #5747 )
...
* Rename view and controller suppression config properties
* code review comments
2022-04-05 14:24:24 -07:00
Mateusz Rzeszutek
f0bdce973e
Split out MessagingAttributesGetter ( #5626 )
2022-03-18 11:52:23 -07:00
Mateusz Rzeszutek
4ef6d165a9
Disable the messaging receive span telemetry by default ( #5500 )
...
* Disable the messaging receive span telemetry by default
* fix spring-kafka tests
* remove no longer needed link from the kafka-clients library instrumentation
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-03-07 22:30:40 -08:00
Mateusz Rzeszutek
551418c283
Refactor AttributesExtractor so that it extracts route from Context ( #5288 )
...
* Refactor AttributesExtractor so that it extracts route from Context
* typo
* fix tests
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpRouteHolder.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* fix all AttributesExtractors
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-02-08 10:38:41 +01:00
Trask Stalnaker
1077258263
Add InternalJavadoc custom error prone check ( #5277 )
...
* Add InternalJavadoc custom error prone check
* Add example usage
* Move to conventions
* Revert "Move to conventions"
This reverts commit d8a8209b59
.
* Just get it working
* Clearer error message
* versions
* Apply almost everywhere
* feedback
* Always at the end of javadoc
* Fix test
* Missed (at least) one
* No longer internal
* Fix NPE
* Spotless
* Convert awslambda Java test to JUnit 5 so can reduce visibility
* Reduce visibility
* Rename the check
* More
* Move into errorprone-convention
* Fix UserExcludedClassesConfigurerTest
2022-02-01 17:54:57 -08:00
Trask Stalnaker
6884d66c09
Reduce top level instrumentation directories ( #4965 )
...
* akka
* dropwizard
* kafka
* reactor
* vertx
2021-12-22 10:16:13 -08:00