open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,145 Commits 77 Branches 113 Tags 276 MiB
Commit Graph

57 Commits

Author SHA1 Message Date
Tyler Benson df97f90fec Remove OperationDecorator 2020-04-13 15:55:37 -04:00
Anubhaw Arya 0069c101b3 oops 2020-03-13 11:06:00 -07:00
Anubhaw Arya 0344cff386 Remove hostname and port from HttpClientDecorator 2020-03-13 10:47:10 -07:00
Laplie Anderson 6cd530a541 Move decorators to bootstrap 2020-03-11 18:41:29 -04:00
Tyler Benson 372ba221d2 Invert the classloader matcher to remove the double negative. 2020-03-05 10:14:33 -08:00
Tyler Benson 95534b7bb8
Merge pull request #1283 from DataDog/tyler/classloader-precheck 
Add Classloader precheck to expensive matchers.
 2020-03-03 20:39:39 -08:00
Tyler Benson 7702b0585b Add Classloader precheck to expensive matchers. 
Benchmark results:
```
Benchmark                                                             Mode  Cnt   Score   Error  Units
ClassRetransformingBenchmark.WithAgent.testTracedRetransform          avgt       21.933          ms/op
ClassRetransformingBenchmark.WithAgent.testUntracedRetransform        avgt        6.171          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testTracedRetransform    avgt       22.129          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testUntracedRetransform  avgt        6.517          ms/op
ClassRetransformingBenchmark.testTracedRetransform                    avgt        0.876          ms/op
ClassRetransformingBenchmark.testUntracedRetransform                  avgt        0.867          ms/op
```

I also saw a small improvement in application startup time.
 2020-03-03 10:29:10 -08:00
Nikolay Martynov e92ad38cc8 Tighten up aws instrumentation matcher a bit 2020-03-03 11:45:22 -05:00
Tyler Benson 300c795e72 Remove conversion from URI to String back to URI 
Apply same change as here: https://github.com/open-telemetry/opentelemetry-auto-instr-java/pull/191
 2020-02-27 10:21:06 -08:00
Tyler Benson bd82166b58 Rename methods that don't require disambiguation. 2020-02-24 08:35:19 -08:00
Tyler Benson f70c35842d Move matchers to separate package and split matcher classes out 2020-02-24 08:31:12 -08:00
Nikolay Martynov b6d374e3a0 Avoid calling superclass matcher where possible 
Saves about 100ms of startup time on test app
 2020-02-21 15:08:39 -05:00
Laplie Anderson d45ead1284 split matching into safeExtendsClass and safeHasInterface 2020-02-19 21:22:17 -05:00
Tyler Benson 51bffa2e8a Move agent api classes to bootstrap package so they're not analyzed by muzzle 
Also move jdbc classes to bootstrap to reduce size and complexity of those reference checkers.

These changes reduce the total file size of these instrumentation classes by 635k, which should also result in decent memory savings.
 2020-02-10 15:09:15 -08:00
Tyler Benson 4947dc3bd3 Add various tags for AWS SDK v1.x 
This brings it inline with the v2 instrumentation.
 2020-01-02 13:23:30 -08:00
Trask Stalnaker 1987e86ebf Normalize tag verification order 2019-11-22 10:59:45 -08:00
dougqh 6b096c2240 Replacing Advice.class references 
Replacing Advice.class references with string construction.

This stops the JVM from loading the Advice classes which are used as templates for byte buddy and doesn't ever need to be run directly.

This eliminates ~130 class loads at start-up -- and saves 0.5MiB in metaspace
 2019-11-18 16:09:30 -05:00
Trask Stalnaker 5bf5950bf7 Remove dependency on Tracer 2019-10-24 21:05:01 -07:00
Trask Stalnaker 9182b64078 Switch to new Tags class in tests 2019-10-24 21:04:57 -07:00
Trask Stalnaker 09cdc177cf Update aws-java-sdk-1.11.0 to new agent api 2019-10-19 16:52:39 -07:00
Tyler Benson 95a294a560 Remove common (redundant) dependencies 2019-08-06 14:51:04 -07:00
Tyler Benson 68a68f1057 Ensure that http.url tag doesn’t have query params set 
Make handling of it more consistent in decorator.
 2019-04-26 09:48:34 -07:00
Nikolay Martynov e41769232e Fix AWS instrumentation warning in Idea 
Idea complains about duplicates root because we run latest dep tests
and 'later version' tests from the same dir. This is ultimately
TestSetd plugin bug by the looks of it, but we can work around it by
swapping old and new version tests.

Also run both old and new version tests under 'test' task.
 2019-04-09 10:50:07 -04:00
Tyler Benson 8d96729ae8 Fix instrumentation and add tests to verify. 2019-03-21 18:08:35 -07:00
Nikolay Martynov 3a3705f708 AWS v0: Close span non AWS SDK errors 
Looks like AWS SDK doesn't call interceptor when non-sdk exception
occurs. This leads to leaking open spans. Fix that by instrumenting
http client.

Note: currently has no tests.
 2019-03-21 18:08:35 -07:00
Tyler Benson ca708db5da Remove trace injection into AWS requests 
I don’t think these are helping us and we may still risk messing up the signed request if this happens too late.
 2019-03-12 14:08:27 -07:00
Tyler Benson 50279d64fe Span type should only be an attribute and not inherited 
Previously we were inheriting from the parent and also often setting as a tag.

Apply default span assertion to verify the spanType is being checked properly. (Include error state too.)
 2019-02-28 12:39:51 -08:00
Tyler Benson 2f3f2d4e04
Merge pull request #728 from DataDog/tyler/static-import-decorators 
Rename and static import decorators instance
 2019-02-22 15:51:21 -08:00
Tyler Benson 93e38f6f0d Rename and static import decorators instance 
In the instrumentation it reads better.
 2019-02-22 13:44:34 -08:00
Tyler Benson 7e82f5b197 Remove unnecessary license checker 2019-02-22 13:42:43 -08:00
Tyler Benson f04d113ecb Make decorators public and add tests 2019-02-22 09:42:53 -08:00
Tyler Benson fb304a110d Migrate AWS SDK instrumentation to decorators 2019-02-21 12:11:42 -08:00
Nikolay Martynov 76999fc9f9 Improve AWS1.x SDK integration 
For AWS11.x SDK make sure that http client span is actually a child of
aws span.
 2019-01-24 17:28:03 -05:00
Tyler Benson fe52180bfc Apply proper generic signature for Instrumenter.Default transformers() 
Previously it was missing the MethodDescription portion.
 2019-01-04 15:25:12 -08:00
Tyler Benson 93116e4e12 Avoid downloading so many AWS dependencies for the entire SDK 
Only specify the deps we need for the tests.
 2019-01-04 13:42:51 -08:00
Andrew Kent 91f1bef6f4 Simplify AWS muzzle ranges 
AWS Muzzle workaround is no longer needed with latest muzzle
optimizations.
 2018-11-29 16:18:14 -08:00
Nikolay Martynov 465e237522 Do not set component in AWS instrumentation that later get rewritten anyway 2018-11-15 13:21:49 -05:00
Tyler Benson cbb29069fe Apply component tag more consistently 2018-11-14 11:31:40 -08:00
Tyler Benson 9bd2b86d2e Add assertion to ensure latestDepTest dependencies are different from test. 2018-11-12 08:15:24 -08:00
Gary 21fa1430c8
add comment about choice of version 2018-10-18 09:28:43 -04:00
Gary 796ce20ca6
split muzzle ranges into blocks to avoid OOM in ci 2018-10-18 09:28:41 -04:00
Gary fadf676b6e
Combining AWS instrumentations. Test for both 1.11.0 and 1.11.106 since builder was not available in 1.11.0. 2018-10-18 09:28:39 -04:00
Gary Huang 254f721baf
Muzzle AWS SDK Instrumentation 
Add muzzle blocks and remove class loader matcher methods.
 2018-10-18 09:28:37 -04:00
Tyler Benson 432ce89a07 Add assertTraces to AgentTestRunner with implied argument 
This will also help with auto complete when writing tests.
 2018-10-15 10:19:00 +10:00
Tyler Benson 6fdcfc783a Keep operation name the same 2018-10-01 14:28:14 -04:00
Tyler Benson 8b822ff26d Fix AWS tests and change span type to http-client 
There seems to be a bug.  I would expect the aws span to be the parent of the apache http span, but that is not the case.

Removed the now unused HTTPComponent decorator.
 2018-09-28 21:23:30 -04:00
Tyler Benson 4eb0cd4097 Refactor Apache HttpClient Instrumentation. 
Removes the need for DDTracingClientExec.
Reduces extra spans.
Does not include a span for each redirect.
Compatible with 4.0+ instead of just 4.3+.
 2018-09-28 17:52:39 -04:00
Tyler Benson b3222009ef Stop sending params with AWS traces 
can potentially contain sensitive data.

(See #461)
 2018-09-07 08:55:24 +10:00
Tyler Benson 20993e7e16 Allow tests to run on all JDKs 2018-08-16 14:23:58 +10:00
Tyler Benson e07dfffe5f Migrate tests to new TestHttpServer 2018-08-16 14:23:58 +10:00