Commit Graph

384 Commits

Author SHA1 Message Date
Luca Abbati 2a975b31ee
Adapt test to new DDTracer constructor and unserializable field 2019-05-16 14:35:56 +02:00
Luca Abbati 10069847a3
Define the concept of applicationRootSpanTags and apply only to root
tags
2019-05-16 12:25:43 +02:00
Luca Abbati 0e9f9d9d02
Refactor names of DDSPan's methods to interact with root span
The naming of methods in DDSpan used to detect/retrieve the root span
for a fiven span were slightly misleading. Specifically 'isRootSpan()'
returned true if and only if the span is the root span of teh entire
trace(even in the context of distributed tracing), while getRootSpan()
return the root span of the trace fragment generated by the currently
traced application. I hope that trenaming such methods to
'isTraceRootSpan()' and 'getApplicationRootSpan()' respectively will
help adding some clarity.
The old method names have not been removed for backward comptibility
reasons and tests have been added, but they have been marked as
deprecated.
2019-05-16 11:31:37 +02:00
Luca Abbati 23ffcf0fce
Apply workaround to refresh configuration values during tests 2019-05-15 16:00:14 +02:00
Luca Abbati c8a04b0a4f
Refactor hostname detection in tracer 2019-05-15 13:42:43 +02:00
Luca Abbati 7fd16d1eef
Add tests for hostname detection 2019-05-13 18:31:15 +02:00
Luca Abbati c15ecc8026
Properly format code 2019-05-13 11:48:38 +02:00
Luca Abbati 938740569f
Set the hostname on root spans 2019-05-10 16:12:15 +02:00
Tyler Benson 03f44bd8b9
Merge pull request #807 from DataDog/tyler/exclude-config
Add config allowing classes to be excluded from transformation
2019-04-23 10:37:01 -07:00
Luca Abbati 0d0fa55f21
Sort decorators factory list alphabetically 2019-04-23 11:52:37 +02:00
Tyler Benson ec91a75848 Add config allowing classes to be excluded from transformation
Add the following system property or corresponding environment variable:
```
dd.trace.classes.exclude=some.packagename.*,some.classname.MyClass$NestedClass
```
2019-04-19 10:41:13 -07:00
Luca Abbati 6e825afef2
Move from ForcedSampling tags to standard DDTags based tags 2019-04-19 16:21:35 +02:00
Luca Abbati 6cbdc2005e
Restore erroneously removed getTags method from span context 2019-04-19 10:42:36 +02:00
Luca Abbati 19e9fb83bb
Remove obsolete forced tracing method from span context 2019-04-19 09:20:17 +02:00
Luca Abbati d6a5255e8f
Keep tag decorators count in tests up to date 2019-04-18 14:22:09 +02:00
Luca Abbati fc5b72f86b
Fixed indentations based on google style rules 2019-04-18 13:17:21 +02:00
Luca Abbati 7e157e0561
Move implementation of manual sampling via tag from span to decorators 2019-04-18 13:11:33 +02:00
Luca Abbati 9b705fee2f
Fix code styles errors 2019-04-17 16:46:18 +02:00
Luca Abbati 762930bebd
Run code formatter 2019-04-17 15:19:10 +02:00
Luca Abbati bff7ac8174
Simplify business logic to set force tracing as a tag 2019-04-17 14:39:54 +02:00
Luca Abbati f92e2bbdf6
Rebrand priority sampling while being BC with legacy approach to set it 2019-04-17 14:31:39 +02:00
Tyler Benson a11b888d7a Update ratpack instrumentation and remove default disabled. 2019-04-08 18:26:08 -07:00
Nikolay Martynov de980c2d52
Merge pull request #787 from DataDog/mar-kolya/compiler-config-fix
Mar kolya/compiler config fix
2019-04-01 09:15:39 -04:00
Tyler Benson e4c0175ed0
Merge pull request #785 from DataDog/tyler/pendingtrace-init
Ensure that PendingTrace.SPAN_CLEANER initialized with Tracer
2019-03-29 10:22:07 -07:00
Tyler Benson bc9b96222d Add fixme for future testing task. 2019-03-29 10:03:53 -07:00
Nikolay Martynov 65630a702d Make SpanCleaner initialization explicit 2019-03-29 12:21:17 -04:00
Nikolay Martynov 4c8a790c3b DDTracer: minor javadoc fix 2019-03-29 09:42:52 -04:00
Tyler Benson a9760f24fc Ensure that PendingTrace.SPAN_CLEANER initialized with Tracer
Otherwise it might get initialized by a different classloader which would prevent that classloader from being unloaded.
2019-03-28 11:26:43 -07:00
Masayasu Yamamoto e5c504bceb Fix log message 2019-03-28 22:38:01 +09:00
Tyler Benson 2052647ec9 Fix content length calculation for larger trace counts
Failure to calculate this correctly causes the agent to drop the request.
2019-03-27 15:06:07 -07:00
Tyler Benson f98884235f Review changes. 2019-03-21 08:10:36 -07:00
Tyler Benson 2a49998180 Allow truncation for 128 bit B3 headers.
This is accepted practice in the Zipkin community, so we shouldn’t break this.
2019-03-20 16:02:32 -07:00
Nikolay Martynov 2c5d2ce70d Create TagContext during B3 headers extration 2019-03-20 12:28:39 -07:00
Nikolay Martynov 42cc3594dc Improve injection/extraction styles configuration 2019-03-20 12:28:39 -07:00
Nikolay Martynov 4eb7936245 Implement B3 headers extraction and injection 2019-03-20 12:28:39 -07:00
Tyler Benson 7ffcf5ad4d Change DDAgentWriter to use Disruptor
Serialize payloads as they arrive, send to agent when size exceeds 5MB.

If a flood of traces fills up the RingBuffer, we still count the traces that are discarded for stats reporting.

Do we want to allow configuration of the RingBuffer size?
2019-03-19 09:44:23 -07:00
Nikolay Martynov f3cef4a1e1 Implement HTTP timeout when sending traces to Datadog agent
To ensure we do not pile up traces causing memory overconsumption if agent is slow to respond.
2019-03-15 11:44:19 -07:00
Nikolay Martynov 63e0c0f032 Support Unix Domain Socket proxy to send traces 2019-03-15 11:36:44 -07:00
Tyler Benson 0f07776191 Agent doesn’t like getting floats.
Convert to doubles instead.
2019-03-14 14:36:14 -07:00
Tyler Benson 50279d64fe Span type should only be an attribute and not inherited
Previously we were inheriting from the parent and also often setting as a tag.

Apply default span assertion to verify the spanType is being checked properly. (Include error state too.)
2019-02-28 12:39:51 -08:00
Tyler Benson 99f2d97cd5 review fixes 2019-02-26 08:32:43 -08:00
Tyler Benson a33b6ddaa0 Implement trace origin header and propagation support 2019-02-26 08:26:31 -08:00
Tyler Benson db47fde8d1 Group Elasticsearch instrumentation into common folder
Also migrate to decorator.
2019-02-22 13:28:11 -08:00
Tyler Benson 9c8e689b6d Add decorator for couchbase instrumentation 2019-02-21 15:27:26 -08:00
Tyler Benson 4dd4ee0c05 Trace Analytics Config
Also make the instrumentation names a sorted list so the evaluation order is consistent.
2019-02-20 10:56:14 -08:00
Nikolay Martynov f33600d1f2
Merge pull request #701 from DataDog/mar-kolya/improve-executor-instrumentation
Allow non-wrapped tasks in disabled executors
2019-02-11 12:18:36 -05:00
Nikolay Martynov bae2d7dde8 Allow non-wrapped tasks in disabled executors
Some executors cannot handle tasks that have been wrapped into
`{Runnable,Callable}Wrapper` because they require certain subclass of
`{Callable,Runnable}` in order to work. We have a test that
effectively disables instrumentation for such executors.

This change makes sure that tasks that do not need to be
wrapped (which essentially means anything that is not lambda) still
get traced in such executors. One notable example of affected executor
type is `ScheduledThreadPoolExecutor`.
2019-02-11 11:47:34 -05:00
Tyler Benson 8a4c2815d2
Merge pull request #700 from DataDog/tyler/api-tracer-shutdown
New API: Add shutdown callback to shutdown the Tracer
2019-02-11 08:21:55 -08:00
Nikolay Martynov b672a0fffc Fix ContinuableScope bug when parent span was not closed after scope was closed 2019-02-08 20:13:32 -05:00
Tyler Benson 0e1dce868c Log exceptions from Tracer.finalize() 2019-02-08 11:09:24 -08:00
Tyler Benson 65add99a7b Make shutdown callback weakly reference the tracer.
This should allow finalize to actually be called.  (Also assumes the weak reference isn’t cleared until after finalize is called.)
2019-02-08 11:04:23 -08:00
Tyler Benson 2283040a5b Make internal name usage consistent with setting name. 2019-02-08 10:26:40 -08:00
Nikolay Martynov 931e6ff8af
Merge pull request #688 from DataDog/mar-kolya/webflux-fixes
Fix webflux integration to not rely in active span
2019-02-07 12:45:50 -05:00
Tyler Benson 996c1ce625 invert instanceof check 2019-02-06 08:35:10 -08:00
Tyler Benson 326577d7df Remove codec for inject/extract
In preparation for OT 0.32 support.
2019-02-05 15:07:33 -08:00
Nikolay Martynov 16fe4bd370 Add some debug logging to ContinuableScope 2019-02-05 10:10:49 -05:00
Tyler Benson 03bcdc97cc Move awaitGC to common utility package 2019-01-25 10:32:09 -08:00
Tyler Benson 68d93ce969
Merge pull request #640 from DataDog/tyler/event-sampling
Initial support for setting Event Sample Rate via tags
2019-01-22 08:22:46 -08:00
Nikolay Martynov 2a7cebc311 Add support for partial trace flush
Add a configuration option and logic to flush purtial traces to the
agent if ongoing trace becomes too large.
2019-01-17 09:09:50 -05:00
Tyler Benson bbfcb26cd1 Implement support for setting Event Sample Rate via tags
This only adds the API, no changes to the integrations.
2019-01-04 15:26:12 -08:00
Tyler Benson 82dcc3ce6c
Merge pull request #629 from DataDog/ark/jmx-tagging
Add languages tag to jmx/runtime tags
2018-12-28 09:34:20 -08:00
Tyler Benson 761ea7042a Fix size calculations and improve DDTracerTest 2018-12-27 17:08:46 -08:00
Tyler Benson 8b910b46d1 Update tests for `language` tag in root span 2018-12-27 16:00:47 -08:00
Andrew Kent e9f1436522 Additional continuable-scope tests 2018-12-19 17:12:58 -08:00
Andrew Kent 1ed64da10e Add internal scope listener api 2018-12-19 13:21:07 -08:00
Andrew Kent 5132f0da4b wip: Add languages tag to jmx/runtime tags 2018-12-17 13:32:50 -08:00
Andrew Kent 2dfc3ed465 Do not set the sampler rate for RateByServiceSampler 2018-12-13 08:24:09 -08:00
Andrew Kent 52eaacc929 Enable priority sampling by default 2018-12-12 18:29:08 -08:00
Nikolay Martynov 7728f9918e Remove shutdown hook when DDTracer is shutdown
This is similar to the problem with weak map supplier and may lead to
a memory leak if we created/estroy many DDTracer objects.
2018-12-05 15:02:44 -05:00
Nikolay Martynov 2e8dc9d08f Fix Ratpack tests that got broken by ExecutorInstrumentation refactoring
It turns out closing continuation also closes parent span. This is not
very good in cases when we end up not using continuation if
continuation in a state has already been setup.

This patch provides way to close continuation in a way that doesn't
affect parent scope.
2018-11-29 15:21:46 -08:00
henry-megarry 001c5f7349 implementing add reference to work with opentracing-spring-cloud-starter 2018-11-21 14:27:13 -06:00
Tyler Benson e888b170c4
Merge pull request #582 from DataDog/tyler/servlet-dispatch
Fix servlet async dispatch
2018-11-16 15:06:38 -08:00
Tyler Benson 93c046a664 Add support for DD_TRACE_AGENT_PORT setting
Makes this more consistent with other apm language clients.
2018-11-16 11:09:26 -08:00
Tyler Benson cde02e1ae5 Fix servlet async dispatch
Finish existing trace and propagate to the next request.

Improve dispatch testing.
2018-11-16 08:55:11 -08:00
Andrew Kent d2a8b7fb28 Ensure tracer traceCounter is always shared with DDApi 2018-11-16 08:16:18 -08:00
Nikolay Martynov 1b43a18eb4 Put back DDTracer constructor that got removed 2018-11-15 11:57:42 -05:00
Tyler Benson 188bdf498f Add comments and remove unneeded code. 2018-10-23 16:40:39 +10:00
Tyler Benson a603eee841 Fix issue with saving tags when not propagating trace.
Previously, when setting headers as tags, the tags would only be saved if the request was propagated from another trace.
2018-10-23 16:37:22 +10:00
Nikolay Martynov 34372533c1 Add config for tags that propagate to JMXFetch and spans
Also add runtime-id tag to root span and JMXFetch metrics
2018-10-22 15:51:20 -04:00
Tyler Benson 78c6f881ed
Merge pull request #535 from DataDog/tyler/rabbit
Add instrumentation for RabbitMQ’s AMQP library
2018-10-19 23:26:50 +10:00
Isak W 57f021c631 Add test case for trace/span id serialization 2018-10-18 00:45:23 +02:00
Tyler Benson 8ffeb5bedf Add instrumentation for RabbitMQ’s AMQP library 2018-10-17 16:32:24 +10:00
Isak W 484d54d796 Parse trace/span id as BigInteger rather than letting msgpack parse it 2018-10-16 23:07:50 +02:00
Tyler Benson 432ce89a07 Add assertTraces to AgentTestRunner with implied argument
This will also help with auto complete when writing tests.
2018-10-15 10:19:00 +10:00
Tyler Benson 8b822ff26d Fix AWS tests and change span type to http-client
There seems to be a bug.  I would expect the aws span to be the parent of the apache http span, but that is not the case.

Removed the now unused HTTPComponent decorator.
2018-09-28 21:23:30 -04:00
Tyler Benson 4eb0cd4097 Refactor Apache HttpClient Instrumentation.
Removes the need for DDTracingClientExec.
Reduces extra spans.
Does not include a span for each redirect.
Compatible with 4.0+ instead of just 4.3+.
2018-09-28 17:52:39 -04:00
Nikolay Martynov caa799ddc1 Refactor DDTraceConfig to a Config we can use globally
This would allow us to use same configuration ingrastructure in
different modules. E.g. upcoming JMX.
2018-09-12 17:14:58 -04:00
Andrew Kent 7154b54e10 Rename TracerBridge and Provider 2018-08-27 12:04:26 -07:00
Andrew Kent 9f1d22ea6b Register TracerBridge in TracerInstaller instead of DDTracer init 2018-08-27 12:04:26 -07:00
Andrew Kent e565205d77 TraceInterceptor registration api 2018-08-27 12:04:26 -07:00
Andrew Kent ab14c85fcf
Merge pull request #459 from DataDog/ark/gc-span-closing
gc span closing
2018-08-27 11:57:37 -07:00
Andrew Kent bc105af06f Doc PendingTrace's root span. 2018-08-27 11:33:21 -07:00
Andrew Kent 29b9da5fb1 Add getRootSpan() to MutableSpan 2018-08-27 11:02:29 -07:00
Andrew Kent e0837efb5b Fix remove PendingTrace from span cleaner bug 2018-08-27 10:58:07 -07:00
Andrew Kent 9d4933011e Fix flickering PendingTraceTest 2018-08-27 10:58:07 -07:00
Andrew Kent a6b2e1f27c Don't report traces closed by garbage collection. 2018-08-24 10:13:32 -07:00
Nikolay Martynov c95baef487 Wait for given reference to get GCed in `waitGC`
This should help to make sure that object we are interested in
actually gets GCed.

This change also improves tests for PendingTrace and ScopeManager to
make sure that trace gets cleaned up.
2018-08-21 10:05:10 -04:00
Nikolay Martynov a0036a76cc Add `runFinalization` to `waitForGC` 2018-08-19 00:49:27 -04:00
Tyler Benson e07dfffe5f Migrate tests to new TestHttpServer 2018-08-16 14:23:58 +10:00
Tyler Benson f801cbd466
Merge pull request #428 from DataDog/tyler/use-WeakConcurrentMap
Use WeakConcurrentMap
2018-08-13 16:44:16 +10:00
Tyler Benson b220309a68 PR review changes. 2018-08-10 12:23:13 +10:00
Tyler Benson a3875aff2c Logging improvements and other misc
from reviewing a customer’s logs.
2018-08-09 15:59:59 +10:00
Tyler Benson 847484cd47 Use WeakConcurrentMap
Instead of `Collections.synchronizedMap(new WeakHashMap<>())`.
2018-08-06 14:14:57 +10:00
Nikolay Martynov e517080234 Fix span cleaner executor to use correct span cleaner reference 2018-08-01 14:59:22 -04:00
Nikolay Martynov afc16a0dd5
Merge pull request #418 from DataDog/mar-kolya/ignore-empty-tags-in-config
Ignore empty entries in tags config strings
2018-07-30 23:24:19 -04:00
Tyler Benson 3856e7fd1a http clients 2018-07-31 12:53:50 +10:00
Tyler Benson 561eb0fcd9 Update span types to be consistent with other tracers 2018-07-31 12:40:03 +10:00
Nikolay Martynov db2f3c8e0a Ignore empty entries in tags config strings
Empty tags (or service names) do not make sense. Currently we ignore
whole config line which is too harsh. Instead just ignore a key with
empty value.
2018-07-30 22:32:04 -04:00
Tyler Benson 8dd87a8d30
Merge pull request #415 from DataDog/tyler/resolver-config
Allow DDTracerResolver to be disabled.
2018-07-31 12:24:50 +10:00
Tyler Benson 12e41be258
Merge pull request #416 from DataDog/tyler/contributing
Add contributing document and apply formatting.
2018-07-31 12:24:23 +10:00
Nikolay Martynov b58bf1a2bb
Merge pull request #419 from DataDog/mar-kolya/simplify-default-tags-handling
Simplify default tags handling
2018-07-30 22:19:20 -04:00
Tyler Benson ff9ef671f3 Apply formatter on groovy files. 2018-07-31 12:09:28 +10:00
Tyler Benson 51919a77bb Apply formatter on java files. 2018-07-31 12:07:43 +10:00
Nikolay Martynov 4139af73fa DDTracer: add some asserts into constructor 2018-07-30 21:28:22 -04:00
Nikolay Martynov 2c0702f278 Simplify default tags handling
Remove special case of tags beng empty - it is unlikely to improve
performance but it complicated code unnecessarily.
2018-07-30 21:14:52 -04:00
Tyler Benson f2dbeecdf5
Merge pull request #394 from DataDog/tyler/peer-service
Add support for OT’s `service` and `peer.service` tags
2018-07-31 10:26:22 +10:00
Tyler Benson 2dd62bbab1 Optimization to avoid serialization when logging disabled. 2018-07-31 10:17:05 +10:00
Gary Huang 4c88e1a0a8
Merge pull request #392 from DataDog/gary/uint64-id-support
Change the internal storage and handling of trace ID, span ID, and pa…
2018-07-30 15:01:10 -04:00
Tyler Benson d3e0323b04 Allow DDTracerResolver to be disabled. 2018-07-30 15:17:27 +10:00
Tyler Benson 4e60246e17
Merge pull request #405 from DataDog/tyler/servlet-async
Refactor servlet instrumentation and disable async on response.
2018-07-30 10:27:54 +10:00
Gary Huang 0d9a461b87 Add NumberFormatException as cause to IllegalArgumentException if extracted ID is not a number. Also change uint64 max BigInteger initialization to be more readable. 2018-07-26 11:26:56 -04:00
Gary Huang 6317b21d5c Fix merge conflicts with service mapping change 2018-07-26 09:16:41 -04:00
Tyler Benson 2651dec616 Add support for OT’s `service` and `peer.service` tags
Sets DD’s `service.name` on the span.
2018-07-26 16:29:04 +10:00
Tyler Benson 1e36343485 Null or empty tags should remove previously set values.
Add context to servlet2 test.

Clean up some declared tracers that mess up the classpath.
2018-07-26 12:20:37 +10:00
Tyler Benson 5fe08d20fc Only apply service name mapping on finish
If done in the decorator, it would be applied twice.  Only want it done once.
2018-07-25 14:58:55 +10:00
Gary Huang 93e70dcef6 Address comments and add test case for extracting non numeric IDs 2018-07-24 14:04:52 -04:00
Tyler Benson 7807615605 This actually must be done at the span finish, rather than creation.
Otherwise the context decorator doesn’t know if it should change the span name or not.
2018-07-23 13:59:01 +10:00
Tyler Benson de5d108afc Allow service name mapping to apply without setting the tag.
Previously the mapping only applied when the `service.name` tag was set, not on the default or configured service name.
2018-07-23 13:46:48 +10:00
Gary Huang 96f79a8aba Change the internal storage and handling of trace ID, span ID, and parent IDs' to use String instead of long primitive.
This will allow the java agent to receive unsigned 64 bit integers without overflow.

Also upgraded MsgPack to handle the serialization of such Strings as numbers in JSONs.
2018-07-20 17:19:04 -04:00
Tyler Benson 12a2fce96d Upgrade java formatter version. 2018-07-19 14:10:53 +10:00
Andrew Kent 4401779aad Fix priority sampling implementation bugs
- use correct sampling flag name
- set sampling rate
- set sampling flags on root span metrics only
- tests to assert correct behavior
2018-06-26 10:19:28 -07:00
Andrew Kent 224f65a0c2 rootSpan hack for PendingTrace 2018-06-26 10:19:28 -07:00
Nikolay Martynov 088402beed
Merge pull request #358 from DataDog/mar-kolya/fix-span-time-boundaries-poc
Fix span time boundaries
2018-06-26 12:48:49 -04:00
Tyler Benson 17c2f28947 Upgrade to gradle 4.8.1 2018-06-26 10:33:35 +10:00
Nikolay Martynov d50154f159 PendingTrace: add a TODO to move time fields into DDTracer 2018-06-25 09:28:01 -04:00
Nikolay Martynov 2bdf54bd6e Fix span start boundaries
Before: span start had millisecond precision because we just use
`currentTimeMillis` to get span start time.

This creates weirdly looking traces where spans 'fly' way out of
parent spans if they have sub-ms length.

After: we establish 'trace start time' with millisecond precision and
measure all span start and stop times from that. This means all
relative times are maintained with nanosecond precision (or whateve OS
clock fives us).

This is POC and some things are not yet fixed. E.g. JMS1
instrumentation injects time into span manually - and it is not
apparent how to pake it do so relative to trace clock.

Note: going forward this should allow us to completely get rid of
'double time keeping' we currently have in `DDSpan`.
2018-06-22 17:17:53 -04:00
Nikolay Martynov d3aa982082 Add tests for OTTraceCorrelation 2018-06-18 17:57:02 -04:00
Andrew Kent 519f15bcc6
Merge pull request #357 from DataDog/ark/servlet-async
Close scope for async servlet requests
2018-06-17 23:44:24 -07:00
Nikolay Martynov f9cc33c7c8
Merge pull request #353 from DataDog/mar-kolya/spymemcached-instrumentation
Mar kolya/spymemcached instrumentation
2018-06-15 12:44:42 -04:00
Andrew Kent 6cd8be67d5 Close scope for async servlet requests 2018-06-14 20:23:54 -07:00
Andrew Kent f28445c45f CorrelationIdentifier for MDC frameworks. 2018-06-14 15:33:15 -07:00
Nikolay Martynov 1e4c88ffcb Merge branch 'master' into mar-kolya/spymemcached-instrumentation 2018-06-14 15:38:01 -04:00
Nikolay Martynov ba37ccc552 Spymemcached: use cache span type 2018-06-14 13:37:35 -04:00
Tyler Benson ff56389a56 Upgrade some versions. 2018-06-14 11:56:56 +10:00
Gary Huang e89cbd0bb1 set span cleaner threads to be daemon threads so that applications can exit without explicit exit statement. 2018-06-07 17:09:59 -04:00
Tyler Benson d235618a6e Add instrumentation for Java’s UrlConnection
For HttpUrlConnection, trace propagation headers are added to the outgoing request.

Due to the awkward design of the API, the ability to instrument in a natural way was limited, thus the main points instrumented are the get{Input,Output}Stream methods.
2018-06-06 09:12:48 +10:00
Tyler Benson de74eb1938 Add additional metadata to ES client calls. 2018-05-25 13:58:44 +10:00
Tyler Benson 0cf8fef8d8 Elasticsearch Instrumentation 2018-05-23 11:29:13 +10:00
Tyler Benson 024d414844 Move Apache HttpClient tests to instrumentation
And add latest test.
2018-05-18 12:01:12 +10:00
Tyler Benson 69ee39bfc2
Merge pull request #317 from DataDog/tyler/tagged-headers
Add setting for collecting headers as tags during extraction
2018-05-15 10:43:54 +10:00
Tyler Benson c011eb0fbd
Merge pull request #320 from DataDog/tyler/servlet-context-naming
Name service based on servlet context
2018-05-15 10:27:06 +10:00
Tyler Benson dc814aeb6d Fix tests. 2018-05-11 15:19:30 +10:00
Tyler Benson 6767785e0f Try cleaning more than once in test. 2018-05-11 14:27:44 +10:00
Tyler Benson 46878d24d3 Name service based on servlet context
This only applies if a service name hasn’t been set or is empty.

This is particularly useful for environments that deploy multiple war files to the same app server.
2018-05-11 13:59:03 +10:00
Tyler Benson 97b3e537bd Add shutdown hook to span-cleaner thread 2018-05-11 13:55:05 +10:00
Tyler Benson 891b46f0d1 Add setting for collecting headers as tags during extraction 2018-05-11 09:32:07 +10:00
Tyler Benson d5d24c50c7 Replace @Unroll’s with a rule to always unroll. 2018-05-10 15:24:59 +10:00
Tyler Benson 2595ca5128 Refactor decorators and add service name mapping 2018-05-08 16:13:48 +10:00
Tyler Benson 9a52303376 Apply jacoco to every java project
Some projects have ignores/whitelists, but generally coverage is pretty high.

AFAIK, this doesn’t really capture instrumentation test coverage though.
2018-05-04 16:23:32 +10:00
Tyler Benson f35e2e6ebe Remove various warnings and other cleanup
Also upgrade some plugins.
2018-05-04 14:05:06 +10:00
Tyler Benson 3fa0eb0296 Remove dependency on guava for dd-trace-ot 2018-05-03 16:11:15 +10:00
Tyler Benson 63d308e50d Misc cleanup/minor changes 2018-05-01 10:24:14 +10:00
Tyler Benson cd289308bb Remove timeouts.
Not helping as much as was hoped.  Causing extra noise in CI.
2018-04-30 11:10:18 +10:00
Tyler Benson 3db2d654f1 Fix spark instrumentation
and rebase off master.
2018-04-26 17:01:45 +10:00
Andrew Kent 64ce961c32 Debug logs for hot paths 2018-04-23 11:06:45 -07:00
Andrew Kent c3feb3b878
Merge pull request #290 from DataDog/ark/pending_expire
Handle spans registered after trace is written
2018-04-23 10:00:38 -07:00
Andrew Kent bb69666e9f Handle spans registered after trace is written
Decrement the pending trace count when spans are registered after a
trace writes. Log certain pending trace messages at debug.
2018-04-18 12:37:14 -07:00
Tyler Benson e7604bfd3f Report X-Datadog-Trace-Count header with traces
Also remove unused services endpoint code.
2018-04-18 10:27:51 +08:00
Andrew Kent c7cf1cf36d
Merge pull request #282 from DataDog/ark/async-refactor
Toggleable Async Propgation on the trace context
2018-04-17 09:44:41 -07:00
Andrew Kent 5f5d654a4c
Merge pull request #288 from DataDog/ark/agent_priority_sampling
Move PrioritySampling flags to dd-trace-api project
2018-04-17 09:26:45 -07:00
Andrew Kent 32272a4aa7 Move PrioritySampling flags to dd-trace-api project. 2018-04-16 12:46:26 -07:00
Andrew Kent 364b3e999a Remove warning from mongo listener. Add injection debug logging. 2018-04-16 10:34:46 -07:00
Andrew Kent 03b96ca567 Increase agent writer max trace limit 2018-04-11 14:35:30 -07:00
Andrew Kent d594d6e8db Don't create continuations when async propagation is off 2018-04-11 13:32:58 -07:00
Andrew Kent a0a11a51d0 Use ScopeManager to enable/disable low level async instrumentation. 2018-04-11 13:32:58 -07:00
Andrew Kent 0d7aa022db Refactor ContinuableScope 2018-04-11 13:32:58 -07:00
Andrew Kent 01c707787f Fix name: timestampMillis -> timestampMicroseconds 2018-04-10 16:53:58 -07:00
Tyler Benson f05ddaa19d
Merge pull request #283 from DataDog/tyler/span-times
Add startTime and Duration methods to MutableSpan interface
2018-04-09 23:46:23 +08:00
Tyler Benson fcb1e1c564 Add startTime and Duration methods to MutableSpan interface 2018-04-09 23:25:35 +08:00
Tyler Benson 79a9826863 Add the errorprone compiler. 2018-04-04 20:48:28 +08:00
Tyler Benson 5a61124cae Add tests against an actual trace agent. 2018-03-28 22:31:15 +08:00
Tyler Benson 19b94da7bb JAX-RS Client Tracing 2018-03-20 08:54:09 +08:00
Andrew Kent 783a6d88e2 Increase Test timeouts 2018-03-15 13:23:57 -07:00
Andrew Kent 10e12a666a Use builtin decorators for every DDTracer 2018-03-13 12:46:48 -07:00
Andrew Kent b5b38ee4b1 Mark all http status codes 5xx as an error. 2018-03-13 12:46:48 -07:00
Tyler Benson 0fbec69b6d
Merge pull request #253 from DataDog/tyler/traceinterceptor
Implement the TraceInterceptor API
2018-03-13 08:30:01 +10:00
Andrew Kent 428e304164 Rename ContextPropagator to TraceScope 2018-03-12 10:29:50 -07:00
Andrew Kent 21180530ea Remove opentracing from dd-trace-api 2018-03-09 11:50:39 -08:00
Andrew Kent 9a83413141 Executor Instrumentation for Scala 2018-03-09 11:50:39 -08:00
Tyler Benson 286e9d2d00 Add instrumentation to catch additional classloaders.
Still doesn’t work with Spring Boot because the way they structure their Jars.
2018-03-09 14:32:41 +10:00
Tyler Benson d073cd8a17 Initial pass at TraceInterceptor API 2018-03-09 14:32:41 +10:00
Tyler Benson f57faba5db Allow closing of continuation explicitly
to allow a completed trace to be reported more timely.
Continuation is closed when the returned scope is closed, but can also be closed directly.
2018-03-09 14:31:48 +10:00
Tyler Benson 087b2e7298 Fix tests 2018-03-09 14:31:48 +10:00
Tyler Benson 5c3e4c91fd Rename to PendingTrace 2018-03-09 14:31:48 +10:00
Tyler Benson 2b1c9aabfb Force traces to wait Continuation dereferencing before reporting
If all the current spans on a trace complete before a continuation can be activated, previously the trace could have been reported, not allowing additional spans to be added.

This PR changes it so any created continuations must be dereferenced (GC’d) before allowing the trace to be reported.
2018-03-09 14:31:48 +10:00
Tyler Benson c99f10c0d2 Decouple trace flush from collection
Wait until all spans are finished or garbage collected before reporting trace.
2018-03-09 14:31:48 +10:00
Tyler Benson 5cbc11415d Move SpanFactory to correct package. 2018-03-09 14:31:48 +10:00
Tyler Benson f31632be33 Remove deprecated usage. 2018-03-09 14:31:48 +10:00
Tyler Benson 5d1297f125 Extract a trace out to a specific class
Rather than it just be a list of spans…
This allows for tracking of if the trace was reported or not, and in the future to do so independently of finishing the span.
2018-03-09 14:31:48 +10:00
Tyler Benson 8da3a0492d Improve threadsafety and organization 2018-03-09 14:31:48 +10:00