00612c3406
Bump cglib from 3.2.5 to 3.3.0 ( #7327 )
2022-11-28 15:24:06 -08:00
05471b053b
Webflux instrumentation fix ( #7251 )
...
When a webflux filter is added which throws an exception, the
instrumentation does not currently capture the `http.status_code`.
The fix is to move `WebClientTracingFilter` from the first to the last
filter in the chain, which I think(?) is the general strategy we've
taken for other client instrumentation, e.g. so that if a filter makes
another http call it won't be suppressed.
I don't love the test coverage I added, so let me know if you have any
better suggestions?
EDIT: btw, I did archaeology to confirm that behavior (adding to the
beginning of the chain) has been in place since the webflux
instrumentation was added originally
6f472a62a0 (diff-493ad89b5bde807c90387aa2bb67eb10d3bcef6b6a388bd31e11796a6d01ac38R36)
2022-11-22 15:09:22 -08:00
95ec4a8c1f
HTTP semconv: filter out default peer/host ports ( #7258 )
...
After a loooong break, the next part of the HTTP semconv implementation:
filtering out default HTTP ports, client and server.
> [5]: If not default (80 for http scheme, 443 for https).
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client
2022-11-22 17:14:20 +00:00
2d7395c44b
Introduce markdown lint check ( #7175 )
...
Fixes #7129
2022-11-16 20:48:42 -08:00
5345c87680
End groovy files with newline ( #7127 )
2022-11-10 12:21:55 +01:00
b0012b083b
okhttp: run our interceptor before other interceptors ( #6997 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6909
If our interceptor runs before other interceptors then other
interceptors replacing the request won't affect our interceptor.
2022-10-27 12:45:02 -07:00
3911cacfdc
Fix typos ( #6961 )
2022-10-24 09:06:01 -07:00
f6766c7433
Remove unused test option ( #6950 )
2022-10-23 18:48:03 +00:00
94e2248940
Use new semantic attribute constants ( #6946 )
2022-10-23 09:32:03 -07:00
9ce68fb937
Fix metric units ( #6931 )
...
Follow-up to #6930
2022-10-22 10:00:48 -07:00
f488d94403
Capture net.host.name for netty ( #6892 )
...
This may be a regression in 1.19.0 because you can no longer reconstruct
the original url for netty server spans (previously `http.host` was
captured which could be used).
2022-10-19 09:21:50 -07:00
aeac361816
Upgrade to otel java 1.19.0 ( #6757 )
...
Working PR to capture all the changes required to update to otel java
1.19.0. The new log API force allows
`:instrumentation-appender-api-internal` and
`:instrumentation-appender-sdk-internal`, but necessitates a decent
amount of refactoring as a result.
The PR points at the `1.19.0-SNAPSHOT`, which I'll update upon
publication.
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-10-12 09:19:37 -07:00
891ec8c491
Rename restlet-1.0 to restlet-1.1 ( #6814 )
2022-10-06 08:49:55 -07:00
0d32150059
Assert on instrumentation version ( #6773 )
...
To catch issues like #6770
2022-09-29 10:53:10 +03:00
714ba9189e
Remove deprecated `http.host` and `http.server_name` attributes ( #6709 )
...
... and make sure the `TemporaryMetricsView` follows the current spec
2022-09-24 11:02:21 -07:00
429ecfc713
Update error prone ( #6646 )
...
(note that change from BDDMockito is due to
https://github.com/google/error-prone/issues/3396 )
2022-09-23 11:24:40 -07:00
97bc4a4fda
Reactor instrumentation: do not make root context current ( #6593 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-14 11:23:18 -07:00
ec3ba77101
Convert logback test to Java ( #6613 )
2022-09-14 10:58:59 -07:00
c0b0722699
Some assertions refactoring ( #6618 )
2022-09-14 08:24:27 -07:00
cfdbe758f2
Net attributes getters changes (in preparation for HTTP spec impl) ( #6503 )
...
* Net attributes getters changes: instrumentation-api-semconv changes
* Net attributes getters changes: getter implementations
* Net attributes getters changes: test fixes
* Remove net.sock.host.name
* code review comments
* default getter methods & getPeerSocketAddress() method name
* set authority in grpc earlier
2022-09-12 09:20:27 -07:00
af61a8b578
Update to otel 1.18.0 ( #6575 )
2022-09-11 10:35:05 -07:00
c04a6a3471
Don't bundle slf4j-api inside testing-commons ( #6520 )
2022-08-30 00:04:26 +03:00
33d2e40a9e
Fix flaky kafka metrics test ( #6511 )
2022-08-25 15:22:38 -07:00
a83e6ca652
Refactor OkHttp tests to Java ( #6484 )
...
* Refactor OkHttp tests to Java
* throws Exception
2022-08-24 09:18:15 -07:00
f1774cabe2
Update net semantic convention changes ( #6268 )
...
* New net conventions: option a
* Feedback + sock.family + sock.peer.name
* peer.service + tests
* server net attributes attempt 1
* server net attributes attempt 2
* Javadoc
* Revisions
* Apply to instrumentations
* Feedback
* One more default method
* Spotless
* Fix javadoc
2022-08-18 09:02:23 -07:00
faa99b2eeb
Update SDK to 1.17.0 ( #6467 )
...
* Update SDK to 1.17.0
* Fix
* Update licenses
* Spotless
* license
2022-08-12 17:10:46 -07:00
08f013f9d6
Update gradle to 7.5.1 ( #6359 )
...
* Update gradle to 7.5
* Bump to 7.5.1
* gradle 7.5.1 with jdk17
* spotless
* one more --add-opens
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-08-12 12:03:43 +02:00
b2c90c79b5
Extract HTTP request & response content length from headers ( #6415 )
...
* Extract HTTP request & response content length from headers
* remove unused method
* fix camel tests
* fix google http client tests
* fix HttpUrlConnection tests
* fix k8s and jaxrs tests
* fix aws tests
* actually fix aws tests 🤞
* fix elasticsearch tests
* fix ratpack tests
* fix spring webflux tests
* fix vertx tests
* fix reactor netty tests
2022-08-05 10:55:47 -07:00
c3c4fb7101
Finish annotation move ( #6386 )
...
* Update tests with new annotation
* more
* Fix build
* More
2022-08-01 09:19:58 -07:00
82b39b1012
Rename `newInstrumenter()` into `buildInstrumenter()` ( #6363 )
...
* Rename newInstrumenter() into buildInstrumenter()
* spotless
2022-07-25 12:02:46 -07:00
701ed54311
Use "class loader" instead of "classloader" consistently in docs and comments ( #6236 )
...
* Use "class loader" consistently instead of classloader
* Java comments too
* Fix bad merge
2022-06-30 14:57:07 -07:00
8fac01e736
Enable error prone's UnusedVariable check ( #6217 )
...
* Enable error prone's UnusedVariable check
* Spotless
2022-06-27 10:55:27 +02:00
ba912bc382
Implement C3P0 connection pool metrics ( #6174 )
...
* C3P0 connection pool metrics
* Use PooledDataSource instead of specific implementation
* Add C3P0 readme
* RuntimeException in case of underlying SQLException
* Use ISE instead of RuntimeException
2022-06-20 14:21:54 +03:00
91dcad68bd
Run tests with play 2.4 ( #6145 )
...
* Run tests with play 2.4
* restore comment
2022-06-14 12:10:53 +03:00
157ab7f754
Implement Oracle UCP connection pool metrics ( #6099 )
...
* Implement Oracle UCP connection pool metrics
* add additional instrumentation name
* change asserting no metrics reported after shutdown
2022-06-02 22:47:04 -07:00
30710ba294
Refactor DbConnectionPoolMetricsAssertions ( #6101 )
...
* refactor the DbConnectionPoolMetricsAssertions for improved readability and code reuse
* Middle ground option
* factor out duplicate verification
* address PR comments.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-06-02 12:47:02 -07:00
b95b64ba88
Implement Vibur DBCP connection pool metrics ( #6092 )
...
* Implement Vibur DBCP connection pool metrics
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* address review comments
* don't check for metircs that aren't reported
* rework library test setup
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-05-26 11:26:02 +03:00
beb00cd03e
Ignore span oder in flaky test ( #6060 )
...
* Ignore span oder for http client connectionErrorUnopenedPortWithCallback test on jdk8
* fix spelling
2022-05-18 11:15:41 -07:00
5bcab32379
Implement HikariCP connection pool metrics ( #6003 )
...
* Implement HikariCP connection pool metrics
* rebase after SDK update
* fix muzzle
* code review comments
2022-05-12 18:48:07 -07:00
6a0ca530b7
Instrumentation API changes: VirtualField ( #6017 )
...
* Instrumentation API changes: VirtualField
* change class name in string constant
2022-05-12 11:17:24 -07:00
d1ee692479
Update to OTel 1.14 ( #5999 )
...
* Update to OTel 1.14
* Fix test
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-05-10 14:23:56 -07:00
2fad192fc1
Implement vertx-kafka-client instrumentation; batch processing ( #5982 )
...
* Implement vertx-kafka-client instrumentation; batch processing
* try-finally just in case
* Add to supported libraries list
* Update instrumentation/vertx/vertx-kafka-client-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-05-10 12:00:54 +02:00
d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api ( #5936 )
...
* Merge javaagent-instrumentation-api into javaagent-extension-api
* remove some leftover references to javaagent-instrumentation-api
* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
a45ee01259
Test latest version of akka-http ( #5945 )
...
* Test latest version of akka-http
* checkstyle
* spotless
2022-04-28 15:08:58 +03:00
f2714ad021
Small consistency ( #5931 )
2022-04-25 15:06:38 -07:00
6fe3299f52
Add metric support for grpc ( #5923 )
...
* Add metric support for grpc
* Spotless
2022-04-25 10:36:26 -07:00
1345a6665e
Test spring-kafka instrumentation with receive telemetry disabled ( #5913 )
...
* Test spring-kafka instrumentation with receive telemetry disabled
* checkstyle and code review comment
2022-04-25 15:56:55 +02:00
4e3f19d469
Enable span suppression by SpanKey by default ( #5779 )
...
* Enable span suppression by SpanKey by default
* fix HTTP tests (probably)
* add exception for camel
* remove suppression tests from @WithSpan instrumentations
* remove suppression tests from @WithSpan instrumentation; spring boot autoconfigure
* fix twilio tests
* fix netty-based HTTP clients, remove AWS SDK 1.11 unit test
* fix elasticsearch tests
* codenarc
* spotless
* fix AWS SDK 1.11 tests
* remove a TODO
* code review comments
* fix merge conflict
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-04-19 14:13:09 -07:00
4d34d90437
Do not set the http.route attribute in JSF instrumentations by default ( #5819 )
...
* Do not set the http.route attribute in JSF instrumentations by default
* code review comments
2022-04-14 09:07:05 -07:00
e58d39d4ad
Update to OTel 1.13 ( #5799 )
...
* Update to OTel 1.13
* Fix test
* Foo
* Fix app server test and start yak shaving
* Yak
* Yak
* groovy fail
* Yak
* GROOVY
* yak farm
2022-04-13 13:16:32 +03:00
dependabot[bot]
Trask Stalnaker
Mateusz Rzeszutek
Aaron Ai
Lauri Tulmin
jack-berg
Liudmila Molkova
Ago Allikmaa
jason plumb
Anuraag Agrawal