Anuraag Agrawal
3cfa086ffd
Migrate nullaway config to plugin ( #3462 )
2021-07-01 18:13:16 +09:00
Anuraag Agrawal
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
Anuraag Agrawal
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
Lauri Tulmin
ce36486992
Fix armeria latest dep tests ( #3407 )
2021-06-25 09:50:35 +09:00
Anuraag Agrawal
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
Mateusz Rzeszutek
256f2c992e
Fix PeerServiceAttributesExtractor#createUsingReflection() ( #3378 )
...
* Fix PeerServiceAttributesExtractor#createUsingReflection()
* move armeria & grpc NetAttributesExtractors to internal package
2021-06-23 18:25:35 +09:00
Anuraag Agrawal
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
Mateusz Rzeszutek
2f528e4166
Rename *Instrumenters to *Singletons ( #3335 )
2021-06-16 10:12:37 -07:00
Anuraag Agrawal
b7bfbf0cc6
Migrate instrumentation-library / common to plugins ( #3320 )
2021-06-15 11:54:48 -07:00
Anuraag Agrawal
224dc51e93
Migrate java.gradle to conventions plugin ( #3289 )
...
* Migrate java.gradle to convention plugin.
* Switch to java-conventions
* Remove old file
* Fix
* Fix merge
* Missing paragraph
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-15 08:10:39 +09:00
Trask Stalnaker
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
Trask Stalnaker
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
Trask Stalnaker
f7a24b0e4b
Update asynchttpclient-2.0 to Instrumenter API ( #3211 )
...
* Update asynchttpclient-2.0 to Instrumenter API
* Fix play-2.4 tests
2021-06-11 12:41:25 -07:00
Trask Stalnaker
a78ed4c420
Rename some extractor request/response params ( #3202 )
2021-06-07 11:41:47 -07:00
Trask Stalnaker
ac30b3c185
Add SuppressWarnings("unused") on Advice classes ( #3207 )
...
* Add SuppressWarnings unused on Advice classes
* And in doc
2021-06-07 16:00:21 +09:00
Trask Stalnaker
f9dcd03b4b
Rename unused try-with-resources scope variables ( #3201 )
2021-06-07 11:41:50 +09:00
Mateusz Rzeszutek
e1762677da
Refactor HttpClientTest ( #3159 )
...
* Remove unused extraClientSpans() method
* Merge extraAttributes() and hasClientSpanHttpAttributes(uri) into
httpAttributes(uri): this will allow to choose extracted attributes
per URI (for example, OkHttp won't set flavor on connection exception
once it's rewritten to Instrumenter)
2021-06-03 10:54:01 +09:00
Anuraag Agrawal
c3dedbb64e
Enable all errorprone checks ( #3155 )
...
* Enable all errorprone checks
* Fixes
* Finish
* Finish
* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
Lauri Tulmin
32e28c1b1e
Propagate context to armeria callbacks ( #3108 )
2021-05-28 15:01:31 -07:00
Anuraag Agrawal
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
Anuraag Agrawal
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
Mateusz Rzeszutek
d755654c29
[WIP] Add peer.service to Instrumenter API ( #3050 )
...
* [WIP] Add peer.service to Instrumenter API
* Move PeerServiceAttributesExtractor to javaagent-api and use reflection to add it
* Finish PeerServiceAttributesExtractor
* Fix tests
* Add peer.service to apache-httpclient-5.0, jedis-1.4, lettuce-4.0
2021-05-25 15:31:41 +02:00
Trask Stalnaker
1583683aec
Add Nullable to Instrumenter API response args ( #3041 )
2021-05-24 09:14:48 -07:00
Trask Stalnaker
f11bd75710
Don't use singleton for propagator getters/setters ( #3054 )
2021-05-21 11:48:54 -07:00
Trask Stalnaker
329233e576
Change a couple of Longs to Integers in Instrumenter API ( #3043 )
2021-05-20 14:33:22 -07:00
Trask Stalnaker
d1946f6774
Don't use type annotation style ( #3023 )
2021-05-18 10:23:09 -07:00
Mateusz Rzeszutek
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
Anuraag Agrawal
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
Anuraag Agrawal
057d8861fa
Record HTTP server metrics in instrumenter API. ( #2877 )
...
* Record HTTP server metrics in instrumenter API.
* Fix
* Response attributes
* Start cleaning
* Docs
* Test
* Finish test
* Cleanups
* Cleanups
2021-05-12 17:49:12 +09:00
Trask Stalnaker
10db083e77
Update to OTel API/SDK 1.2.0 ( #2945 )
...
* Update to OTel API/SDK 1.2.0
* TCP.IP -> tcp_ip
* Fix smoke tests
2021-05-10 10:14:07 -07:00
Trask Stalnaker
cd3dd581f9
Fix some remote connection tests ( #2933 )
2021-05-10 12:19:39 +09:00
Mateusz Rzeszutek
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
Mateusz Rzeszutek
c9a3793bf8
Instrumenter API improvements ( #2860 )
...
* Instrumenter API improvements
* Move HTTP & net classes to separate packages
* Remove `db` prefix from method names in `DbAttributesExtractor`
* Add request-only net attributes extractor (it'll be needed in spring-sleuth-otel once we decide to use Instrumenters there)
* One NetAttributesExtractor class, javadocs
* add missing @Nullable
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-06 11:35:38 +02:00
Trask Stalnaker
2ab92f556e
Fix duplicate http client tracing headers ( #2842 )
...
* Fix duplicate spring webclient tracing headers
* Fix Akka Http
* Fix Armeria
* Fix Java 11 Http Client
* Fix OkHttp 2.2
* Fix PlayWS
2021-04-23 13:05:10 -07:00
Trask Stalnaker
1824e36b96
Better server span name for Grails and Wicket ( #2814 )
2021-04-22 14:16:54 -07:00
Lauri Tulmin
9464134ffd
Test failing async http request ( #2812 )
2021-04-19 14:11:27 -07:00
Trask Stalnaker
9bd028f767
Remove unnecessary genericness ( #2797 )
2021-04-14 00:01:28 -07:00
Trask Stalnaker
3bc058b10b
Don't create duplicate headers ( #2727 )
...
* Test infra
* Update examples
* Update instrumentation
* Update tests
* jaxrs-client fixes
* Remove doRequest/doReusedRequest
* Fix muzzle
* some fixes
* fix test
* doc
* not private
* Apply to doRequestWithCallback also
* Update doc
* groovy
* better
* Don't hardcode traceparent
* Reuse request in SpringRestTemplateTest
2021-04-12 12:21:16 +03:00
Anuraag Agrawal
d8f6018ba6
Split HttpClientTest execution methods for sync and callback ( #2675 )
2021-04-06 15:26:01 -07:00
Anuraag Agrawal
cc47da585b
New Instrumenter API ( #2596 )
...
* Instrumenter
* Spotless
* More instrumenter
* More
* Instrumenter API
* New Instrumenter API - InstrumenterBuilder (#20 )
* New Instrumenter API - InstrumenterBuilder
* New Instrumenter API - InstrumenterBuilder - code review comments
* Start doccing
* Docs
* Most tests
* Last test
* Stick with current hostName lookup for now
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* New Instrumenter API - code review comments (#21 )
* Doc
* Checkstyle
* Cleanups
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-04-05 15:45:07 +09:00
Mateusz Rzeszutek
1406855bb7
Revert "Prevent duplicate telemetry when using both library and auto instrumentation ( #2661 )" ( #2689 )
2021-04-01 16:11:15 -07:00
Mateusz Rzeszutek
30434696ae
Prevent duplicate telemetry when using both library and auto instrumentation ( #2661 )
...
* Prevent duplicate telemetry when using both library and auto instrumentation
* Add unit test
* Fix Oshi tests
* Fix couchbase 3.1 tests
2021-03-31 10:57:04 -07:00
Trask Stalnaker
0d11dbe565
Fix webflux client filter subscribe ( #2646 )
...
* Fix webflux client filter subscribe
* Add test
* Fix test
* Fix test, take 2
* Fix another test
* Suppress test for another module
* Suppress another library instrumentation
* Another
* Add nested client suppression in Armeria
* Add comments
* Revert extra line
2021-03-31 07:54:41 +03:00
Mateusz Rzeszutek
ae23b97ec4
Move and rename NetPeerUtils ( #2548 )
...
* Move and rename NetPeerUtils
* Rename NetPeerUtils to NetPeerAttributes; inject instance instead of using a global var
* Rename SpanAttributeSetter to AttributeSetter (might be used to set on AttributesBuilder in the future, who knows)
* Deprecate default BaseTracer constructor: library instrumentations are supposed to inject all dependencies, the javaagent should explicitly pass globals
* fix compilation failure
* Remove peer.service customization from library instrumentation
2021-03-16 13:50:19 +01:00
Anuraag Agrawal
dc769e3702
Expose only minimal entrypoint for Armeria library instrumentation. ( #2463 )
2021-03-02 10:39:23 -08:00
Trask Stalnaker
62f2611486
Update instrumentation names ( #2433 )
2021-03-01 19:34:25 -08:00
Anuraag Agrawal
0c764e8db0
Fix post-merge conflict ( #2358 )
2021-02-20 13:42:41 +09:00
Anuraag Agrawal
0290761acb
Migrate Armeria to HttpServer/ClientTest ( #2345 )
...
* Add HttpServerTest for Armeria
* semicolon
2021-02-20 10:35:54 +09:00
Anuraag Agrawal
000df967ce
Update to SDK 0.17.0 ( #2338 )
...
* Update to SDK 0.17.0
* Finish
* ottrace
2021-02-19 15:51:55 +09:00
Mateusz Rzeszutek
211e0b7ab2
Use ClassRule in armeria tests ( #2265 )
2021-02-13 11:54:39 +09:00